Mirrors/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-09-22 13:01:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(http_client): default Content-Type for post field

Browse Source
This commit is contained in:
Axymorrsen
2026-08-20 08:45:04 +08:00
parent 08e0d30a74
commit 22bb11ef22
2 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
components/esp_http_client/esp_http_client.c
View File

@@ -2065,7 +2065,7 @@ esp_err_t esp_http_client_set_post_field(esp_http_client_handle_t client, const
ESP_LOGD(TAG, "set post file length = %d", len);
if (client->post_data) {
char *value = NULL;
if ((err = esp_http_client_get_header(client, "Content-Type", &value)) != ESP_OK) {
if ((err = esp_http_client_get_header(client, "Content-Type", &value)) != ESP_OK && err != ESP_ERR_NOT_FOUND) {
return err;
}
if (value == NULL) {

40
components/esp_http_client/test_apps/main/test_http_client.c
View File

@@ -188,6 +188,46 @@ TEST_CASE("esp_http_client_set_header() should not return error if header value
esp_http_client_cleanup(client);
}
TEST_CASE("set_post_field adds default Content-Type when missing", "[esp_http_client]")
{
const esp_http_client_config_t config = {
.url = "http://localhost",
};
esp_http_client_handle_t client = esp_http_client_init(&config);
TEST_ASSERT_NOT_NULL(client);
const char post_data[] = "foo=bar";
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_set_post_field(client, post_data, strlen(post_data)));
char *content_type = NULL;
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_get_header(client, "Content-Type", &content_type));
TEST_ASSERT_NOT_NULL(content_type);
TEST_ASSERT_EQUAL_STRING("application/x-www-form-urlencoded", content_type);
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_cleanup(client));
}
TEST_CASE("set_post_field preserves explicit Content-Type", "[esp_http_client]")
{
const esp_http_client_config_t config = {
.url = "http://localhost",
};
esp_http_client_handle_t client = esp_http_client_init(&config);
TEST_ASSERT_NOT_NULL(client);
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_set_header(client, "Content-Type", "application/json"));
const char post_data[] = "{}";
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_set_post_field(client, post_data, strlen(post_data)));
char *content_type = NULL;
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_get_header(client, "Content-Type", &content_type));
TEST_ASSERT_NOT_NULL(content_type);
TEST_ASSERT_EQUAL_STRING("application/json", content_type);
TEST_ASSERT_EQUAL(ESP_OK, esp_http_client_cleanup(client));
}
TEST_CASE("set_url() to a different host strips Authorization header", "[esp_http_client]")
{
esp_http_client_config_t config = {