mirror of
https://github.com/SpartanJ/eepp.git
synced 2026-10-18 19:43:24 +03:00
Teardown and identity: - Detach native backends before scene children are destroyed and clear mRoot afterwards, fixing a use-after-free when an AT-SPI client is connected while a window closes. - Invalidate a deleted widget's subtree once, top-down, before OnClose handlers run (NODE_FLAG_DESTROYING). Descendants never walk into destroyed parents, and deleted identities cannot be re-registered. - Closing scenes expose no accessibility manager through either accessor. - Deleting widgets no client has seen allocates no identity and emits no events. - Ignore events from widgets not yet attached to a scene. Events: - Keep the order of state and structural events; coalesce only adjacent query-again hints. - Stop emitting per-widget BoundsChanged; bounds are queried on demand. - Report the Focused state and keyboard focus only on the projected focus owner, through a shared helper used by both paths. Model views: - Lazy child count and child queries, cached sibling indexes, selection and hit testing without enumerating rows. - Row identities follow inserted and removed rows; removed rows are pruned from native wrapper caches. - Expose the active cell editor as the child of the row or cell it edits. AT-SPI: - Correct state bits (EXPANDABLE/EXPANDED, SENSITIVE, CHECKABLE, SELECTABLE, READ_ONLY, SINGLE/MULTI_LINE, SELECTABLE_TEXT) and the password-text and panel roles. - Emit text-changed insert/delete, caret-moved and selection-changed events, diffed once per frame. Support line granularity, SetCaretOffset and selection editing. - Track clients by bus name so the active flag clears on disconnect. - Fix the I/O thread busy-spin and stranded dispatch backlog, flush queued signals, and type-check Properties.Set values. UIA: - Raise focus only for the focused element. - Defer UiaDisconnectProvider out of widget destruction. - Keep providers alive for in-flight cross-thread requests. - Reject unknown interfaces without a UI-thread round trip. - Require window-specific client activity. macOS: - Avoid repeated full node info builds. - Use sibling indexes and lazy child access. - Fix label/value deduplication for list items. Tests and docs: - Add regression tests for focus ownership, teardown, event ordering, lazy model identities, nested scenes and cell editors. - Extend the AT-SPI validation scripts and document the current performance characteristics and limitations.
348 lines
14 KiB
Python
348 lines
14 KiB
Python
#!/usr/bin/env python3
|
|
|
|
import argparse
|
|
import subprocess
|
|
import time
|
|
|
|
import gi
|
|
|
|
gi.require_version("Atspi", "2.0")
|
|
from gi.repository import Atspi, GLib
|
|
|
|
|
|
def pause(seconds):
|
|
# libatspi's cache and event dispatch share state with synchronous queries. Keep both on
|
|
# one thread; running event_main concurrently with these queries can corrupt the client.
|
|
context = GLib.MainContext.default()
|
|
while context.pending():
|
|
context.iteration(False)
|
|
time.sleep(seconds)
|
|
while context.pending():
|
|
context.iteration(False)
|
|
|
|
|
|
def wait_for_application(name, timeout, process_id=None):
|
|
deadline = time.monotonic() + timeout
|
|
while time.monotonic() < deadline:
|
|
desktop = Atspi.get_desktop(0)
|
|
for index in range(desktop.get_child_count() - 1, -1, -1):
|
|
application = desktop.get_child_at_index(index)
|
|
try:
|
|
if (
|
|
application
|
|
and application.get_name() == name
|
|
and (process_id is None or application.get_process_id() == process_id)
|
|
):
|
|
application.get_child_count()
|
|
return application
|
|
except Exception:
|
|
continue
|
|
pause(0.1)
|
|
raise RuntimeError(f'accessibility application "{name}" was not found')
|
|
|
|
|
|
def descendants(root):
|
|
result = []
|
|
pending = [root]
|
|
while pending:
|
|
node = pending.pop()
|
|
result.append(node)
|
|
for index in range(node.get_child_count() - 1, -1, -1):
|
|
child = node.get_child_at_index(index)
|
|
if child:
|
|
pending.append(child)
|
|
return result
|
|
|
|
|
|
def find_named(nodes, name):
|
|
for node in nodes:
|
|
if node.get_name() == name:
|
|
return node
|
|
raise RuntimeError(f'accessibility node "{name}" was not found')
|
|
|
|
|
|
def wait_for_nodes(application, names, timeout=2):
|
|
deadline = time.monotonic() + timeout
|
|
while True:
|
|
nodes = descendants(application)
|
|
available = {node.get_name() for node in nodes}
|
|
if all(name in available for name in names):
|
|
return nodes
|
|
if time.monotonic() >= deadline:
|
|
raise RuntimeError(f"accessibility tree did not expose {names}, got {sorted(available)}")
|
|
pause(0.05)
|
|
|
|
|
|
def action_index(node, name):
|
|
for index in range(node.get_n_actions()):
|
|
if Atspi.Action.get_localized_name(node, index) == name:
|
|
return index
|
|
raise RuntimeError(f'action "{name}" was not exposed by "{node.get_name()}"')
|
|
|
|
|
|
def check(condition, message):
|
|
if not condition:
|
|
raise RuntimeError(message)
|
|
|
|
|
|
def start_discovery_listener():
|
|
discovered_process_ids = set()
|
|
text_events = []
|
|
|
|
def on_children_changed(event):
|
|
if event.type.startswith("object:text-"):
|
|
text_events.append((event.type, event.detail1, event.detail2, event.any_data))
|
|
return
|
|
application = event.any_data
|
|
try:
|
|
if application:
|
|
discovered_process_ids.add(application.get_process_id())
|
|
except Exception:
|
|
pass
|
|
|
|
listener = Atspi.EventListener.new(on_children_changed)
|
|
check(
|
|
listener.register("object:children-changed:add"),
|
|
"could not register the AT-SPI application discovery listener",
|
|
)
|
|
for event in ("object:text-changed", "object:text-caret-moved", "object:text-selection-changed"):
|
|
check(listener.register(event), f"could not register {event}")
|
|
return listener, discovered_process_ids, text_events
|
|
|
|
|
|
def wait_for_window_count(application, count, timeout=2):
|
|
deadline = time.monotonic() + timeout
|
|
while application.get_child_count() != count and time.monotonic() < deadline:
|
|
pause(0.05)
|
|
check(application.get_child_count() == count, f"expected {count} application windows")
|
|
|
|
|
|
def validate(application, multi_window=False, close_primary=False, process_id=None, text_events=None):
|
|
required_nodes = ["Project name", "Enable autosave"]
|
|
if multi_window:
|
|
required_nodes.append("Secondary accessibility window")
|
|
nodes = wait_for_nodes(application, required_nodes)
|
|
check(len(nodes) >= 20, f"expected a complete accessibility tree, got {len(nodes)} nodes")
|
|
check(application.get_role_name() == "application", "root must be an application")
|
|
expected_windows = 2 if multi_window else 1
|
|
check(
|
|
application.get_child_count() == expected_windows,
|
|
f"expected {expected_windows} application windows, got {application.get_child_count()}",
|
|
)
|
|
for index in range(application.get_child_count()):
|
|
check(
|
|
application.get_child_at_index(index).get_role_name() == "window",
|
|
"each application child must be a native window",
|
|
)
|
|
|
|
project_name = find_named(nodes, "Project name")
|
|
check(project_name.get_role_name() == "entry", "Project name must be an entry")
|
|
states = project_name.get_state_set()
|
|
check(states.contains(Atspi.StateType.SENSITIVE), "enabled input must be sensitive")
|
|
check(states.contains(Atspi.StateType.SINGLE_LINE), "input must be single-line")
|
|
password = find_named(nodes, "Account password")
|
|
check(password.get_role() == Atspi.Role.PASSWORD_TEXT, "password must use the protected role")
|
|
check(project_name.get_accessible_id(), "Project name must expose a stable accessible ID")
|
|
locale = project_name.get_object_locale()
|
|
check(locale == "C", f"Project name locale query failed: {locale!r}")
|
|
check(project_name.get_help_text() == "", "Project name help text query failed")
|
|
check(project_name.get_attributes() is not None, "Project name attributes query failed")
|
|
check(project_name.get_relation_set() is not None, "Project name relations query failed")
|
|
check(project_name.get_layer() is not None, "Project name component layer query failed")
|
|
check(project_name.get_mdi_z_order() == 0, "Project name component Z-order query failed")
|
|
check(project_name.get_alpha() == 1, "Project name component alpha query failed")
|
|
project_extents = project_name.get_extents(Atspi.CoordType.SCREEN)
|
|
check(project_extents.width > 0 and project_extents.height > 0, "Project name extents are empty")
|
|
window = application.get_child_at_index(0)
|
|
if window.get_state_set().contains(Atspi.StateType.SHOWING):
|
|
hit = window.get_accessible_at_point(
|
|
project_extents.x + project_extents.width // 2,
|
|
project_extents.y + project_extents.height // 2,
|
|
Atspi.CoordType.SCREEN,
|
|
)
|
|
check(hit is not None, "visible window component hit test failed")
|
|
check(project_name.get_character_count() == 4, "Project name character count must equal 4")
|
|
check(Atspi.Text.get_text(project_name, 0, -1) == "eepp", "Project name text query failed")
|
|
check(project_name.get_text_attributes(0) is not None, "Project name text attributes query failed")
|
|
check(project_name.get_default_attributes() is not None, "Default text attributes query failed")
|
|
check(
|
|
Atspi.EditableText.set_text_contents(project_name, "eepp2"),
|
|
"Project name text replacement failed",
|
|
)
|
|
check(
|
|
Atspi.Text.get_text(project_name, 0, -1) == "eepp2",
|
|
"Project name replacement was not visible",
|
|
)
|
|
check(Atspi.Text.set_caret_offset(project_name, 2), "setting the caret failed")
|
|
check(project_name.get_caret_offset() == 2, "caret offset did not change")
|
|
check(Atspi.Text.add_selection(project_name, 1, 4), "adding a text selection failed")
|
|
check(Atspi.Text.set_selection(project_name, 0, 0, 3), "setting a text selection failed")
|
|
selection = Atspi.Text.get_selection(project_name, 0)
|
|
check((selection.start_offset, selection.end_offset) == (0, 3), "selection offsets are wrong")
|
|
check(Atspi.Text.remove_selection(project_name, 0), "removing a text selection failed")
|
|
check(project_name.get_n_selections() == 0, "selection was not removed")
|
|
if text_events is not None:
|
|
deadline = time.monotonic() + 2
|
|
while time.monotonic() < deadline and not any(
|
|
event[0] == "object:text-changed:insert" and event[1:4] == (4, 1, "2")
|
|
for event in text_events
|
|
):
|
|
pause(0.01)
|
|
check(any(event[0] == "object:text-changed:insert" and event[1:4] == (4, 1, "2")
|
|
for event in text_events), f"missing text insertion event: {text_events}")
|
|
check(any(event[0] == "object:text-caret-moved" and event[1] == 2
|
|
for event in text_events), "missing caret event")
|
|
check(any(event[0] == "object:text-selection-changed" for event in text_events),
|
|
"missing text selection event")
|
|
description = find_named(nodes, "Description")
|
|
check(description.get_state_set().contains(Atspi.StateType.MULTI_LINE), "edit must be multiline")
|
|
check(Atspi.EditableText.set_text_contents(description, "first\nsecond\nthird"),
|
|
"multiline replacement failed")
|
|
line = Atspi.Text.get_string_at_offset(description, 8, Atspi.TextGranularity.LINE)
|
|
check((line.content, line.start_offset, line.end_offset) == ("second\n", 6, 13),
|
|
f"line granularity returned the wrong range: {line}")
|
|
|
|
checkbox = find_named(nodes, "Enable autosave")
|
|
check(checkbox.get_role_name() == "check box", "autosave must be a check box")
|
|
check(checkbox.get_state_set().contains(Atspi.StateType.CHECKABLE), "checkbox must be checkable")
|
|
check(checkbox.do_action(action_index(checkbox, "toggle")), "checkbox toggle failed")
|
|
pause(0.05)
|
|
check(
|
|
checkbox.get_state_set().contains(Atspi.StateType.CHECKED),
|
|
"checkbox did not expose its checked state",
|
|
)
|
|
|
|
radio = find_named(nodes, "Light Theme")
|
|
check(radio.get_role_name() == "radio button", "theme must be a radio button")
|
|
check(radio.do_action(action_index(radio, "select")), "radio selection failed")
|
|
pause(0.05)
|
|
states = radio.get_state_set()
|
|
check(states.contains(Atspi.StateType.CHECKED), "radio did not expose checked state")
|
|
check(states.contains(Atspi.StateType.SELECTED), "radio did not expose selected state")
|
|
check(states.contains(Atspi.StateType.SELECTABLE), "radio must be selectable")
|
|
|
|
language = find_named(nodes, "Language")
|
|
check(language.get_state_set().contains(Atspi.StateType.EXPANDABLE), "combo must be expandable")
|
|
check(language.do_action(action_index(language, "expand")), "combo expansion failed")
|
|
pause(0.05)
|
|
check(language.get_state_set().contains(Atspi.StateType.EXPANDED), "combo must report expanded")
|
|
check(language.do_action(action_index(language, "collapse")), "combo collapse failed")
|
|
|
|
spin = find_named(nodes, "Retry count")
|
|
check(spin.get_role_name() == "spin button", "Retry count must be a spin button")
|
|
check(spin.get_current_value() == 3, "Retry count must initially equal 3")
|
|
check(spin.get_minimum_value() == 0, "Retry count minimum must equal 0")
|
|
check(spin.get_maximum_value() == 10, "Retry count maximum must equal 10")
|
|
check(spin.grab_focus(), "spin focus action failed")
|
|
pause(0.05)
|
|
check(spin.get_state_set().contains(Atspi.StateType.FOCUSED), "spin must report internal input focus")
|
|
|
|
find_named(nodes, "Colors")
|
|
find_named(nodes, "Projects")
|
|
if multi_window:
|
|
find_named(nodes, "Secondary accessibility window")
|
|
open_window = find_named(nodes, "Open accessibility window")
|
|
check(
|
|
open_window.do_action(action_index(open_window, "click")),
|
|
"dynamic window open action failed",
|
|
)
|
|
application = wait_for_application("eepp - Accessibility", 2, process_id)
|
|
wait_for_window_count(application, 3)
|
|
dynamic_nodes = descendants(application)
|
|
find_named(dynamic_nodes, "Dynamic accessibility window")
|
|
close_dynamic = find_named(dynamic_nodes, "Close dynamic window")
|
|
check(
|
|
close_dynamic.do_action(action_index(close_dynamic, "click")),
|
|
"dynamic window close action failed",
|
|
)
|
|
application = wait_for_application("eepp - Accessibility", 2, process_id)
|
|
wait_for_window_count(application, 2)
|
|
close_name = "Close primary window" if close_primary else "Close secondary window"
|
|
close = find_named(nodes, close_name)
|
|
check(close.do_action(action_index(close, "click")), f"{close_name} action failed")
|
|
application = wait_for_application("eepp - Accessibility", 2, process_id)
|
|
wait_for_window_count(application, 1)
|
|
if close_primary:
|
|
remaining = application.get_child_at_index(0)
|
|
check(
|
|
remaining.get_name() == "eepp - Accessibility Secondary",
|
|
"secondary window did not become the surviving application root",
|
|
)
|
|
# Component extents require a live request, unlike a potentially cached name. Verify
|
|
# that the I/O thread still wakes the application after the previous Input is destroyed.
|
|
extents = remaining.get_extents(Atspi.CoordType.SCREEN)
|
|
check(extents.width > 0 and extents.height > 0, "surviving window stopped responding")
|
|
close_last = find_named(descendants(application), "Close secondary window")
|
|
check(close_last.do_action(action_index(close_last, "click")), "last window close failed")
|
|
print(f"AT-SPI validation passed: {len(nodes)} nodes")
|
|
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser(description="Validate the eepp accessibility example via AT-SPI")
|
|
parser.add_argument("--application", default="eepp - Accessibility")
|
|
parser.add_argument("--executable", default="bin/eepp-ui-accessibility")
|
|
parser.add_argument("--no-launch", action="store_true")
|
|
parser.add_argument("--multi-window", action="store_true")
|
|
parser.add_argument("--close-primary", action="store_true")
|
|
parser.add_argument("--hidden", action="store_true", help="keep all example windows hidden")
|
|
parser.add_argument("--timeout", type=float, default=5.0)
|
|
parser.add_argument("--process-id", type=int)
|
|
args = parser.parse_args()
|
|
|
|
process = None
|
|
discovery_listener = None
|
|
text_events = None
|
|
try:
|
|
if not args.no_launch:
|
|
discovery_listener, discovered_process_ids, text_events = start_discovery_listener()
|
|
command = [args.executable]
|
|
if args.hidden:
|
|
command.append("--hidden")
|
|
if args.multi_window or args.close_primary:
|
|
command.append("--multi-window")
|
|
if args.close_primary:
|
|
command.append("--close-primary")
|
|
process = subprocess.Popen(command)
|
|
application = wait_for_application(
|
|
args.application,
|
|
args.timeout,
|
|
process.pid if process is not None else args.process_id,
|
|
)
|
|
if process is not None:
|
|
deadline = time.monotonic() + args.timeout
|
|
while process.pid not in discovered_process_ids and time.monotonic() < deadline:
|
|
pause(0.05)
|
|
check(
|
|
process.pid in discovered_process_ids,
|
|
"the newly launched application was not announced through AT-SPI",
|
|
)
|
|
validate(
|
|
application,
|
|
args.multi_window or args.close_primary,
|
|
args.close_primary,
|
|
process.pid if process is not None else args.process_id,
|
|
text_events,
|
|
)
|
|
if process is not None and args.close_primary:
|
|
check(process.wait(timeout=3) == 0, "native backend teardown crashed on last-window closure")
|
|
finally:
|
|
if discovery_listener:
|
|
try:
|
|
for event in ("object:children-changed:add", "object:text-changed",
|
|
"object:text-caret-moved", "object:text-selection-changed"):
|
|
discovery_listener.deregister(event)
|
|
except GLib.Error:
|
|
# A closed bus must not mask the original failure or skip child-process cleanup.
|
|
pass
|
|
if process and process.poll() is None:
|
|
process.terminate()
|
|
try:
|
|
process.wait(timeout=1)
|
|
except subprocess.TimeoutExpired:
|
|
process.kill()
|
|
process.wait()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|