fix(node): undefine NAPI_EXPERIMENTAL

This fixes build with Node v20.12.2. Related upstream issue: <https://github.com/nodejs/node/issues/52229>
x
2026-04-02 05:22:14 +03:00 · 2024-04-22 22:44:03 +00:00 · 2024-04-22 22:36:52 +00:00 · 2024-04-22 22:33:31 +00:00 · 2024-04-22 22:28:01 +00:00 · 2024-04-22 22:25:13 +00:00
2 changed files with 5 additions and 3 deletions
--- a/.github/workflows/node-tests.yml
+++ b/.github/workflows/node-tests.yml
@@ -21,14 +21,17 @@ jobs:
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-14, windows-latest]
+        node: ["18", "20"]
    steps:
      - uses: actions/checkout@v4
        with:
          show-progress: false
      - uses: actions/setup-node@v4
        with:
-          node-version: "18"
+          node-version: ${{ matrix.node }}
+      - if: matrix.os == 'macos-14'
+        run: sudo xcode-select --switch /Applications/Xcode_15.3.app/Contents/Developer
      - name: System info
        run: |
          rustc -vV
--- a/node/src/module.c
+++ b/node/src/module.c
@@ -1,5 +1,4 @@
 #define NAPI_VERSION 4
-#define NAPI_EXPERIMENTAL

 #include <stdlib.h>
 #include <stdio.h>
Author	SHA1	Message	Date
link2xt	cde0fb32e6	fix(node): undefine NAPI_EXPERIMENTAL This fixes build with Node v20.12.2. Related upstream issue: <https://github.com/nodejs/node/issues/52229>	2024-04-22 22:44:03 +00:00
link2xt	f1bbd676c6	x	2024-04-22 22:36:52 +00:00
link2xt	d924637830	x	2024-04-22 22:33:31 +00:00
link2xt	6aa044a70a	x	2024-04-22 22:28:01 +00:00
link2xt	8a827495ef	ci(node): use newer xcode	2024-04-22 22:25:13 +00:00
link2xt	e290a7b852	ci(node): test against node 20	2024-04-22 21:57:18 +00:00