björn petersen
cbc3579e9a
Merge pull request #489 from deltachat/no-recursive-delete
...
do not recursive delete folders
2019-09-11 19:39:15 +02:00
B. Petersen
177ab0229a
do not call fs::remove_dir_all() implicitly on non-files; deleting folders is not needed and calling remove_dir_all() is considered harmful
2019-09-11 17:02:27 +02:00
Alexander Krotov
68b5e34fed
Merge pull request #488 from KAction/transfer
...
Reduce indentation in dc_continue_key_transfer
2019-09-11 05:36:02 +00:00
Dmitry Bogatov
2eda839303
cargo-fmt
2019-09-11 02:21:39 +00:00
Dmitry Bogatov
71a01d3002
Reduce indentation in dc_continue_key_transfer
...
Replace `if (ok) { }` pattern with `if (!ok) return` to reduce
indentation level.
Note: This commit fails CI due incorrect formatting. It is done
deliberately to simplify review process.
2019-09-11 02:21:39 +00:00
Alexander Krotov
995548002b
Merge pull request #484 from link2xt/safe_test_encryption_decryption
...
Safe test encryption decryption
2019-09-11 00:43:21 +00:00
Alexander Krotov
38ad16887b
Merge pull request #487 from KAction/top_evil
...
Minor refactoring
2019-09-11 00:42:48 +00:00
Dmitry Bogatov
c20e8f7613
Use safe version of dc_decode_header_words on one call site
2019-09-10 23:31:29 +00:00
Dmitry Bogatov
5bd4606854
Implement safe version of `dc_decode_header_words'
2019-09-10 23:26:08 +00:00
Dmitry Bogatov
e7b198849d
Copy comment for dc_encode_headers_words from C code
2019-09-10 22:49:53 +00:00
Dmitry Bogatov
3ab0d74af2
Remove unused `unsafe' block in log_event! macro
2019-09-10 22:35:54 +00:00
Dmitry Bogatov
7ed5a8e72f
Reimplement logging macros in terms of log_event!
...
Avoid copy-paste message formatting code in src/log.rs, forwarding all
arguments of info! warn! error! macros to generic log_event! macro.
2019-09-10 22:34:38 +00:00
Dmitry Bogatov
57daa0f7f0
Remove useless argument of logging macros
...
Previously, logging macros (info! warn! error!) accepted integer
argument (data1), that was passed to callback function verbatim. In all
call sites this argument was 0.
With this change, that data1 argument is no longer part of macro
interface, 0 is always passed to callback in internals of these macros.
2019-09-10 22:26:47 +00:00
Dmitry Bogatov
2dd3f169db
Use set_config_bool instead of set_config_int in boolean context
2019-09-10 22:26:47 +00:00
Dmitry Bogatov
b97b618b4b
Use sql.get_config_bool to simplify dc_is_configured
2019-09-10 22:26:47 +00:00
Dmitry Bogatov
bb12488200
Add Sql.{set,get}_config_bool methods
...
Previously, boolean configurations were implemented on top of i32
(get_config_int, set_config_it) at call sites.
Having one canonical location, containing boolean <-> database
conversion may help to avoid serialization issues.
2019-09-10 22:26:47 +00:00
Alexander Krotov
706a97b013
Move part of test_encryption_decryption to key.rs
2019-09-11 00:40:46 +03:00
Dmitry Bogatov
1cdb9c733a
Change return type of `dc_is_configured' to bool
2019-09-10 19:08:55 +00:00
holger krekel
ffc525af9e
pragmatismatic: run flaky tests three times to see if we can get more "green" CI runs this way ...
...
thanks to @the-compiler also modernize plugin usage
2019-09-10 20:51:52 +02:00
Dmitry Bogatov
1576dc1d13
top_evil_rs: check for all-caps version of ok_to_continue pattern
2019-09-10 17:34:17 +00:00
Dmitry Bogatov
4fbb5fbb25
Make it easier to run src/top_evil_rs.py from git root
...
Currently, `src/top_evil_rs.py' script recursively scans current
directory for Rust sources and print statistics about them.
When run from git root, it also scans target/ directory, which is
useless.
This commit add cludge that checks if script is run from git root
directory, and `chdir' into `src/' before performing actions.
Unprincipled, but convenient.
2019-09-10 17:34:16 +00:00
B. Petersen
e9da21a02e
cargo fmt
2019-09-10 19:14:51 +02:00
Alexander Krotov
f1c026c5ec
Pass passphrase to dc_pgp_symm_{en,de}crypt as &str
2019-09-10 15:58:42 +02:00
björn petersen
3d61c06ea9
Merge pull request #478 from deltachat/fix477
...
fix crash when msg_raw is None
2019-09-10 15:50:33 +02:00
Alexander Krotov
22c1ee1f55
cargo fmt
2019-09-10 16:29:41 +03:00
Alexander Krotov
971960a242
key.rs: remove unsafe Key.from_binary
2019-09-10 16:29:24 +03:00
Alexander Krotov
69f8973339
test_encryption_decryption: use safe from_slice instead of from_binary
2019-09-10 16:29:24 +03:00
B. Petersen
bf1d9b6d06
fix crash when msg_raw is None
2019-09-10 15:20:38 +02:00
Alexander Krotov
6a2368f83c
Return bool from dc_continue_key_transfer
2019-09-10 15:15:48 +02:00
Alexander Krotov
d0960f7f7f
Merge pull request #483 from link2xt/dc_msg_exists_safe
...
Make dc_msg_exists safe and rusty
2019-09-10 15:15:33 +03:00
Alexander Krotov
e5ad697466
Make dc_msg_exists safe and rusty
2019-09-10 14:21:27 +03:00
Alexander Krotov
188eab5faf
Fix test_encryption_decryption
...
It is broken since 28cae607a4
2019-09-10 12:00:59 +02:00
holger krekel
2b257e3d0d
fix ffi
2019-09-09 19:45:43 +02:00
Alexander Krotov
77c9746be5
Make dc_msg_get_filemime safe
2019-09-09 19:45:43 +02:00
Alexander Krotov
28cae607a4
Pass buffers to pgp.rs as slices
2019-09-09 18:50:47 +02:00
Simon Laux
814281ed7d
fixes #463
2019-09-09 18:44:30 +02:00
holger krekel
5b0c8dd9dd
address @r10s and @flub review comments, and fix some docstrings/test meta docs
2019-09-09 18:07:32 +02:00
holger krekel
650d8c45ec
fix test, and cleanup according profile-image API
2019-09-09 18:07:32 +02:00
holger krekel
383d8980d6
add profile image API to python, tests, Rust fixes/cleanups
2019-09-09 18:07:32 +02:00
Simon Laux
6ea706c646
remove macro
2019-09-09 18:07:32 +02:00
Simon Laux
1ed2af08b8
cargo fmt
2019-09-09 18:07:32 +02:00
Simon Laux
7563a5abe0
remove closure
...
Co-authored-by: @Jikstra
2019-09-09 18:07:32 +02:00
Simon Laux
0a8b187f80
fix remove chat profile img
2019-09-09 18:07:32 +02:00
björn petersen
275aa853f5
Merge pull request #471 from deltachat/fix417
...
fix crash when downloading message
2019-09-09 16:18:50 +02:00
Friedel Ziegelmayer
3614d57f9f
Merge pull request #469 from deltachat/refctor/strencode
...
refactor(strencode): rustify some strencode methods
2019-09-09 11:52:30 +02:00
B. Petersen
1367873949
check bounds before accessing Vec
2019-09-09 01:47:50 +02:00
B. Petersen
d933183e0a
mark safe functions as such
2019-09-09 01:47:50 +02:00
B. Petersen
7e11def527
make code more readable
2019-09-09 00:01:15 +02:00
dignifiedquire
f3e53a05a6
refactor(loginparam): rename dc_loginparam -> login_param
2019-09-08 18:48:57 +02:00
dignifiedquire
dd381a5c1c
refactor(loginparam): simplify and rustify
2019-09-08 18:48:57 +02:00
