Commit Graph
78 Commits
Author SHA1 Message Date
Hocuri ee7b7eb4f2 Once more, fix #1575 Messages sent by DeltaChat trigger spam filters due to incorrect/non-compliant formatting options 2020-07-11 21:10:06 +03:00
Hocuri b50410ab15 Fix #1687 2020-07-11 17:38:48 +02:00
Hocuri 9f7567c1d1 Abort on failing imap configuring 2020-07-11 14:27:15 +02:00
Hocuri 68e3bce60e Remove error!() from https://github.com/deltachat/deltachat-core-rust/pull/1539
it led to a less clear error message being shown when the configure
failed.
2020-07-11 14:27:15 +02:00
Hocuri 86bc54508f More explicit 2020-07-11 14:27:15 +02:00
Hocuri ae2fd4014a Emit Event::ErrorNetwork again 2020-07-11 14:27:15 +02:00
Hocuri 2c23433185 Make it work
Add a mutex to prevent a race condition when a "your pw is wrong" warning is sent, resulting in multiple messeges being sent.

Do not mute the device chat but "only" send MsgsChanged event when no
notification shall be shown.

More logging.
2020-07-11 14:27:15 +02:00
Hocuri 3f2e67f07a First try for notification 2020-07-11 14:27:14 +02:00
Hocuri 06a4f15995 Better warning if the pw is wrong 2020-07-11 14:27:14 +02:00
Hocuri 8c2af132c8 Sync heuristically_parse_ndn() and maybe_ndn in prefetch_should_download() 2020-06-17 12:42:40 +02:00
Hocuri 79145576ab s/fingerprint/fingerpring.hex()/ 2020-06-17 11:08:38 +02:00
Hocuri 8ca55b0f60 clippy 2020-06-17 10:58:27 +02:00
Hocuri 74cb4ca1cd Check for mime_parser.has_chat_version() instead of is_dc_message != MessengerMessage::No and avoid passing is_dc_message around, this will save us output &mut argument and simplify the logic. 2020-06-17 10:58:27 +02:00
Hocuri 351e5dc6f3 Add Python test 2020-06-17 10:58:27 +02:00
Hocuri 4eee4a08e7 Mark read receipts as read 2020-06-17 10:58:27 +02:00
Hocuri 40c9c2752b Parse ndns from Tiscali 2020-06-17 10:39:05 +02:00
Hocuri eb29f9c4c1 Parse testrun NDNs 2020-06-15 16:20:23 +02:00
Hocuri 23d6012c1f Start parsing ndns (#1552)
Fix  #1478

I changed my original plans a little because I had so many extra ideas and then sorted that I should rather look at actual NDNs and look what is necessary to parse them:

- Recognize NDNs by ~the sender address, which is in a regex the providers database. The problem with heuristics would be that someone could send fake-NDNs and mark messages as failed.~ the standard ("report/delivery-status") and heuristics ("subject contains 'fail' and sender contains 'daemon'"). If there is a valid Message-ID, then rely on that this is an NDN (of course, generally someone might try to find out a Message-ID and send a fake NDN).
- ~Look for `In-Reply-To`~ (only Gmail did this and Gmail uses rfc822 anyway.)
- ~Look for a mimepart `message/delivery-status`, which might contain a `X-Original-Message-ID`~ (only Gmail did this and Gmail uses rfc822, too, anyway.).
- Search through the body and look for a line `Message-ID: *` (remember to remove `<`, `>`), in the hope that that's the original header
- Look for a mime-part containing the string `rfc822`, which will contain the original header. Parse them with Mailparse and look for `Message-ID`.
2020-06-13 17:44:29 +02:00
Hocuri 15b30ceed1 check for sender mailer-daemon as link2xt proposed 2020-06-13 17:29:38 +02:00
Hocuri 45b871f76d Look at From instead of Subject and ContentType in prefetch_should_download. 2020-06-13 14:18:16 +02:00
Hocuri 9f1112833f let prefetch_should_download() check if it might be an ndn 2020-06-13 12:06:30 +02:00
Hocuri bbf049e95b string 2020-06-13 10:18:18 +02:00
Hocuri 52dfa9b536 Renaming, comment 2020-06-13 10:18:18 +02:00
Hocuri 1fe85dfb3c more functional 2020-06-13 10:18:17 +02:00
Hocuri 27ff1c4a75 check in heuristically_parse_ndn() that rfc724_mid_exists() so that we do not ignore emails because we erreneously thought that it was an ndn 2020-06-13 10:18:17 +02:00
Hocuri adf4035775 rename reports 2020-06-13 10:18:17 +02:00
Hocuri 990c80cedf lots of small fixes from the reviews 2020-06-13 10:18:17 +02:00
Hocuri 8ebce0c861 warn instead of error 2020-06-13 10:18:16 +02:00
Hocuri ffb6a84b1f Warn instead of error 2020-06-13 10:18:16 +02:00
Hocuri c60ec00aac Oops #2, adapt DC_STR_COUNT in deltachat.h 2020-06-13 10:18:16 +02:00
Hocuri dd3f81a556 Oops, add FAILED_SENDING_TO to deltachat.h 2020-06-13 10:18:16 +02:00
Hocuri 8938cb2573 clippy 2020-06-13 10:18:16 +02:00
Hocuri 995660020b rm unused aol_ndn.eml (aol's ndns are very similar to these of Yahoo) 2020-06-13 10:18:15 +02:00
Hocuri 7997e7dde4 remove println 2020-06-13 10:18:15 +02:00
Hocuri 20ad98d168 typo 2020-06-13 10:18:15 +02:00
Hocuri c827c9d209 Add yahoo test 2020-06-13 10:18:15 +02:00
Hocuri bde97b20e9 Repair getting x-failed-recipients header, all tests passing now 2020-06-13 10:18:15 +02:00
Hocuri 777df24c75 Make the gmx test pass 2020-06-13 10:18:14 +02:00
Hocuri e1711855cc Make the posteo test pass 2020-06-13 10:18:14 +02:00
Hocuri 3899d70b3c I hate SQL 2020-06-13 10:18:14 +02:00
Hocuri e7aee5b4f4 add gmx and posteo tests 2020-06-13 10:18:14 +02:00
Hocuri bd2a7a3d40 Correct failed recipient 2020-06-13 10:18:13 +02:00
Hocuri 2e59d5674e fix sql 2020-06-13 10:18:13 +02:00
Hocuri 98b5f768b6 Improve test, fixed compile errors from rebasing 2020-06-13 10:18:13 +02:00
Hocuri b7d0f29002 Add test-data/message/gmx_ndn.eml 2020-06-13 10:18:13 +02:00
Hocuri df9cb5e3b8 Fix error in message info 2020-06-13 10:18:12 +02:00
Hocuri a30486112f Add test 2020-06-13 10:18:12 +02:00
Hocuri 016b96e30e Fix migration 2020-06-13 10:18:12 +02:00
Hocuri 6b763bf417 Return true for MessageState::OutMdnRcvd.can_fail() because it could be a group message and only some recipients failed 2020-06-13 10:18:12 +02:00
Hocuri 6ded0d3bc1 Do not show error messages in chat 2020-06-13 10:18:12 +02:00
Hocuri f0837cfa73 Repair errors saved for messages 2020-06-13 10:18:11 +02:00
Hocuri 8350729cbb Improve errors 2020-06-13 10:18:11 +02:00
Hocuri 3757e5dca1 Try to add decent error msg (doesnt work yet) 2020-06-13 10:18:11 +02:00
Hocuri f02c17cae4 Parse standard ndns (e.g. Gmail) 2020-06-13 10:18:11 +02:00
Hocuri 6d2d31928d Warn about the correct folder 2020-06-11 14:36:08 +02:00
Hocuri 69e01862b7 More verbose SMTP connect error to see what is going on at #1556 2020-06-11 08:55:47 +02:00
Hocuri 4dbe836dfa rebuild cargo.lock 2020-06-10 13:22:03 +02:00
Hocuri 322cc5a013 Cargo update 2020-06-10 13:22:03 +02:00
Hocuri 7cc5243130 Also revert cargo.lock 2020-06-10 13:22:03 +02:00
Hocuri ba549bd559 Revert "Use cloned repos until https://github.com/deltachat/rust-email/pull/4 is merged"
This reverts commit df66f16c84f1a827619e67b3b989a6070f526f31.
2020-06-10 13:22:03 +02:00
Hocuri 84be82c670 Add test 2020-06-10 13:22:03 +02:00
Hocuri acb42982b7 Use cloned repos until https://github.com/deltachat/rust-email/pull/4 is merged 2020-06-10 13:22:03 +02:00
Hocuri 3370c51b35 Add test 2020-06-10 13:22:03 +02:00
Hocuri dcfed03702 MISSING_MIME_VERSION, MIME_HEADER_CTYPE_ONLY 2020-06-10 13:22:03 +02:00
Hocuri c18705fae3 Improve test 2020-06-07 12:11:52 +02:00
Hocuri 22973899b8 Assume that thare always is Config::Addr set 2020-06-07 12:11:52 +02:00
Hocuri f172e92098 Repair test 2020-06-07 12:11:52 +02:00
Hocuri e1ff657c78 Dont Hardcode 'Delta Chat' 2020-06-07 12:11:52 +02:00
Hocuri 3e6cd3ff34 Adapt to async, set first subject to 'Message from <sender name>' 2020-06-07 12:11:52 +02:00
Hocuri 17a13f0f83 Adapt spec.md to new subject (#1395) 2020-06-06 18:34:50 +02:00
Hocuri 05e1c00cd1 fix: update message ids correctly
Fixes #1495
2020-06-05 16:27:22 +02:00
Hocuri 7b3a962498 Sanitize address book 2020-05-31 17:04:25 +02:00
Hocuri 41bba7e780 Fix #880 Don't vary advanced login settings if a user set a particular setting 2020-05-29 20:31:34 +02:00
Hocuri b6161c431b Fix #1474 "Sending message to contact with < or > in Recipient gets treated as "Sent" but is not received" (#1476)
Fix #1474 "Sending message to contact with < or > in Recipient gets treated as "Sent" but is not received".

As I was at it, I also extracted the correct name and address from addresses like Mueller, Dave <dave@domain.com>.
2020-05-29 18:14:21 +02:00
Hocuri 26b0c43cc4 Remove help for nonexisting open and close commands.
See #1496
2020-05-22 18:45:42 +02:00
Hocuri df3fac4e5e Make clear that dc_set_chat_mute_duration() and dc_chat_is_muted() belong together. 2020-05-16 22:32:07 +02:00
Hocuri ab253744f8 Code style 2020-05-16 15:07:01 +02:00
Hocuri fca9eae0fd Extract flags in try_load() to variables 2020-05-12 20:28:20 +02:00