Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-10-02 03:00:40 +03:00
Code Issues Packages Projects Releases Wiki Activity
7,127 Commits 611 Branches 397 Tags
465bcd46f89f2c198f1cc0423da3e7af0546bbc6
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
link2xt d4d6ced957 fix: do not return hidden chat from dc_get_chat_id_by_contact_id 2023-11-10 20:00:28 +00:00
link2xt 1a4c2953f7 refactor: get rid of InterruptInfo 
It was passed around, but the boolean inside was not used.
 2023-11-10 16:38:01 +00:00
link2xt 765c95de39 refactor(imap): do not check if IDLE is supported twice 
We already check if IDLE is supported outside of idle()
 2023-11-10 16:38:01 +00:00
link2xt b2ea8f54df refactor(imap): reduce indentation level in fetch_idle() 2023-11-10 16:38:01 +00:00
link2xt d7aecabcaa fix: do not apply group changes to special chats 
This is a similar check to the one we have in `save_locations`.
 2023-11-10 15:46:45 +00:00
link2xt ce016eb567 feat: add secondary verified key 
When a key is gossiped for the contact in a verified chat,
it is stored in the secondary verified key slot.

The messages are then encrypted to the secondary verified key
if they are also encrypted to the contact introducing this secondary key.

Chat-Group-Member-Added no longer updates the verified key.
Verified group recovery only relies on the secondary verified key.

When a message is received from a contact
signed with a secondary verified key,
secondary verified key replaces the primary verified key.
When verified key is changed for the contact
in response to receiving a message
signed with a secondary verified key,
"Setup changed" message is added
to the same chat where the message is received.
 2023-11-10 15:45:10 +00:00
link2xt 57e34abe98 fix: make UidGrouper robust against duplicate UIDs 2023-11-10 15:42:40 +00:00
link2xt fd92b7c455 fix: remove Reporting-UA from read receipts 
Do not leak Delta Chat core verison to everyone
 2023-11-10 15:37:30 +00:00
link2xt 1856c622a1 test(deltachat-rpc-client): log all events as debug messages 
This is necessary to debug the tests.
 2023-11-09 10:06:05 +01:00
link2xt 0a48a2effa refactor: replace inviter_progress macro with a function 2023-11-09 01:58:25 +00:00
link2xt 543864f0f5 test(deltachat-rpc-client): fix securejoin tests 
Wait for Bob (joiner) progress 1000
and do not return too early in test_qr_setup_contact().
 2023-11-09 01:57:13 +00:00
link2xt 0fe94e47cc test: enable verified 1:1 chats in deltachat-rpc-client tests 2023-11-09 01:57:13 +00:00
link2xt fc09210aea api: emit JoinerProgress(1000) event when Bob verifies Alice 2023-11-09 01:57:13 +00:00
link2xt 391cffb454 docs: add dc_chat_is_protection_broken() to 1.127.0 changelog 2023-11-08 17:53:17 +00:00
link2xt 620e363ce6 refactor(deltachat-rpc-client): use itertools for thread-safe request ID generation 2023-11-08 17:06:25 +00:00
link2xt 0c2276775d test: test that joining a group verifies Alice and vice versa 2023-11-08 01:56:45 +00:00
link2xt 14adcdb517 fix: treat reset state as encryption not preferred 
This will still degrade 1:1 chats to no encryption,
but will not cause the group to disable encryption
simply because one user got into reset state.
 2023-11-07 21:24:23 +00:00
link2xt cc80590488 test(deltachat-rpc-client): move securejoin tests to a separate file 2023-11-07 18:21:44 +00:00
link2xt 48416289ac api: add dc_contact_is_profile_verified() 2023-11-07 18:14:33 +00:00
link2xt 003a27f625 refactor: hide ChatId::get_for_contact() from public API 2023-11-07 01:19:14 +00:00
link2xt 9adf856705 chore: upgrade toml dependency 2023-11-06 22:22:12 +00:00
link2xt 2215de5285 chore(release): prepare for 1.129.1 2023-11-06 20:05:13 +00:00
link2xt 836f65376c fix(deltachat-rpc-client): add the Lock around request ID 
Avoid handing out the same request ID twice.
 2023-11-06 20:00:17 +00:00
link2xt 99940dd28c fix: update tokio-imap to fix Outlook STATUS parsing bug 2023-11-06 19:05:36 +00:00
link2xt ffeb801b58 chore(release): prepare for 1.129.0 2023-11-06 11:07:03 +00:00
link2xt 339bbcf070 chore: update dependencies 2023-11-06 10:53:40 +00:00
link2xt 7b83bddc2d fix(imap): always advance expected UIDNEXT to avoid skipping IDLE in a loop 
Ensure the client does not busy loop
skipping IDLE if UIDNEXT of the mailbox is higher than
the last seen UID plus 1, e.g. if the message
with UID=UIDNEXT-1 was deleted before we fetched it.

We do not fallback to UIDNEXT=1 anymore
if the STATUS command cannot determine UIDNEXT.
There are no known IMAP servers with broken STATUS so far.
This allows to guarantee that select_with_uidvalidity()
sets UIDNEXT for the mailbox and use it in fetch_new_messages()
to ensure that UIDNEXT always advances even
when there are no messages to fetch.
 2023-11-06 10:30:25 +00:00
link2xt 5549733a0b test: fix flaky test_forward_increation() test 2023-11-06 04:46:10 +00:00
link2xt 4e21917c0e feat: enable sync messages by default 2023-11-05 21:11:47 +00:00
link2xt fd0770859d chore(deltachat-jsonrpc): remove unused node-fetch dependency 2023-11-05 18:19:18 +00:00
link2xt d5854fb3c9 chore(node): update @types/node 2023-11-05 18:16:37 +00:00
link2xt 3aa22a27cc chore(node): remove unused node-fetch dependency 2023-11-05 18:14:38 +00:00
link2xt 10b1a2f5f5 chore(node): update prettier dependency 2023-11-05 18:12:16 +00:00
link2xt a28a34773c docs: remove documentation for non-existing dc_accounts_new os_name param 2023-11-05 17:54:00 +00:00
link2xt 7c744d14d7 docs: contact profile view should not use dc_contact_is_verified() 
Green checkmark in the contact profile
should only be displayed in the title
if the same checkmark is displayed in the title of 1:1 chat.
If 1:1 chat does not exist,
the checkmark should not be displayed in the title
of the contact profile.

Also add docs to is_protected
property of FullChat and BasicChat JSON objects.
 2023-11-05 17:21:23 +00:00
link2xt 6c68f2eb7e chore: update dependencies 2023-11-05 15:54:29 +00:00
link2xt eb2d2b7313 refactor: accept &str instead of Option<String> in idle() 2023-11-05 15:32:37 +00:00
link2xt 2e50abedaa fix: check UIDNEXT with a STATUS command before going IDLE 
This prevents accidentally going IDLE
when the last new message has arrived
while the folder was closed.
For example, this happened in some tests:
1. INBOX is selected to fetch, move and delete messages.
2. One of the messages is deleted.
3. INBOX is closed to expunge the message.
4. A new message arrives.
5. INBOX is selected with (CONDSTORE) to sync flags.
6. Delta Chat goes into IDLE without downloading the new message.

To determine that a new message has arrived
we need to notice that UIDNEXT has advanced when selecting the folder.
However, some servers such as Winmail Pro Mail Server 5.1.0616
do not return UIDNEXT in response to SELECT command.

To avoid interdependencies with the code
SELECTing the folder and having to implement
STATUS fallback after each SELECT even when we
may not want to go IDLE due to interrupt or unsolicited EXISTS,
we simply call STATUS unconditionally before IDLE.
 2023-11-05 09:58:58 +01:00
link2xt ee53136ed2 refactor: add hostname to "no DNS resolution results" error message 2023-11-05 09:58:33 +01:00
link2xt 16b40f3a19 feat: hardcode mail.sangham.net into DNS cache 2023-11-04 17:48:57 +00:00
link2xt d840a7e6b9 api!: remove deprecated get_verifier_addr 2023-11-03 23:17:09 +00:00
link2xt d875691955 chore(cargo): update dependencies 2023-11-03 21:12:10 +00:00
link2xt 973ffa1a64 fix: allow to change verified key via "member added" message 
"Member added" message likely happens because
the contact adding a new member has another
chat with the contact
 2023-11-03 17:51:11 +00:00
link2xt caffc3d93c fix(json-rpc): return verifier even if the contact is not verified 
This may happen if autocrypt key is changed after verification.
UI should still display who introduced the contact,
especially if the contact is still a member of some verified group.
If the contact is at the same time not verified,
i.e. its autocrypt key does not match verified key,
UI may display a crossed out checkmark instead of green checkmark.
 2023-11-03 17:51:11 +00:00
link2xt a4dcf656f3 api: add JSON-RPC get_chat_id_by_contact_id API (#4918) 2023-11-03 13:55:07 +00:00
link2xt 7bb5d48966 refactor: improve error handling in securejoin code 
Result::Err is reserved for local errors,
such as database failures.
Not found peerstate in the database is a protocol failure,
so just return Ok(false) in mark_peer_as_verified().

This allows to handle more errors with `?`.
 2023-11-02 15:54:35 +00:00
link2xt 0619e2a129 chore(release): prepare for 1.128.0 2023-11-02 01:53:42 +00:00
link2xt 0431ae53ca hack: decrease ratelimit for .testrun.org subdomains 2023-11-02 00:30:44 +00:00
link2xt 2efd0461d1 Revert "fix: add secondary verified key" 
This reverts commit 5efb100f12.
 2023-11-01 13:55:39 +00:00
link2xt 045d919cdc refactor(deltachat-rpc-client): factor out resetup_account() 2023-10-31 23:08:57 +00:00
link2xt 9b9108320e refactor: avoid loading peerstate if there is no Autocrypt-Gossip 2023-10-31 23:08:57 +00:00
link2xt 5efb100f12 fix: add secondary verified key 2023-10-31 23:08:57 +00:00
link2xt b747dd6ae8 refactor: remove unused argument from set_verified() 
It is always PeerstateVerifiedStatus::BidirectVerified
and is always passed as a constant.
 2023-10-31 23:08:57 +00:00
link2xt ed2bc9e44d fix: remove previous attempt to recover from verified key change 
This approach was introduced in the C core before Rust conversion:
<https://github.com/deltachat/deltachat-core/commit/ced88321eb3940b742fe0d049afd939e25c27fd6>
It does not have tests and does not practically help,
so we remove it in favor of alternative discussed in
<https://github.com/deltachat/deltachat-core-rust/issues/4541>
 2023-10-31 23:08:57 +00:00
link2xt 9e1a2149fa test: test recovery of verified group via gossip 2023-10-31 23:08:57 +00:00
link2xt 22b6d8c17b feat(deltachat-rpc-client): add Account.wait_for_incoming_msg_event() 2023-10-31 23:08:57 +00:00
link2xt 3876846410 refactor: sort member vector before deduplicating 
Otherwise SELF contact in the beginning of the vector
and in to_ids may be repeated twice and not deduplicated.
dedup() only deduplicates consecutive elements.
 2023-10-31 23:08:57 +00:00
link2xt a93c79e001 fix: allow other verified group recipients to be unverified 
We may not have a verified key for other members
because we lost a gossip message.
Still, if the message is signed with a verified key
of the sender, there is no reason to replace it with an error.
 2023-10-31 23:08:57 +00:00
link2xt 6aae0276da test: use instant accounts instead of mailadm 2023-10-30 00:15:22 +00:00
link2xt 1d80659bc3 chore: update portable-atomic dependency 
Version 1.5.0 is yanked.
 2023-10-29 23:36:26 +00:00
link2xt 94d5e86d4f refactor: rename repl_msg_by_error into replace_msg_by_error 
This function has been named like this since it was a C function.
`repl` is unclear because it may stand for `reply`
as well as `replace`.
 2023-10-29 17:09:59 +00:00
link2xt aecf7729d8 chore(release): prepare for 1.127.2 2023-10-29 16:29:04 +00:00
link2xt 81e1164358 test: compile deltachat-rpc-server in debug mode for tests 
This reduces compilation times.
 2023-10-29 01:09:35 +00:00
link2xt 771b57778e test: increase pytest timeout to 10 minutes 
deltachat-rpc-client tests often timeouts on CI,
this hopefully fixes the problem unless the tests actually deadlock.
 2023-10-28 00:54:36 +00:00
link2xt 9be56a5e56 test(deltachat-rpc-client): test securejoin 2023-10-27 20:07:32 +00:00
link2xt da744958c2 chore: move pytest option from pyproject.toml to tox.ini and set log level 
The option from pyproject.toml was not picked up
because tox.ini has higher precedence.
 2023-10-27 20:00:20 +00:00
link2xt f6bda1e480 docs: add missing 1.127.1 link to changelog 2023-10-27 19:34:49 +00:00
link2xt d2e24534c7 chore(release): prepare for 1.127.1 2023-10-27 19:27:40 +00:00
link2xt df6f974eca Add scripts for running deltachat-rpc-client tests 2023-10-27 17:24:39 +00:00
link2xt 2f5c6b5e16 test(jsonrpc): test get_provider_info 2023-10-27 03:07:47 +00:00
link2xt 97176b13f1 api(jsonrpc): add id to ProviderInfo 2023-10-27 03:07:18 +00:00
link2xt 18bb7e58be refactor: move api/mod.rs to api.rs 2023-10-27 02:33:17 +00:00
link2xt 53bb8a9831 chore: update to async-channel 2 2023-10-26 23:41:34 +00:00
link2xt 1b66120e7d chore(release): prepare for 1.127.0 2023-10-26 15:54:48 +00:00
link2xt 1478f321ae fix: restore try_many_times workaround 
Even though r2d2 connection pool is removed,
deleting accounts still fails in Windows CI.

This reverts commit e88f21c010.
`try_many_times` documentation is modified to explain
why the workaround is still needed.
 2023-10-26 15:15:44 +00:00
link2xt 5fb92c78ad ci: test deltachat-rpc-client on Windows 2023-10-26 15:15:44 +00:00
link2xt a0a792b821 chore: update sct, serde and serde_derive 2023-10-26 14:06:44 +00:00
link2xt 3feb0e648d build: switch to iroh 0.4.x fork with updated dependencies 2023-10-26 14:04:32 +00:00
link2xt fa5358a5bf chore: update tracing 2023-10-26 13:17:54 +00:00
link2xt 25a78aceb9 ci: increase MSRV to 1.70.0 
This is required by `anstyle v1.0.4` dependency.
 2023-10-26 02:16:10 +00:00
link2xt 66708454dd chore: update dependencies 2023-10-26 02:13:15 +00:00
link2xt bb5e3d11d8 chore: update futures-lite dependency 2023-10-26 01:11:11 +00:00
link2xt ff54db2e5f test: adapt the test for updated chrono 2023-10-26 00:47:32 +00:00
link2xt 434d8fc35f chore: update quick-xml 2023-10-25 22:42:14 +00:00
link2xt 12eb813bc3 ci(concourse): replace master branch with main 2023-10-25 22:02:35 +00:00
link2xt 88d5576150 ci(github): replace references to master branch with main 2023-10-25 22:02:32 +00:00
link2xt af35e4adeb chore: update dependencies 2023-10-25 21:58:13 +00:00
link2xt eaeacb8848 ci: run only on main branch pushes 2023-10-25 21:46:09 +00:00
link2xt f00e68e142 chore: update some dependencies 2023-10-25 21:45:22 +00:00
link2xt 113356a24e docs: fix CI badge URL in the readme 2023-10-25 19:31:22 +00:00
link2xt b89c134e7f Merge branch 'master' into stable 2023-10-25 16:50:18 +00:00
link2xt 3748794048 fix(sql): order migrations the same as on stable branch 2023-10-25 16:37:39 +00:00
link2xt fa81ed5f39 ci: rename async tests into JSON-RPC tests 2023-10-25 01:33:56 +00:00
link2xt 6c34f6b8d9 ci: remove misplaced comment 2023-10-25 01:33:56 +00:00
link2xt 8ad99be322 ci: increase MSRV to 1.67.0 2023-10-24 21:18:15 +00:00
link2xt 4e771e8727 Merge branch 'stable' 2023-10-24 17:49:23 +00:00
link2xt ac557f73b3 chore: remove unneeded idna rule for cargo-deny 2023-10-24 17:02:16 +00:00
link2xt 0ba3501a46 chore: update trust-dns-resolver to hickory-resolver 2023-10-24 17:00:14 +00:00
link2xt c1eb33c0da Merge tag 'v1.126.1' 
Release 1.126.1
 2023-10-24 14:50:49 +00:00
link2xt 03bb92c942 chore(release): prepare for 1.126.1 2023-10-24 14:30:02 +00:00