Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-10-02 03:00:40 +03:00
Code Issues Packages Projects Releases Wiki Activity
1,476 Commits 611 Branches 397 Tags
2a4c19360191ac91969eb03acf3526440fa214e3
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Alexander Krotov 69e14dcb2d Replace some magic numbers with constants 2019-11-16 16:08:08 +00:00
Alexander Krotov f778957caf Improve documentation and comments 2019-11-16 13:53:47 +01:00
Alexander Krotov 47f8da6532 Expand tabs into spaces 2019-11-16 12:32:32 +01:00
Alexander Krotov 0b3f2a55df Do not use wildcard match in msgtype_has_file 
This way there will be a compiler error notifying that the function needs to be updated when a new message type is added.
 2019-11-16 12:31:13 +01:00
Alexander Krotov c6369b1c5a Implement TryFrom instead of TryInto 
TryInto is derived automatically and its documentation recommends implementing TryFrom.
 2019-11-10 15:38:58 +00:00
Alexander Krotov bfa0f9d911 Use the first subkey for encryption instead of the primary key 2019-11-10 16:32:09 +01:00
Alexander Krotov cf023ea557 sql: remove unnecessary ? in prepare() and prepare2() 2019-11-06 13:26:03 +01:00
Alexander Krotov 51a804a80f location: use "bool" for "independent" argument 2019-11-06 14:17:59 +03:00
Alexander Krotov 0aa1d1caa0 Merge pull request #749 from deltachat/fix-get-chat-id 
let dc_get_chat_id_by_contact_id() returns 0 if no chat is found
 2019-10-27 12:42:22 +00:00
Alexander Krotov 7916a7fa07 Fix spelling of Param::GuaranteeE2ee 2019-10-27 11:51:59 +01:00
Alexander Krotov ee81895e1e Use DC_CONTACT_ID_SELF in do_initiate_key_transfer 2019-10-27 11:51:47 +01:00
Alexander Krotov 6ac4384769 location.rs cleanup 
Use constants where possible, move "let" closer to assignments.
 2019-10-27 11:51:35 +01:00
Alexander Krotov 99fababf0b to_base64: operate on characters instead of bytes to avoid unsafe code 2019-10-27 11:51:25 +01:00
Alexander Krotov c85f1b20ca Add constants for certificate checks configuration 2019-10-27 11:51:14 +01:00
Alexander Krotov cfa69cf35a Add Params::set_cmd and use SystemMessage constants 2019-10-26 14:04:08 +02:00
Alexander Krotov bed14d5c02 Initialize continue_streaming with false 
Otherwise this variable is constant.
 2019-10-22 13:24:23 +03:00
Alexander Krotov d3c831a0a2 Replace continue_streaming int with bool 2019-10-22 13:24:23 +03:00
Alexander Krotov 0007c12dea Replace FORCE_SCHEDULE #define from C core with bool 2019-10-22 13:24:23 +03:00
Alexander Krotov dfc453c1d1 Merge pull request #727 from deltachat/strndup 
Remove unused strndup
 2019-10-17 12:33:51 +03:00
Alexander Krotov 9fa6289093 Remove unused strndup 2019-10-17 03:18:08 +03:00
Alexander Krotov 9bf8bed0c3 Merge pull request #685 from deltachat/outlook_unit_test 
Unit test Outlook autodiscovery
 2019-10-14 21:34:43 +00:00
Alexander Krotov c4d55f6ba4 auto_outlook: convert <Protocol> type to lowercase before comparison 2019-10-14 19:21:29 +03:00
Alexander Krotov 8e0e1bd58d Add test for Outlook autodiscovery without redirect 2019-10-14 13:42:35 +03:00
Alexander Krotov a471ccc95a Test Outlook autoconfigure redirect parsing 2019-10-14 01:24:20 +03:00
Alexander Krotov daac8c4824 rustfmt 2019-10-14 01:24:20 +03:00
Alexander Krotov 59c22a5626 Move Outlook autodiscovery into separate function 2019-10-14 01:24:19 +03:00
Alexander Krotov 5154f27f72 Merge pull request #712 from deltachat/moz_autoconfigure_unit 
auto_mozilla: split XML parsing into separate function
 2019-10-13 16:34:05 +00:00
Alexander Krotov 5f7279eb85 auto_mozilla: server is only configured if the type matches 
This fixes the testcase introduced in previous commit
 2019-10-12 17:07:20 +03:00
Alexander Krotov ce67f593f6 Add XML parsing test for Mozilla autoconfig 2019-10-12 17:07:20 +03:00
Alexander Krotov 556ea57f37 auto_mozilla: split XML parsing into separate function 2019-10-12 17:07:20 +03:00
Alexander Krotov 8479c8afbf Do not convert 1 to libc::c_int 
It is compared to u32 in this case
 2019-10-11 21:52:47 +02:00
Alexander Krotov eba012b965 Do not use libc::c_int in Simplify 2019-10-11 21:52:47 +02:00
Alexander Krotov 66e53e6804 Return bool from Imap::fetch() 
It is unused anyway
 2019-10-11 21:52:47 +02:00
Alexander Krotov c8aa8b55f6 Use i32 instead of libc::c_int for try_again 
It is already declared as i32 in the structure
 2019-10-11 21:52:47 +02:00
Alexander Krotov 900e3905c0 Count number of libc references in top_evil_rs.py 2019-10-11 21:52:47 +02:00
Alexander Krotov e4cca92910 Simplify to_string_lossy() 
Call .to_string_lossy() without trying .to_str() first.
 2019-10-09 08:56:02 +02:00
Alexander Krotov c23e98ff83 Merge pull request #693 from deltachat/mozautoconfig 
Use Rust types in auto_mozilla.rs
 2019-10-07 23:03:17 +00:00
Alexander Krotov 5c3a7e4119 Use Rust types in auto_mozilla.rs 2019-10-07 18:43:53 +03:00
Alexander Krotov b4851187ba Safe outlk_autodiscover 2019-10-06 05:46:45 +03:00
Alexander Krotov 0252969f7e Remove unused in_0 from outlk_autodiscover_t 2019-10-06 05:16:17 +03:00
Alexander Krotov f86cec4844 Mark moz_autoconfigure as safe 2019-10-06 05:16:17 +03:00
Alexander Krotov cd2e36da92 rustfmt 2019-10-06 05:16:17 +03:00
Alexander Krotov 1b13107181 Return Option<String> from read_autoconf_file 2019-10-06 05:16:17 +03:00
Alexander Krotov 6fbde21995 outlk_autodiscover: store url as String 2019-10-06 05:16:17 +03:00
Alexander Krotov a6608513ac auto_outlook: restore and add some comments 2019-10-06 05:16:17 +03:00
Alexander Krotov d43c225be3 Return None from outlk_autodiscover if no XML config was parsed 2019-10-06 05:16:17 +03:00
Alexander Krotov 130d485cac Fix some clippy warnings 2019-10-03 14:30:40 +02:00
Alexander Krotov a5c4e16405 Merge pull request #647 from deltachat/tls_checks_config 
Add certificate check configuration options
 2019-10-02 23:21:03 +00:00
Alexander Krotov 216266d7bf Apply imap_certificate_checks config to StartTLS connections 2019-10-03 02:02:51 +03:00
Alexander Krotov bf1652a1be Move common code for IMAP and SMTP to login_param.rs 2019-10-03 01:26:38 +03:00
Alexander Krotov f93f3d6012 Do not set minimal TLS version for SMTP manually 2019-10-03 01:26:07 +03:00
Alexander Krotov 41806f86ba Return certificate check information from get_info() 2019-10-03 01:26:07 +03:00
Alexander Krotov 59df97944f Enable strict certificate checks for test online accounts 2019-10-03 01:26:07 +03:00
Alexander Krotov 468651534e Manually specify values for CertificateChecks enum 
This is what we are doing in constants.rs
 2019-10-03 01:26:07 +03:00
Alexander Krotov 6343ae8161 Rename {mail,send}_certificate_checks into {imap,smtp}_certificate_checks 2019-10-03 01:26:07 +03:00
Alexander Krotov 641bd5eb15 Write configured_{mail,send}_certificate_checks to database 2019-10-03 01:26:07 +03:00
Alexander Krotov 063d989225 Use mail_certificate_checks configuration in imap.rs 2019-10-03 01:26:07 +03:00
Alexander Krotov b8ca7b1591 Add CertificateChecks::Automatic option and make it default 
It is the same as AcceptInvalidCertificates for now,
but can be replaced with better heuristics later,
such as a database of known providers or TOFU.
 2019-10-03 01:25:19 +03:00
Alexander Krotov e222f49c9d Use send_certificate_checks configuration 2019-10-03 01:25:19 +03:00
Alexander Krotov 297bc635e8 Add certificate check configuration options 2019-10-03 01:25:19 +03:00
Alexander Krotov f7ad93229d test_account.py: fix a typo in test message 2019-10-02 13:10:16 +02:00
Alexander Krotov 555b4bc8c7 python/README.rst: s/mail_pwd/mail_pw/ 
mail_pw is the option that is actually read by the tests
 2019-10-02 13:09:45 +02:00
Alexander Krotov a6d0464735 Merge pull request #643 from deltachat/top_evil_rs-skip-safe 
top_evil_rs.py: do not list safe files
 2019-09-29 19:07:56 +00:00
Alexander Krotov 52f69cc7dc top_evil_rs.py: do not list safe files 2019-09-29 18:51:48 +03:00
Alexander Krotov bb57c6e7b7 Merge pull request #627 from deltachat/dc_receive_imf-slice 
Pass slice to dc_receive_imf
 2019-09-27 16:27:14 +00:00
Alexander Krotov f346a052c1 Return Result from dc_initiate_key_transfer 2019-09-27 17:57:45 +02:00
Alexander Krotov 3933353b5f Pass slice to dc_receive_imf 
instead of pointer and length
 2019-09-27 17:53:41 +03:00
Alexander Krotov cb499ae502 Return Result<String> from dc_decrypt_setup_file 2019-09-26 18:05:29 +02:00
Alexander Krotov b93550f6c8 Use DC_MSG_ID_LAST_SPECIAL in dc_continue_key_transfer 2019-09-25 03:29:37 +02:00
Alexander Krotov 60bd053095 Pass setup_code to dc_continue_key_transfer as &str 2019-09-25 03:29:37 +02:00
Alexander Krotov 8165b76001 Make dc_normalize_setup_code safe 2019-09-25 03:29:37 +02:00
Alexander Krotov ac12b2e643 chore(key): remove unused *fingerprint_c functions 2019-09-15 19:32:16 +02:00
Alexander Krotov 24fe4740d3 Merge pull request #498 from deltachat/return_bool 
Resolve "should return bool" TODOs
 2019-09-14 14:31:50 +00:00
Alexander Krotov 1e1d3f4aa8 Merge pull request #521 from deltachat/server_flags 
Restore DC_LP_* constants from C code
 2019-09-14 14:19:02 +00:00
Alexander Krotov 51bf875826 Use DC_LP_* constants in configure module 2019-09-14 13:22:59 +03:00
Alexander Krotov f9ce6c7c81 Use DC_LP_* constants in auto_outlook.rs 2019-09-14 13:16:21 +03:00
Alexander Krotov 2e91c3d334 Use DC_LP_* constants in auto_mozilla.rs 2019-09-14 13:14:35 +03:00
Alexander Krotov d1b762af04 Make DC_LP_* constants public 2019-09-14 13:14:18 +03:00
Alexander Krotov e1e02839d1 Return bool from dc_mimefactory_render 2019-09-14 12:06:33 +03:00
Alexander Krotov 50a812ea5e Return bool from mailmime_transfer_decode 2019-09-14 12:03:10 +03:00
Alexander Krotov 27a4adb9c6 Return bool from export_key_to_asc_file 2019-09-14 12:03:10 +03:00
Alexander Krotov 3932d8f48f Return bool from export_self_keys 2019-09-14 12:03:10 +03:00
Alexander Krotov d978a8e0a2 Return bool from {import,export}_backup 2019-09-14 12:03:10 +03:00
Alexander Krotov fad49e08d7 message.rs: resolve "should return bool" TODOs 2019-09-14 12:03:10 +03:00
Alexander Krotov 0f67b16f29 Return bool from add_contact_to_chat_ex 2019-09-14 12:03:10 +03:00
Alexander Krotov 97edd23910 Return bool from add_to_chat_contacts_table 2019-09-14 12:03:10 +03:00
Alexander Krotov 400ab2cdab Return bool from dc_msg_get_showpadlock 2019-09-14 12:03:10 +03:00
Alexander Krotov fa8192177d Merge pull request #514 from deltachat/in_reply_to 
Store In-Reply-To header as Option<String>
 2019-09-13 10:21:32 +00:00
Alexander Krotov 48ffef7955 Store In-Reply-To header as Option<String> 2019-09-13 11:43:48 +03:00
Alexander Krotov 055796e6b3 Merge pull request #496 from KAction/safe 
Make dc_msg_get_file return PathBuf, not char*
 2019-09-13 00:43:28 +00:00
Alexander Krotov 6d1076e1f6 Mark dc_imex() as safe 2019-09-12 23:43:25 +02:00
Alexander Krotov 68b5e34fed Merge pull request #488 from KAction/transfer 
Reduce indentation in dc_continue_key_transfer
 2019-09-11 05:36:02 +00:00
Alexander Krotov 995548002b Merge pull request #484 from link2xt/safe_test_encryption_decryption 
Safe test encryption decryption
 2019-09-11 00:43:21 +00:00
Alexander Krotov 38ad16887b Merge pull request #487 from KAction/top_evil 
Minor refactoring
 2019-09-11 00:42:48 +00:00
Alexander Krotov 706a97b013 Move part of test_encryption_decryption to key.rs 2019-09-11 00:40:46 +03:00
Alexander Krotov f1c026c5ec Pass passphrase to dc_pgp_symm_{en,de}crypt as &str 2019-09-10 15:58:42 +02:00
Alexander Krotov 22c1ee1f55 cargo fmt 2019-09-10 16:29:41 +03:00
Alexander Krotov 971960a242 key.rs: remove unsafe Key.from_binary 2019-09-10 16:29:24 +03:00
Alexander Krotov 69f8973339 test_encryption_decryption: use safe from_slice instead of from_binary 2019-09-10 16:29:24 +03:00
Alexander Krotov 6a2368f83c Return bool from dc_continue_key_transfer 2019-09-10 15:15:48 +02:00