use node 16 in ci

use `npm i` instead of `npm ci`
try fix ci script
and fix a doc comment
This commit is contained in:
Simon Laux
2022-05-07 03:49:58 +02:00
parent bb6d7767b5
commit 65b242aa5c
3 changed files with 12 additions and 10 deletions

View File

@@ -31,10 +31,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 14.x
- name: Use Node.js 16.x
uses: actions/setup-node@v1
with:
node-version: 14.x
node-version: 16.x
- uses: actions-rs/toolchain@v1
with:
profile: minimal
@@ -42,18 +42,18 @@ jobs:
override: true
- name: Rust Cache
uses: Swatinem/rust-cache@v1.3.0
- name: npm ci
- name: npm i
run: |
cd deltachat-jsonrpc/typescript
npm ci
- name: npm run generate_bindings
npm i
- name: npm run generate-bindings
run: |
cd deltachat-jsonrpc/typescript
npm run generate_bindings
- name: npm run check_ts
npm run generate-bindings
- name: npm run check ts
run: |
cd deltachat-jsonrpc/typescript
npm run check_ts
npx tsc --noEmit
- name: run integration tests
run: |
cd deltachat-jsonrpc/typescript

View File

@@ -57,7 +57,7 @@ impl CommandApi {
// Misc top level functions
// ---------------------------------------------
// Check if an email address is valid.
/// Check if an email address is valid.
async fn check_email_validity(&self, email: String) -> bool {
may_be_valid_addr(&email)
}

View File

@@ -14,7 +14,9 @@ interface Transport {
export class RawClient {
constructor(private _transport: Transport) {}
/**
* Check if an email address is valid.
*/
public checkEmailValidity(email: string): Promise<boolean> {
return (this._transport.request('check_email_validity', [email] as RPC.Params)) as Promise<boolean>;
}