Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-05-06 06:46:35 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove outdated TODO

Browse Source 
For `vb-member-added`:
- On Bob's second device, observe_securejoin_on_other_device() isn't
  even called, because the message is incoming, not outgoing
- On Alice's second device, Bob is added as a result of the
  `vb-request-with-auth` message, so, it's not necessary to add Bob as a
  result of the outgoing `vb-member-added` message
This commit is contained in:
Hocuri
2025-09-09 19:57:05 +02:00
parent fc52c8de05
commit 557702ea74
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/securejoin.rs
View File

@@ -586,8 +586,6 @@ pub(crate) async fn observe_securejoin_on_other_device(
// because all devices receive the `vb-request-with-auth` message // because all devices receive the `vb-request-with-auth` message
// and mark Bob as verified because of this. // and mark Bob as verified because of this.
return Ok(HandshakeMessage::Ignore); return Ok(HandshakeMessage::Ignore);
// TODO for `vb-member-added`, we probably need to return HandshakeMessage::Propagate,
// because otherwise, Bob's second device won't receive the message correctly
}; };
if !encrypted_and_signed(context, mime_message, &get_self_fingerprint(context).await?) { if !encrypted_and_signed(context, mime_message, &get_self_fingerprint(context).await?) {