From 557702ea74317a65cd9b4e165930f319f46e6c16 Mon Sep 17 00:00:00 2001 From: Hocuri Date: Tue, 9 Sep 2025 19:57:05 +0200 Subject: [PATCH] Remove outdated TODO For `vb-member-added`: - On Bob's second device, observe_securejoin_on_other_device() isn't even called, because the message is incoming, not outgoing - On Alice's second device, Bob is added as a result of the `vb-request-with-auth` message, so, it's not necessary to add Bob as a result of the outgoing `vb-member-added` message --- src/securejoin.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/securejoin.rs b/src/securejoin.rs index 7030e6dce..152abe51c 100644 --- a/src/securejoin.rs +++ b/src/securejoin.rs @@ -586,8 +586,6 @@ pub(crate) async fn observe_securejoin_on_other_device( // because all devices receive the `vb-request-with-auth` message // and mark Bob as verified because of this. return Ok(HandshakeMessage::Ignore); - // TODO for `vb-member-added`, we probably need to return HandshakeMessage::Propagate, - // because otherwise, Bob's second device won't receive the message correctly }; if !encrypted_and_signed(context, mime_message, &get_self_fingerprint(context).await?) {