Improve TODOs

This commit is contained in:
Hocuri
2025-08-06 15:04:14 +02:00
parent 72336ebb8a
commit 410048a9e1
2 changed files with 6 additions and 2 deletions

View File

@@ -3507,8 +3507,10 @@ async fn apply_out_broadcast_changes(
} else if let Some(added_addr) = mime_parser.get_header(HeaderDef::ChatGroupMemberAdded) {
// TODO this may lookup the wrong contact if multiple contacts have the same email addr.
// We can send sync messages instead,
// lookup the fingerprint by gossip header (like it's done for groups right now)
// or add a header ChatGroupMemberAddedFpr.
// lookup the fingerprint by gossip header (like it's done for groups right now),
// add a header ChatGroupMemberAddedFpr,
// or only handle addition on receival of Bob's request message and solve the problem in a different way for member-removed.
// --> link2xt said to probably handle addition on receival of Bob's request message, and to add a header ChatGroupMemberRemovedFpr.
let contact = lookup_key_contact_by_address(context, added_addr, None).await?;
if let Some(contact) = contact {
better_msg.get_or_insert(

View File

@@ -292,6 +292,8 @@ pub(crate) async fn handle_securejoin_handshake(
// TODO talk with link2xt about whether we need to protect against this identity-misbinding attack,
// and if so, how
// -> just put Alice's fingerprint into a header (can't put the gossip header bc we don't have this)
// -> or just ignore the problem for now - we will need to solve it for all messages anyways: https://github.com/chatmail/core/issues/7057
if !matches!(
step,
"vg-request" | "vc-request" | "vb-request-with-auth" | "vb-member-added"