bubble up signing error instead of panicing (#3304)

.expect() may panic, which is probably not what we want here.
it seems better to bubble up the error (as we are doing in the other cases)

(i was checking some .expect usages after we had a similar issue at #3264)
This commit is contained in:
bjoern
2022-05-08 20:17:50 +02:00
committed by GitHub
parent 8988c775fe
commit 01ef053a11

View File

@@ -190,7 +190,9 @@ pub(crate) fn create_keypair(
let key = key_params
.generate()
.map_err(|err| PgpKeygenError::new("invalid params", err))?;
let private_key = key.sign(|| "".into()).expect("failed to sign secret key");
let private_key = key
.sign(|| "".into())
.map_err(|err| PgpKeygenError::new("failed to sign secret key", err))?;
let public_key = private_key.public_key();
let public_key = public_key