From 01ef053a118ae60b3b3ad7f929041ab32913d565 Mon Sep 17 00:00:00 2001 From: bjoern Date: Sun, 8 May 2022 20:17:50 +0200 Subject: [PATCH] bubble up signing error instead of panicing (#3304) .expect() may panic, which is probably not what we want here. it seems better to bubble up the error (as we are doing in the other cases) (i was checking some .expect usages after we had a similar issue at #3264) --- src/pgp.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/pgp.rs b/src/pgp.rs index e9236fcde..373994e47 100644 --- a/src/pgp.rs +++ b/src/pgp.rs @@ -190,7 +190,9 @@ pub(crate) fn create_keypair( let key = key_params .generate() .map_err(|err| PgpKeygenError::new("invalid params", err))?; - let private_key = key.sign(|| "".into()).expect("failed to sign secret key"); + let private_key = key + .sign(|| "".into()) + .map_err(|err| PgpKeygenError::new("failed to sign secret key", err))?; let public_key = private_key.public_key(); let public_key = public_key