add tests for the Ruby backend

main-server/spec/models/user_spec.rb

@@ -0,0 +1,66 @@
+require "rails_helper"
+
+RSpec.describe User, type: :model do
+  let(:valid_attributes) { { nickname: "player_one", password: "secret123" } }
+
+  describe "validations" do
+    it "is valid with a nickname and password" do
+      expect(User.new(valid_attributes)).to be_valid
+    end
+
+    it "requires a nickname" do
+      user = User.new(valid_attributes.merge(nickname: nil))
+      expect(user).not_to be_valid
+      expect(user.errors[:nickname]).to be_present
+    end
+
+    it "requires a password" do
+      user = User.new(nickname: "player_one", password: nil)
+      expect(user).not_to be_valid
+      expect(user.errors[:password]).to be_present
+    end
+
+    it "rejects nicknames shorter than 3 characters" do
+      expect(User.new(valid_attributes.merge(nickname: "ab"))).not_to be_valid
+    end
+
+    it "rejects nicknames longer than 24 characters" do
+      expect(User.new(valid_attributes.merge(nickname: "a" * 25))).not_to be_valid
+    end
+
+    it "rejects passwords shorter than 6 characters" do
+      expect(User.new(valid_attributes.merge(password: "12345"))).not_to be_valid
+    end
+
+    it "requires nicknames to be unique case-insensitively" do
+      User.create!(valid_attributes)
+      duplicate = User.new(valid_attributes.merge(nickname: "PLAYER_ONE"))
+      expect(duplicate).not_to be_valid
+      expect(duplicate.errors[:nickname]).to be_present
+    end
+  end
+
+  describe "nickname normalization" do
+    it "strips surrounding whitespace" do
+      user = User.create!(valid_attributes.merge(nickname: "  player_one  "))
+      expect(user.nickname).to eq("player_one")
+    end
+  end
+
+  describe "password authentication" do
+    it "authenticates with the correct password" do
+      user = User.create!(valid_attributes)
+      expect(user.authenticate("secret123")).to eq(user)
+    end
+
+    it "rejects a wrong password" do
+      user = User.create!(valid_attributes)
+      expect(user.authenticate("wrong")).to be_falsey
+    end
+
+    it "does not require a password when updating other attributes" do
+      user = User.create!(valid_attributes)
+      expect(user.update(nickname: "new_nickname")).to be true
+    end
+  end
+end

main-server/spec/rails_helper.rb

@@ -0,0 +1,78 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+if ENV["COVERAGE"]
+  require "simplecov"
+  SimpleCov.start "rails" do
+    add_filter "/spec/"
+  end
+end
+require 'spec_helper'
+ENV['RAILS_ENV'] ||= 'test'
+require_relative '../config/environment'
+# Prevent database truncation if the environment is production
+abort("The Rails environment is running in production mode!") if Rails.env.production?
+# Uncomment the line below in case you have `--require rails_helper` in the `.rspec` file
+# that will avoid rails generators crashing because migrations haven't been run yet
+# return unless Rails.env.test?
+require 'rspec/rails'
+# Add additional requires below this line. Rails is not loaded until this point!
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+#
+# The following line is provided for convenience purposes. It has the downside
+# of increasing the boot-up time by auto-requiring all files in the support
+# directory. Alternatively, in the individual `*_spec.rb` files, manually
+# require only the support files necessary.
+#
+# Rails.root.glob('spec/support/**/*.rb').sort_by(&:to_s).each { |f| require f }
+
+# Ensures that the test database schema matches the current schema file.
+# If there are pending migrations it will invoke `db:test:prepare` to
+# recreate the test database by loading the schema.
+# If you are not using ActiveRecord, you can remove these lines.
+begin
+  ActiveRecord::Migration.maintain_test_schema!
+rescue ActiveRecord::PendingMigrationError => e
+  abort e.to_s.strip
+end
+RSpec.configure do |config|
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_paths = [
+    Rails.root.join('spec/fixtures')
+  ]
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # You can uncomment this line to turn off ActiveRecord support entirely.
+  # config.use_active_record = false
+
+  # RSpec Rails uses metadata to mix in different behaviours to your tests,
+  # for example enabling you to call `get` and `post` in request specs. e.g.:
+  #
+  #     RSpec.describe UsersController, type: :request do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://rspec.info/features/8-0/rspec-rails
+  #
+  # You can also infer these behaviours automatically by location, e.g.
+  # /spec/models would pull in the same behaviour as `type: :model` but this
+  # behaviour is considered legacy and will be removed in a future version.
+  #
+  # To enable this behaviour uncomment the line below.
+  # config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+end

main-server/spec/services/jwt_service_spec.rb

@@ -0,0 +1,50 @@
+require "rails_helper"
+
+RSpec.describe JwtService do
+  describe ".encode" do
+    it "returns a JWT string" do
+      token = described_class.encode(user_id: 1)
+      expect(token).to be_a(String)
+      expect(token.split(".").size).to eq(3)
+    end
+
+    it "sets a default expiration about 7 days in the future" do
+      token = described_class.encode(user_id: 1)
+      payload = JWT.decode(token, described_class::SECRET_KEY, true, algorithm: described_class::ALGORITHM).first
+      expect(payload["exp"]).to be_within(60).of(7.days.from_now.to_i)
+    end
+
+    it "keeps a custom expiration if provided" do
+      custom_exp = 1.hour.from_now.to_i
+      token = described_class.encode(user_id: 1, exp: custom_exp)
+      payload = JWT.decode(token, described_class::SECRET_KEY, true, algorithm: described_class::ALGORITHM).first
+      expect(payload["exp"]).to eq(custom_exp)
+    end
+  end
+
+  describe ".decode" do
+    it "round-trips the user_id" do
+      token = described_class.encode(user_id: 42)
+      expect(described_class.decode(token)[:user_id]).to eq(42)
+    end
+
+    it "returns nil for a tampered token" do
+      token = described_class.encode(user_id: 42)
+      expect(described_class.decode(token + "x")).to be_nil
+    end
+
+    it "returns nil for a token signed with a different secret" do
+      token = JWT.encode({ user_id: 42 }, "wrong-secret", "HS256")
+      expect(described_class.decode(token)).to be_nil
+    end
+
+    it "returns nil for an expired token" do
+      token = described_class.encode(user_id: 42, exp: 1.minute.ago.to_i)
+      expect(described_class.decode(token)).to be_nil
+    end
+
+    it "returns nil for garbage input" do
+      expect(described_class.decode("not-a-token")).to be_nil
+    end
+  end
+end

main-server/spec/spec_helper.rb

@@ -0,0 +1,94 @@
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+=begin
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = "spec/examples.txt"
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/
+  config.disable_monkey_patching!
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = "doc"
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+=end
+end