mirror of
https://github.com/espressif/esp-idf.git
synced 2026-05-28 16:46:31 +03:00
fix: properly resolve component dependencies
There is currently a bug in the __build_resolve_and_add_req function in tools/cmake/build.cmake where the check for registered component requirements is incorrectly applied to the component itself rather than its dependencies. This issue likely originated from a typo, using component_target instead of _component_target. To prevent further confusion, _component_target has been renamed to _req_target. Fixing this revealed multiple incorrect dependencies for the Linux target, which have now been resolved by explicitly specifying the dependencies for the Linux target. Closes https://github.com/espressif/esp-idf/issues/13447 Signed-off-by: Frantisek Hrbata <frantisek.hrbata@espressif.com>
This commit is contained in:
@@ -7,8 +7,10 @@ set(srcs "commands.c"
|
||||
|
||||
if(${target} STREQUAL "linux")
|
||||
list(APPEND srcs "esp_console_repl_linux.c")
|
||||
set(requires "")
|
||||
else()
|
||||
list(APPEND srcs "esp_console_repl_chip.c")
|
||||
set(requires vfs esp_vfs_console)
|
||||
endif()
|
||||
|
||||
set(argtable_srcs argtable3/arg_cmd.c
|
||||
@@ -31,7 +33,7 @@ idf_component_register(SRCS ${srcs}
|
||||
${argtable_srcs}
|
||||
INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}
|
||||
PRIV_INCLUDE_DIRS private_include
|
||||
REQUIRES vfs esp_vfs_console
|
||||
REQUIRES "${requires}"
|
||||
PRIV_REQUIRES esp_driver_uart
|
||||
esp_driver_usb_serial_jtag
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user