From 0dfb4ac777d61760f9b952ef899aade7502b71a9 Mon Sep 17 00:00:00 2001 From: "sonika.rathi" Date: Tue, 4 Aug 2026 14:18:56 +0200 Subject: [PATCH] fix(nvs_flash): check readEntry return in debugDump --- components/nvs_flash/src/nvs_page.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/components/nvs_flash/src/nvs_page.cpp b/components/nvs_flash/src/nvs_page.cpp index 55aa8b66cc4..6797e5a792b 100644 --- a/components/nvs_flash/src/nvs_page.cpp +++ b/components/nvs_flash/src/nvs_page.cpp @@ -1255,7 +1255,11 @@ void Page::debugDump() const printf("X\n"); } else if (state == EntryState::WRITTEN) { Item item; - readEntry(i, item); + // Check readEntry: Item() leaves fields uninitialized; printing key/%s on failure is UB. + if (readEntry(i, item) != ESP_OK) { + printf("Failed to read entry\n"); + return; + } if (skip == 0) { printf("W ns=%2" PRIu8 " type=%2" PRIu8 " span=%3" PRIu8 " key=\"%s\" chunkIdx=%" PRIu8 " len=%" PRIi32 "\n", item.nsIndex, static_cast(item.datatype), item.span, item.key, item.chunkIndex, (item.span != 1) ? (static_cast(item.varLength.dataSize)) : (-1));