fix(usb): address usb wakeup review comments

This commit is contained in:
Jiang Guang Ming
2026-06-10 15:14:37 +08:00
parent 348c4a4f19
commit d65b467108
6 changed files with 44 additions and 18 deletions
@@ -1,11 +1,12 @@
/*
* SPDX-FileCopyrightText: 2015-2025 Espressif Systems (Shanghai) CO LTD
* SPDX-FileCopyrightText: 2015-2026 Espressif Systems (Shanghai) CO LTD
*
* SPDX-License-Identifier: Apache-2.0
*/
#pragma once
#include <stdbool.h>
#include <stdint.h>
#include "esp_err.h"
#include "soc/soc_caps.h"
@@ -164,6 +165,18 @@ esp_err_t usb_new_phy(const usb_phy_config_t *config, usb_phy_handle_t *handle_r
*/
esp_err_t usb_phy_otg_set_mode(usb_phy_handle_t handle, usb_otg_mode_t mode);
/**
* @brief Set the USB OTG suspend state for USB wakeup logic
*
* @param in_suspend True if the USB OTG bus is suspended
*/
void usb_phy_set_otg_suspend_state(bool in_suspend);
/**
* @brief Clear USB OTG wakeup status from the USB wakeup logic
*/
void usb_phy_clear_otg_wakeup_status(void);
/**
* @brief Delete a USB PHY
*
@@ -137,7 +137,7 @@ typedef enum {
ESP_SLEEP_WAKEUP_BT, //!< Wakeup caused by BT (light sleep only)
ESP_SLEEP_WAKEUP_VAD, //!< Wakeup caused by VAD
ESP_SLEEP_WAKEUP_VBAT_UNDER_VOLT, //!< Wakeup caused by VDD_BAT under voltage.
ESP_SLEEP_WAKEUP_USB, //!< Wakeup caused by USB (light sleep only)
ESP_SLEEP_WAKEUP_USB, //!< Wakeup caused by USB HS (light sleep only)
} esp_sleep_source_t;
/**
@@ -150,7 +150,6 @@ typedef enum {
/* Leave this type define for compatibility */
typedef esp_sleep_source_t esp_sleep_wakeup_cause_t;
enum {
ESP_ERR_SLEEP_REJECT = ESP_ERR_INVALID_STATE,
ESP_ERR_SLEEP_TOO_SHORT_SLEEP_DURATION = ESP_ERR_INVALID_ARG,
@@ -567,7 +566,7 @@ esp_err_t esp_sleep_enable_bt_wakeup(void);
esp_err_t esp_sleep_disable_bt_wakeup(void);
/**
* @brief Enable wakeup by USB
* @brief Enable wakeup by High-Speed USB-OTG
* @return
* - ESP_OK on success
* - ESP_ERR_NOT_SUPPORTED if wakeup from USB is not supported
@@ -575,7 +574,7 @@ esp_err_t esp_sleep_disable_bt_wakeup(void);
esp_err_t esp_sleep_enable_usb_wakeup(void);
/**
* @brief Disable wakeup by USB
* @brief Disable wakeup by High-Speed USB-OTG
* @return
* - ESP_OK on success
* - ESP_ERR_NOT_SUPPORTED if wakeup from USB is not supported
@@ -180,6 +180,22 @@ esp_err_t usb_phy_otg_set_mode(usb_phy_handle_t handle, usb_otg_mode_t mode)
return ESP_OK;
}
void usb_phy_set_otg_suspend_state(bool in_suspend)
{
#if SOC_USB_UTMI_PHY_NUM
usb_utmi_hal_set_suspend_state(in_suspend);
#else
(void)in_suspend;
#endif
}
void usb_phy_clear_otg_wakeup_status(void)
{
#if SOC_USB_UTMI_PHY_NUM
usb_utmi_hal_clear_wakeup_status();
#endif
}
static esp_err_t usb_phy_install(void)
{
PHY_ENTER_CRITICAL();