From cd5cbe3c61cabb610fbd198772184fd2ab9b2aba Mon Sep 17 00:00:00 2001 From: Sarvesh Bodakhe Date: Mon, 19 Jan 2026 16:25:39 +0530 Subject: [PATCH] fix(nan): zero-init pub_id and sub_id in NAN service functions Both variables were uninitialized, returning a garbage value on the error (goto fail) path. --- components/esp_wifi/wifi_apps/nan_app/src/nan_app.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/esp_wifi/wifi_apps/nan_app/src/nan_app.c b/components/esp_wifi/wifi_apps/nan_app/src/nan_app.c index a524a0059dc..b4d611c03e7 100644 --- a/components/esp_wifi/wifi_apps/nan_app/src/nan_app.c +++ b/components/esp_wifi/wifi_apps/nan_app/src/nan_app.c @@ -885,7 +885,7 @@ esp_err_t esp_wifi_nan_stop(void) uint8_t esp_wifi_nan_publish_service(const wifi_nan_publish_cfg_t *publish_cfg, bool ndp_resp_needed) { - uint8_t pub_id; + uint8_t pub_id = 0; NAN_DATA_LOCK(); if (!(s_nan_ctx.state & NAN_STARTED_BIT)) { @@ -933,7 +933,7 @@ fail: uint8_t esp_wifi_nan_subscribe_service(const wifi_nan_subscribe_cfg_t *subscribe_cfg) { - uint8_t sub_id; + uint8_t sub_id = 0; NAN_DATA_LOCK(); if (!(s_nan_ctx.state & NAN_STARTED_BIT)) {