Mirrors/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-06-04 20:26:38 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(esp_http_client): implement chunked transfer encoding in before tranport write

Browse Source 
Closes https://github.com/espressif/esp-idf/issues/17685
This commit is contained in:
nilesh.kale
2025-12-18 11:14:18 +05:30
parent 80116d4e07
commit c3a413a8a5
6 changed files with 288 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
components/esp_http_client/esp_http_client.c
View File

@@ -1886,8 +1886,8 @@ esp_err_t esp_http_client_open(esp_http_client_handle_t client, int write_len)
int esp_http_client_write(esp_http_client_handle_t client, const char *buffer, int len)
{
if (client->state < HTTP_STATE_REQ_COMPLETE_HEADER) {
return ESP_FAIL;
if (client == NULL || len < 0 || client->state < HTTP_STATE_REQ_COMPLETE_HEADER || (buffer == NULL && len > 0)) {
return -1;
}
int wlen = 0, widx = 0;
@@ -1904,6 +1904,46 @@ int esp_http_client_write(esp_http_client_handle_t client, const char *buffer, i
return widx;
}
int esp_http_client_chunk_write_begin(esp_http_client_handle_t client, const int len)
{
if (client == NULL || client->state < HTTP_STATE_REQ_COMPLETE_HEADER || len <= 0) {
return -1;
}
char header_buffer[16];
int header_len = snprintf(header_buffer, sizeof(header_buffer), "%x\r\n", len);
int wlen = esp_transport_write(client->transport, header_buffer, header_len, client->timeout_ms);
if (wlen < 0 || wlen != header_len) {
return -1;
}
return 0;
}
int esp_http_client_chunk_write_end(esp_http_client_handle_t client, bool last_chunk)
{
if (client == NULL || client->state < HTTP_STATE_REQ_COMPLETE_HEADER) {
return -1;
}
/* Send chunk trailer: \r\n */
int wlen = esp_transport_write(client->transport, "\r\n", 2, client->timeout_ms);
if (wlen < 0 || wlen != 2) {
return -1;
}
if (last_chunk) {
/* Send final terminator: 0\r\n\r\n */
const char *terminator = "0\r\n\r\n";
wlen = esp_transport_write(client->transport, terminator, strlen(terminator), client->timeout_ms);
if (wlen < 0 || wlen != strlen(terminator)) {
return -1;
}
}
return 0;
}
esp_err_t esp_http_client_close(esp_http_client_handle_t client)
{
if (client->state > HTTP_STATE_INIT) {

52
components/esp_http_client/include/esp_http_client.h
View File

@@ -651,6 +651,10 @@ esp_err_t esp_http_client_delete_all_headers(esp_http_client_handle_t client);
*
* @param[in] client The esp_http_client handle
* @param[in] write_len HTTP Content length need to write to the server
* - If write_len >= 0: Sets Content-Length header with the specified value; use esp_http_client_write() for the body.
* - If write_len = -1: Enables chunked transfer encoding (Transfer-Encoding: chunked); use
* esp_http_client_chunk_write_begin() / esp_http_client_write() / esp_http_client_chunk_write_end() for each chunk.
* Pass last_chunk=true in esp_http_client_chunk_write_end() for the final chunk to send the terminator.
*
* @return
* - ESP_OK
@@ -662,16 +666,56 @@ esp_err_t esp_http_client_open(esp_http_client_handle_t client, int write_len);
/**
* @brief This function will write data to the HTTP connection previously opened by esp_http_client_open()
*
* @param[in] client The esp_http_client handle
* @param buffer The buffer
* @param[in] len This value must not be larger than the write_len parameter provided to esp_http_client_open()
* @param[in] client The esp_http_client handle (must not be NULL)
* @param buffer The buffer (may be NULL only if len is 0)
* @param[in] len Length of data to write. Value must not be larger than write_len passed to esp_http_client_open()
*
* @return
* - (-1) if any errors
* - Length of data written
* - Length of data written on success
*
* @note When esp_http_client_open() was called with write_len = -1 (chunked encoding), wrap each chunk with
* esp_http_client_chunk_write_begin() and esp_http_client_chunk_write_end(). Pass last_chunk=true in
* esp_http_client_chunk_write_end() for the final chunk.
*/
int esp_http_client_write(esp_http_client_handle_t client, const char *buffer, int len);
/**
* @brief Begin writing a chunk in chunked transfer encoding mode.
*
* Sends the chunk header (<hex-size>\\r\\n) per RFC 7230. After this call, use esp_http_client_write()
* to send the chunk body data, then call esp_http_client_chunk_write_end() to finish the chunk.
* For normal (non-chunked) write operations this API is not used.
*
* @pre Transfer-Encoding: chunked header must be set and esp_http_client_open() called with write_len = -1.
*
* @param[in] client The esp_http_client handle (must not be NULL)
* @param[in] len Length of the chunk body that will follow (must be > 0)
*
* @return
* - 0 on success
* - -1 on failure (NULL client, invalid state, len <= 0, or transport write error)
*/
int esp_http_client_chunk_write_begin(esp_http_client_handle_t client, const int len);
/**
* @brief End writing a chunk in chunked transfer encoding mode.
*
* Sends the chunk trailer (\\r\\n) per RFC 7230 to complete a chunk started by esp_http_client_chunk_write_begin().
* When last_chunk is true, also sends the final terminator (0\\r\\n\\r\\n) to signal end of chunked body.
* For normal (non-chunked) write operations this API is not used.
*
* @pre A chunk must have been started with esp_http_client_chunk_write_begin().
*
* @param[in] client The esp_http_client handle (must not be NULL)
* @param[in] last_chunk If true, sends the final chunk terminator (0\\r\\n\\r\\n) after the chunk trailer
*
* @return
* - 0 on success
* - -1 on failure (NULL client, invalid state, or transport write error)
*/
int esp_http_client_chunk_write_end(esp_http_client_handle_t client, bool last_chunk);
/**
* @brief This function need to call after esp_http_client_open, it will read from http stream, process all receive headers
*