Mirrors/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-09-22 13:01:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'fix/http_server_chunked_501' into 'master'

Browse Source 
Fix(esp_http_server): Fail cleanly on incoming chunked request

See merge request espressif/esp-idf!52126
This commit is contained in:
Mahavir Jain
2026-09-06 15:55:17 +05:30
parent a482934bff 036cd477a3
commit 96f54947e0
4 changed files with 225 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
components/esp_http_server/include/esp_http_server.h
View File

@@ -380,7 +380,7 @@ esp_err_t httpd_stop(httpd_handle_t handle);
*/
typedef struct httpd_req {
httpd_handle_t handle; /*!< Handle to server instance */
int method; /*!< The type of HTTP request, -1 if unsupported method, HTTP_ANY for wildcard method to support every method */
int method; /*!< The type of HTTP request (enum http_method); a request with an unrecognized method is rejected with 501 before any URI handler runs */
const char uri[CONFIG_HTTPD_MAX_URI_LEN + 1]; /*!< The URI of this request (1 byte extra for null termination) */
size_t content_len; /*!< Length of the request body */
void *aux; /*!< Internally used members */
@@ -623,10 +623,11 @@ typedef enum {
*/
HTTPD_500_INTERNAL_SERVER_ERROR = 0,
/* For methods not supported by http_parser. Presently
* http_parser halts parsing when such methods are
* encountered and so the server responds with 400 Bad
* Request error instead.
/* For request methods that http_parser does not recognize,
* and for requests carrying a Transfer-Encoding header (no
* transfer coding is implemented). Parsing aborted mid-request
* in both cases, so the server closes the session after the
* response regardless of what a custom error handler returns.
*/
HTTPD_501_METHOD_NOT_IMPLEMENTED,
@@ -634,8 +635,8 @@ typedef enum {
HTTPD_505_VERSION_NOT_SUPPORTED,
/* Returned when http_parser halts parsing due to incorrect
* syntax of request, unsupported method in request URI or
* due to chunked encoding / upgrade field present in headers
* syntax of request or due to an upgrade field present in
* headers that the server does not handle
*/
HTTPD_400_BAD_REQUEST,
@@ -700,8 +701,10 @@ typedef enum {
* guaranteed as the HTTP request may be partially received/parsed.
* - The function must return ESP_OK if underlying socket needs to
* be kept open. Any other value will ensure that the socket is
* closed. The return value is ignored when error is of type
* `HTTPD_500_INTERNAL_SERVER_ERROR` and the socket closed anyway.
* closed. The return value is ignored, and the socket is closed
* anyway, when the error is `HTTPD_500_INTERNAL_SERVER_ERROR` or
* `HTTPD_501_METHOD_NOT_IMPLEMENTED` (for 501 the request is only
* partially parsed, so the session cannot continue safely).
*
* @param[in] req HTTP request for which the error needs to be handled
* @param[in] error Error type