fix(newlib): adapt changes

components/newlib/test_apps/.build-test-rules.yml

@@ -1,7 +0,0 @@
-# Documentation: .gitlab/ci/README.md#manifest-file-to-control-the-buildtest-apps
-
-components/newlib/test_apps/newlib:
-  disable_test:
-    - if: IDF_TARGET == "esp32p4"
-      temporary: true
-      reason: p4 rev3 migration # TODO: IDF-14415

components/newlib/test_apps/newlib/main/test_misaligned_access.c

@@ -0,0 +1,162 @@
+/*
+ * SPDX-FileCopyrightText: 2025 Espressif Systems (Shanghai) CO LTD
+ *
+ * SPDX-License-Identifier: Unlicense OR CC0-1.0
+ */
+#include <stdint.h>
+#include <string.h>
+#include "esp_heap_caps.h"
+#include "soc/soc.h"
+#include "hal/cpu_ll.h"
+#include "unity.h"
+
+#define MAX_MEMTEST_SIZE 4096
+
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wincompatible-pointer-types"
+#pragma GCC diagnostic ignored "-Wstrict-prototypes"
+
+uint32_t test_function_dest_src_size(void (*foo)(...), bool pass_size)
+{
+    uint32_t ccount1, ccount2;
+    char* test_des = heap_caps_aligned_alloc(32, MAX_MEMTEST_SIZE, MALLOC_CAP_INTERNAL | MALLOC_CAP_8BIT);
+    char* test_src = heap_caps_aligned_alloc(32, MAX_MEMTEST_SIZE, MALLOC_CAP_INTERNAL | MALLOC_CAP_8BIT);
+
+    TEST_ASSERT_NOT_NULL(test_des);
+    TEST_ASSERT_NOT_NULL(test_src);
+
+    /* Prepare arrays for X-cmp functions to make the algorithm go through whole buffers. */
+    memset(test_src, 'a', MAX_MEMTEST_SIZE);
+    test_src[MAX_MEMTEST_SIZE - 1] = 0;
+    memset(test_des, 'a', MAX_MEMTEST_SIZE);
+    test_des[MAX_MEMTEST_SIZE - 1] = 'b';
+    test_des[MAX_MEMTEST_SIZE - 1] = 0;
+
+    ccount1 = esp_cpu_get_cycle_count();
+    if (pass_size) {
+        foo(test_des + 1, test_src + 2, MAX_MEMTEST_SIZE - 2);
+    } else {
+        foo(test_des + 1, test_src + 2);
+    }
+    ccount2 = esp_cpu_get_cycle_count();
+
+    heap_caps_free(test_des);
+    heap_caps_free(test_src);
+
+    return ccount2 - ccount1;
+}
+
+TEST_CASE("memcpy", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(memcpy, true);
+    /* esp32c2: 4128 cycles instead 28676.  */
+    TEST_ASSERT_LESS_THAN(10000, ccount);
+}
+
+TEST_CASE("memcmp", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(memcmp, true);
+    /* esp32c2: 14259 cycles instead 49147.  */
+    TEST_ASSERT_LESS_THAN(20000, ccount);
+}
+
+TEST_CASE("memmove", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(memmove, true);
+    /* esp32c2: 8086 cycles instead 33896.  */
+    TEST_ASSERT_LESS_THAN(15000, ccount);
+}
+
+TEST_CASE("memmove - overlapping", "[misaligned_mem]")
+{
+    uint32_t ccount1, ccount2;
+    char* buf = heap_caps_aligned_alloc(32, MAX_MEMTEST_SIZE, MALLOC_CAP_INTERNAL | MALLOC_CAP_8BIT);
+
+    TEST_ASSERT_NOT_NULL(buf);
+
+    ccount1 = esp_cpu_get_cycle_count();
+    memmove(buf + 5, buf + 2, MAX_MEMTEST_SIZE - 5);
+    ccount2 = esp_cpu_get_cycle_count();
+
+    heap_caps_free(buf);
+
+    /* esp32c2: 11503 cycles instead 45024.  */
+    TEST_ASSERT_LESS_THAN(20000, ccount2 - ccount1);
+}
+
+TEST_CASE("strcpy", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(strcpy, false);
+    /* esp32c2: 17313 cycles instead 32771.  */
+    TEST_ASSERT_LESS_THAN(22000, ccount);
+}
+
+TEST_CASE("strcmp", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(strcmp, false);
+    /* esp32c2: 13191 cycles instead 32775.  */
+    TEST_ASSERT_LESS_THAN(20000, ccount);
+}
+
+TEST_CASE("strncpy", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(strncpy, true);
+    /* esp32c2: 21475 cycles instead 36859.  */
+    TEST_ASSERT_LESS_THAN(25000, ccount);
+}
+
+TEST_CASE("strncmp", "[misaligned_mem]")
+{
+    uint32_t ccount = test_function_dest_src_size(strncmp, true);
+    /* esp32c2: 24369 cycles instead 49141.  */
+    TEST_ASSERT_LESS_THAN(30000, ccount);
+}
+#pragma GCC diagnostic pop // "-Wincompatible-pointer-types" "-Wstrict-prototypes"
+
+static bool fn_in_ram(void *fn)
+{
+    const int fnaddr = (int)fn;
+    return (fnaddr >= SOC_IRAM_LOW && fnaddr < SOC_IRAM_HIGH);
+}
+
+TEST_CASE("mem functions in IRAM", "[misaligned_mem]")
+{
+    TEST_ASSERT_TRUE(fn_in_ram(memcpy));
+    TEST_ASSERT_TRUE(fn_in_ram(memcmp));
+    TEST_ASSERT_TRUE(fn_in_ram(memmove));
+    TEST_ASSERT_TRUE(fn_in_ram(strcpy));
+    TEST_ASSERT_TRUE(fn_in_ram(strncpy));
+    TEST_ASSERT_TRUE(fn_in_ram(strcmp));
+    TEST_ASSERT_TRUE(fn_in_ram(strncmp));
+}
+
+#if CONFIG_ESP_SYSTEM_MEMPROT_PMP
+TEST_CASE("access across different PMP regions", "[misaligned_mem]")
+{
+    /*
+     * PMP configurations for load and store addresses may
+     * have different permissions (e.g., "R" vs. "RW").
+     *
+     * Due to the timing alignment of internal signals, the address
+     * permission check may be incorrectly applied during the second
+     * part of a misaligned access transaction.
+     *
+     * As a workaround, insert two instructions (e.g. ADDI/NOP) between
+     * accessing to different memory regions. This spacing avoids the
+     * false permission check caused by signal timing overlap.
+     *
+     * This test may help identify the root issue in affected chips.
+     */
+
+    const void *src = (void *) SOC_DROM_MASK_LOW;
+    asm volatile("addi sp, sp, -16\n"
+                 "lw t0, 2(%0)\n"
+#if CONFIG_SOC_CPU_MISALIGNED_ACCESS_ON_PMP_MISMATCH_ISSUE
+                 "nop\n"
+                 "nop\n"
+#endif
+                 "sw t0, 3(sp)\n"
+                 "addi sp, sp, 16"
+                 :: "r"(src) : "memory");
+}
+#endif

components/newlib/test_apps/newlib/main/test_newlib.c

@@ -10,6 +10,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <time.h>
+#include <signal.h>
 #include <sys/time.h>
 #include <wchar.h>
 #include <unistd.h>

components/newlib/test_apps/no_rvfplib/CMakeLists.txt

@@ -0,0 +1,10 @@
+# The following lines of boilerplate have to be in your project's
+# CMakeLists in this exact order for cmake to work correctly
+cmake_minimum_required(VERSION 3.22)
+
+include($ENV{IDF_PATH}/tools/cmake/project.cmake)
+
+# "Trim" the build. Include the minimal set of components, main, and anything it depends on.
+idf_build_set_property(MINIMAL_BUILD ON)
+
+project(test_build)

components/newlib/test_apps/no_rvfplib/README.md

@@ -0,0 +1,6 @@
+| Supported Targets | ESP32 | ESP32-C2 | ESP32-C3 | ESP32-C5 | ESP32-C6 | ESP32-C61 | ESP32-H2 | ESP32-H21 | ESP32-H4 | ESP32-P4 | ESP32-S2 | ESP32-S3 |
+| ----------------- | ----- | -------- | -------- | -------- | -------- | --------- | -------- | --------- | -------- | -------- | -------- | -------- |
+
+This project tests building with the no_rvfplib configuration.
+
+This project uses MINIMAL_BUILD=y to reduce build time and dependencies.

components/newlib/test_apps/no_rvfplib/main/CMakeLists.txt

@@ -0,0 +1,2 @@
+idf_component_register(SRCS "test_main.c"
+                       INCLUDE_DIRS ".")

components/newlib/test_apps/no_rvfplib/main/test_main.c

@@ -0,0 +1,8 @@
+/*
+ * SPDX-FileCopyrightText: 2025 Espressif Systems (Shanghai) CO LTD
+ *
+ * SPDX-License-Identifier: Unlicense OR CC0-1.0
+ */
+void app_main(void)
+{
+}

components/newlib/test_apps/no_rvfplib/sdkconfig.ci.default

@@ -0,0 +1,2 @@
+CONFIG_IDF_TARGET="esp32c2"
+CONFIG_COMPILER_FLOAT_LIB_FROM_GCCLIB=y