From 6e3fae60fc2de821636a1da699b9499734b1f2ff Mon Sep 17 00:00:00 2001 From: Sudeep Mohanty Date: Fri, 17 Apr 2026 11:40:22 +0200 Subject: [PATCH] fix(components): initialize srcs variable to prevent scope leakage --- components/app_trace/CMakeLists.txt | 3 ++- components/esp_tee/CMakeLists.txt | 1 + components/esp_trace/CMakeLists.txt | 3 ++- components/spiffs/CMakeLists.txt | 2 ++ 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/components/app_trace/CMakeLists.txt b/components/app_trace/CMakeLists.txt index 78513c5c295..56a53429a4e 100644 --- a/components/app_trace/CMakeLists.txt +++ b/components/app_trace/CMakeLists.txt @@ -4,8 +4,9 @@ if(${target} STREQUAL "linux") return() # This component is not supported by the POSIX/Linux simulator endif() +set(srcs) if(CONFIG_ESP_TRACE_TRANSPORT_APPTRACE) - set(srcs + list(APPEND srcs "app_trace.c" "app_trace_util.c" "host_file_io.c" diff --git a/components/esp_tee/CMakeLists.txt b/components/esp_tee/CMakeLists.txt index f75bb4b970b..dcba631e4d3 100644 --- a/components/esp_tee/CMakeLists.txt +++ b/components/esp_tee/CMakeLists.txt @@ -19,6 +19,7 @@ elseif(esp_tee_build) # TEE build currently only uses the shared headers. idf_component_register(INCLUDE_DIRS include) else() + set(srcs) if(CONFIG_SECURE_ENABLE_TEE) if(NOT CMAKE_BUILD_EARLY_EXPANSION) # Add custom flash target for TEE binary diff --git a/components/esp_trace/CMakeLists.txt b/components/esp_trace/CMakeLists.txt index 876cdf00e77..937b664d110 100644 --- a/components/esp_trace/CMakeLists.txt +++ b/components/esp_trace/CMakeLists.txt @@ -4,8 +4,9 @@ if(${target} STREQUAL "linux") return() endif() +set(srcs) if(CONFIG_ESP_TRACE_ENABLE) - set(srcs + list(APPEND srcs "src/core/esp_trace_core.c" "src/core/esp_trace_registry.c" "src/ports/port_utils.c" diff --git a/components/spiffs/CMakeLists.txt b/components/spiffs/CMakeLists.txt index e53ea7166dd..27ae6405740 100644 --- a/components/spiffs/CMakeLists.txt +++ b/components/spiffs/CMakeLists.txt @@ -6,6 +6,8 @@ set(original_srcs "spiffs/src/spiffs_cache.c" "spiffs/src/spiffs_hydrogen.c" "spiffs/src/spiffs_nucleus.c") +set(srcs) +set(pr) list(APPEND srcs "spiffs_api.c" ${original_srcs}) if(NOT ${target} STREQUAL "linux")