From 632adbfa6f4b28405202b7bf34ec07c786a908ba Mon Sep 17 00:00:00 2001 From: Song Ruo Jing Date: Wed, 24 Jun 2026 22:04:01 +0800 Subject: [PATCH] fix(dma2d): fix non-usable DMA2D_CSC_TX_SCRAMBLE option --- components/hal/esp32p4/include/hal/dma2d_ll.h | 2 +- components/hal/include/hal/dma2d_types.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/components/hal/esp32p4/include/hal/dma2d_ll.h b/components/hal/esp32p4/include/hal/dma2d_ll.h index 7f5e9b501d9..eb5afc387a4 100644 --- a/components/hal/esp32p4/include/hal/dma2d_ll.h +++ b/components/hal/esp32p4/include/hal/dma2d_ll.h @@ -995,7 +995,7 @@ static inline void dma2d_ll_tx_configure_color_space_conv(dma2d_dev_t *dev, uint input_sel = 7; break; case DMA2D_CSC_TX_SCRAMBLE: - input_sel = 2; // Or 3 + input_sel = 3; // only 3 bytes/pixel format is supported for scrambling proc_en = false; output_sel = 2; break; diff --git a/components/hal/include/hal/dma2d_types.h b/components/hal/include/hal/dma2d_types.h index 3cf61343ace..2bdea671d7b 100644 --- a/components/hal/include/hal/dma2d_types.h +++ b/components/hal/include/hal/dma2d_types.h @@ -133,6 +133,7 @@ typedef enum { * @brief Enumeration of 2D-DMA pixel bytes scamble order in color space conversion * * Assuming the original pixel byte order (from MSB to LSB) is 2-1-0 . + * This scramble only fits 3 bytes/pixel format. For non-3 bytes/pixel format, the pixels will be messed up if scrambling is used. */ typedef enum { DMA2D_SCRAMBLE_ORDER_BYTE2_1_0, /*!< 2D-DMA pixel data scrambled as BYTE2-1-0 (no scramble) */