Mirrors/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-10-02 03:00:34 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor(driver_twai): remove errata config selection 5

Browse Source
This commit is contained in:
wanckl
2025-11-11 13:18:14 +08:00
parent 334a0d2747
commit 3e361a559f
7 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/esp_driver_twai/Kconfig
+1 -1
View File
@@ -18,7 +18,7 @@ menu "ESP-Driver:TWAI Configurations"
config TWAI_ISR_CACHE_SAFE
bool "Allow TWAI ISR execute when cache disabled" if !SPI_FLASH_AUTO_SUSPEND
select TWAI_ISR_IN_IRAM
select ESP_PERIPH_CTRL_FUNC_IN_IRAM if TWAI_ERRATA_FIX_RX_FRAME_INVALID || IDF_TARGET_ESP32
select ESP_PERIPH_CTRL_FUNC_IN_IRAM if IDF_TARGET_ESP32 #For errata workarounds
default n
help
Allow TWAI works under Cache disabled (such as when writing to SPI Flash),
components/esp_driver_twai/esp_twai_onchip.c
+5 -2
View File
@@ -201,8 +201,11 @@ static void _node_isr_main(void *arg)
twai_onchip_ctx_t *twai_ctx = arg;
uint32_t events = twai_hal_get_events(twai_ctx->hal); //Get the events that triggered the interrupt
#if CONFIG_IDF_TARGET_ESP32 // only esp32 have this errata, TODO: IDF-13002 check errata runtime
#if TWAI_LL_HAS_RX_FRAME_ISSUE || TWAI_LL_HAS_RX_FIFO_ISSUE
// Errata workaround: Reset the peripheral on detection of this errata condition.
// Note that if a frame is being sent on the bus during the reset, the message will be lost.
if (events & TWAI_HAL_EVENT_NEED_PERIPH_RESET) {
ESP_EARLY_LOGD(TAG, "Triggered peripheral reset");
twai_hal_prepare_for_reset(twai_ctx->hal);
TWAI_RCC_ATOMIC() {
twai_ll_reset_register(twai_ctx->ctrlr_id);
@@ -498,7 +501,7 @@ static esp_err_t _node_disable(twai_node_handle_t node)
ESP_RETURN_ON_ERROR(esp_intr_disable(twai_ctx->intr_hdl), TAG, "disable interrupt failed");
atomic_store(&twai_ctx->state, TWAI_ERROR_BUS_OFF);
twai_hal_stop(twai_ctx->hal);
#if CONFIG_IDF_TARGET_ESP32 // only esp32 have this errata, TODO: IDF-13002 check errata runtime
#if TWAI_LL_HAS_RX_FRAME_ISSUE
// when `disable` happens during hardware busy, the next RX frame is corrupted, a HW reset can fix it
if (twai_hal_is_hw_busy(twai_ctx->hal)) {
twai_hal_backup_config(twai_ctx->hal);