Mirrors/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-10-02 11:10:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(isp): fix typo in CONFIG_ISP_ISR_IRAM_SAFE macro reference

Browse Source 
SAEE -> SAFE in isp_ae.c, causing the IRAM safety check to never
trigger regardless of the Kconfig setting.
This commit is contained in:
Marius Vikhammer
2026-06-29 10:32:05 +08:00
parent b170866059
commit 3a35c57824
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/esp_driver_isp/include/driver/isp_ae.h
+2 -2
View File
@@ -194,7 +194,7 @@ typedef bool (*esp_isp_ae_env_detector_callback_t)(isp_ae_ctlr_t ae_ctlr, const
/** /**
* @brief Group of ISP AE env_detector * @brief Group of ISP AE env_detector
* @note These callbacks are all running in an ISR environment. * @note These callbacks are all running in an ISR environment.
* @note When CONFIG_ISP_ISR_IRAM_SAEE is enabled, the callback itself and functions called by it should be placed in IRAM. * @note When CONFIG_ISP_ISR_IRAM_SAFE is enabled, the callback itself and functions called by it should be placed in IRAM.
* Involved variables should be in internal RAM as well. * Involved variables should be in internal RAM as well.
*/ */
typedef struct { typedef struct {
@@ -207,7 +207,7 @@ typedef struct {
* *
* @note User can deregister a previously registered callback by calling this function and setting the to-be-deregistered callback member in * @note User can deregister a previously registered callback by calling this function and setting the to-be-deregistered callback member in
* the `cbs` structure to NULL. * the `cbs` structure to NULL.
* @note When CONFIG_ISP_ISR_IRAM_SAEE is enabled, the callback itself and functions called by it should be placed in IRAM. * @note When CONFIG_ISP_ISR_IRAM_SAFE is enabled, the callback itself and functions called by it should be placed in IRAM.
* Involved variables (including `user_data`) should be in internal RAM as well. * Involved variables (including `user_data`) should be in internal RAM as well.
* *
* @param[in] ae_ctlr AE controller handle * @param[in] ae_ctlr AE controller handle
components/esp_driver_isp/src/isp_ae.c
+1 -1
View File
@@ -233,7 +233,7 @@ esp_err_t esp_isp_ae_env_detector_register_event_callbacks(isp_ae_ctlr_t ae_ctlr
ESP_RETURN_ON_FALSE(ae_ctlr && cbs, ESP_ERR_INVALID_ARG, TAG, "invalid argument"); ESP_RETURN_ON_FALSE(ae_ctlr && cbs, ESP_ERR_INVALID_ARG, TAG, "invalid argument");
ESP_RETURN_ON_FALSE(atomic_load(&ae_ctlr->fsm) == ISP_FSM_INIT, ESP_ERR_INVALID_STATE, TAG, "controller not in init state"); ESP_RETURN_ON_FALSE(atomic_load(&ae_ctlr->fsm) == ISP_FSM_INIT, ESP_ERR_INVALID_STATE, TAG, "controller not in init state");
#if CONFIG_ISP_ISR_IRAM_SAEE #if CONFIG_ISP_ISR_IRAM_SAFE
if (cbs->on_env_statistics_done) { if (cbs->on_env_statistics_done) {
ESP_RETURN_ON_FALSE(esp_ptr_in_iram(cbs->on_env_statistics_done), ESP_ERR_INVALID_ARG, TAG, "on_env_statistics_done callback not in IRAM"); ESP_RETURN_ON_FALSE(esp_ptr_in_iram(cbs->on_env_statistics_done), ESP_ERR_INVALID_ARG, TAG, "on_env_statistics_done callback not in IRAM");
} }