Mirrors/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf.git synced 2026-10-02 11:10:54 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(nvs_flash): check readEntry return in debugDump

Browse Source
This commit is contained in:
sonika.rathi
2026-08-11 11:43:53 +02:00
parent c6e80a336a
commit 0dfb4ac777
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/nvs_flash/src/nvs_page.cpp
+5 -1
View File
@@ -1255,7 +1255,11 @@ void Page::debugDump() const
printf("X\n"); printf("X\n");
} else if (state == EntryState::WRITTEN) { } else if (state == EntryState::WRITTEN) {
Item item; Item item;
readEntry(i, item); // Check readEntry: Item() leaves fields uninitialized; printing key/%s on failure is UB.
if (readEntry(i, item) != ESP_OK) {
printf("Failed to read entry\n");
return;
}
if (skip == 0) { if (skip == 0) {
printf("W ns=%2" PRIu8 " type=%2" PRIu8 " span=%3" PRIu8 " key=\"%s\" chunkIdx=%" PRIu8 " len=%" PRIi32 "\n", printf("W ns=%2" PRIu8 " type=%2" PRIu8 " span=%3" PRIu8 " key=\"%s\" chunkIdx=%" PRIu8 " len=%" PRIi32 "\n",
item.nsIndex, static_cast<uint8_t>(item.datatype), item.span, item.key, item.chunkIndex, (item.span != 1) ? (static_cast<int32_t>(item.varLength.dataSize)) : (-1)); item.nsIndex, static_cast<uint8_t>(item.datatype), item.span, item.key, item.chunkIndex, (item.span != 1) ? (static_cast<int32_t>(item.varLength.dataSize)) : (-1));