Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-08-18 06:55:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

Add multi-thread protection to: ModelSelection.

Browse Source 
Make UIAbstractView::notifySelectionChange thread-safe.
Added new UI Test (FontRendering.UITextTest).
This commit is contained in:
Martín Lucas Golini
2026-01-14 20:12:45 -03:00
parent 0f8f15fa53
commit f8fe1d9687
6 changed files with 126 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
include/eepp/ui/models/modelselection.hpp
View File

@@ -2,6 +2,8 @@
#define EE_UI_MODEL_MODELSELECTION_HPP
#include <algorithm>
#include <eepp/system/lock.hpp>
#include <eepp/system/mutex.hpp>
#include <eepp/ui/models/modelindex.hpp>
#include <functional>
@@ -17,12 +19,20 @@ class EE_API ModelSelection {
public:
ModelSelection( UIAbstractView* view ) : mView( view ) {}
int size() const { return mIndexes.size(); }
bool isEmpty() const { return mIndexes.empty(); }
int size() const {
Lock l( mMutex );
return mIndexes.size();
}
bool isEmpty() const {
Lock l( mMutex );
return mIndexes.empty();
}
bool contains( const ModelIndex& index ) const {
Lock l( mMutex );
return std::find( mIndexes.begin(), mIndexes.end(), index ) != mIndexes.end();
}
bool containsRow( int row ) const {
Lock l( mMutex );
for ( auto& index : mIndexes ) {
if ( index.row() == row )
return true;
@@ -48,13 +58,16 @@ class EE_API ModelSelection {
}
std::vector<ModelIndex> indexes() const {
Lock l( mMutex );
std::vector<ModelIndex> indexes;
indexes.reserve( mIndexes.size() );
for ( auto& index : mIndexes )
indexes.push_back( index );
return indexes;
}
ModelIndex first() const {
Lock l( mMutex );
if ( mIndexes.empty() )
return {};
return *mIndexes.begin();
@@ -79,6 +92,8 @@ class EE_API ModelSelection {
bool mDisableNotify{ false };
bool mNotifyPending{ false };
void notifySelectionChanged();
mutable Mutex mMutex;
};
}}} // namespace EE::UI::Models