Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-08-14 21:22:40 +03:00
Code Issues Packages Projects Releases Wiki Activity

This should fix two crashes:

Browse Source 
* A crash during debugging that happens due to invalid memory access (UIAbstractView + VariablesModel changes).
* A crash on ChatUI when closing a chat that was about to receive a server response.
This commit is contained in:
Martín Lucas Golini
2026-03-06 00:53:05 -03:00
parent 6a9c2bbeeb
commit f2a70f9589
7 changed files with 76 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
src/tools/ecode/plugins/aiassistant/chatui.cpp
View File

@@ -595,6 +595,16 @@ LLMChatUI::LLMChatUI( PluginManager* manager ) :
}
LLMChatUI::~LLMChatUI() {
if ( mRequest ) {
mRequest->cancelCb = nullptr;
mRequest->doneCb = nullptr;
mRequest->streamedResponseCb = nullptr;
}
if ( mSummaryRequest ) {
mSummaryRequest->cancelCb = nullptr;
mSummaryRequest->doneCb = nullptr;
mSummaryRequest->streamedResponseCb = nullptr;
}
if ( getPlugin() ) {
AIAssistantPlugin::AIAssistantConfig config;
config.partition = getSplitter()->getSplitPartition();
@@ -1168,28 +1178,27 @@ void LLMChatUI::generateChatName( bool isRenaming ) {
mSummaryRequest->doneCb = [this, isRenaming]( const LLMChatCompletionRequest& req,
Http::Response& response ) {
auto status = response.getStatus();
String oldSummary = std::move( mSummary );
runOnMainThread( [this, isRenaming, status, responseText = req.getResponse()] {
String oldSummary = std::move( mSummary );
if ( status == Http::Response::Ok ) {
mSummary = String::trim( req.getResponse() );
String::trimInPlace( mSummary, '\n' );
String::trimInPlace( mSummary, ' ' );
String::trimInPlace( mSummary, '"' );
} else {
// TODO: Implement generating a summary based on the user prompt (take the
// first few words)
mSummary = i18n( "untitled_conversation", "Untitled Conversation" );
}
if ( status == Http::Response::Ok ) {
mSummary = String::trim( responseText );
String::trimInPlace( mSummary, '\n' );
String::trimInPlace( mSummary, ' ' );
String::trimInPlace( mSummary, '"' );
} else {
// TODO: Implement generating a summary based on the user prompt (take the
// first few words)
mSummary = i18n( "untitled_conversation", "Untitled Conversation" );
}
if ( isRenaming ) {
String newSummary = std::move( mSummary );
mSummary = std::move( oldSummary );
runOnMainThread(
[this, newSummary = std::move( newSummary )] { renameChat( newSummary ); } );
} else
saveChat();
if ( isRenaming ) {
String newSummary = std::move( mSummary );
mSummary = std::move( oldSummary );
renameChat( newSummary );
} else
saveChat();
runOnMainThread( [this] {
updateTabTitle();
mSummaryRequest.reset();
} );
@@ -1258,15 +1267,17 @@ void LLMChatUI::doRequest() {
};
mRequest->cancelCb = [this, thinking, thinkingID, editor]( const LLMChatCompletionRequest& ) {
thinking->removeActionsByTag( thinkingID );
thinking->setVisible( false );
mChatStop->setVisible( false )->setEnabled( false );
mChatRun->setVisible( true )->setEnabled( true );
toggleEnableChats( true );
editor->setEnabled( true );
if ( editor->hasFocus() )
mChatInput->setFocus();
removeLastChat();
runOnMainThread( [this, thinking, thinkingID, editor] {
thinking->removeActionsByTag( thinkingID );
thinking->setVisible( false );
mChatStop->setVisible( false )->setEnabled( false );
mChatRun->setVisible( true )->setEnabled( true );
toggleEnableChats( true );
editor->setEnabled( true );
if ( editor->hasFocus() )
mChatInput->setFocus();
removeLastChat();
} );
};
mRequest->doneCb =