Allow to pass std::string and std::string_view as a %s parameter in String::format and Log::debug/info/etc.

This commit is contained in:
Martín Lucas Golini
2024-01-06 10:37:38 -03:00
parent 748ead4a97
commit eec3397592
6 changed files with 65 additions and 69 deletions

View File

@@ -20,7 +20,7 @@ PluginManager::PluginManager( const std::string& resourcesPath, const std::strin
PluginManager::~PluginManager() {
mClosing = true;
for ( auto& plugin : mPlugins ) {
Log::debug( "PluginManager: unloading plugin %s", plugin.second->getTitle().c_str() );
Log::debug( "PluginManager: unloading plugin %s", plugin.second->getTitle() );
eeDelete( plugin.second );
}
unsubscribeFileSystemListener();
@@ -49,7 +49,7 @@ bool PluginManager::setEnabled( const std::string& id, bool enable, bool sync )
mPluginsEnabled[id] = enable;
Plugin* plugin = get( id );
if ( enable && plugin == nullptr && hasDefinition( id ) ) {
Log::debug( "PluginManager: loading plugin %s", mDefinitions[id].name.c_str() );
Log::debug( "PluginManager: loading plugin %s", mDefinitions[id].name );
Plugin* newPlugin = sync && mDefinitions[id].creatorSyncFn
? mDefinitions[id].creatorSyncFn( this )
: mDefinitions[id].creatorFn( this );
@@ -59,7 +59,7 @@ bool PluginManager::setEnabled( const std::string& id, bool enable, bool sync )
return true;
}
if ( !enable && plugin != nullptr ) {
Log::debug( "PluginManager: unloading plugin %s", mDefinitions[id].name.c_str() );
Log::debug( "PluginManager: unloading plugin %s", mDefinitions[id].name );
mThreadPool->run( [plugin]() { eeDelete( plugin ); } );
{
Lock l( mSubscribedPluginsMutex );