Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-09-22 13:01:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix HTML loading stalls on large modern pages

Browse Source 
- batch asynchronous HTTP stylesheets and apply them in a single reload
  - skip unsupported block at-rules without leaking nested rules
  - prevent scripts nested in unknown custom elements from entering the render tree
  - add regression coverage for unsupported at-rules and nested scripts
  - document the Ninja release workflow for performance testing
This commit is contained in:
Martín Lucas Golini
2026-08-02 00:55:03 -03:00
parent fe8417bdc7
commit eb7398f9ec
6 changed files with 105 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/tests/unit_tests/uihtml_tests.cpp
View File

@@ -3003,6 +3003,36 @@ UTEST( UIHTML, MarkdownViewLoadsBodyChildrenIntoNativeTree ) {
Engine::destroySingleton();
}
UTEST( UIHTML, ScriptNestedInUnknownElementIsNotRendered ) {
init_ui_test();
auto* sceneNode = SceneManager::instance()->getUISceneNode();
sceneNode->loadLayoutFromString( HTMLFormatter::HTMLtoXML( R"html(
<html><body><react-app id="app">
<script type="application/json">{"payload":"must-not-render"}</script>
<span id="visible">Visible</span>
</react-app></body></html>
)html" ) );
auto* app = sceneNode->getRoot()->find( "app" );
ASSERT_TRUE( app != nullptr );
EXPECT_TRUE( app->asType<UIWidget>()->findByTag( "script" ) == nullptr );
EXPECT_TRUE( app->find( "visible" ) != nullptr );
Engine::destroySingleton();
}
UTEST( UIHTML, UnsupportedBlockAtRulesDoNotLeakNestedRules ) {
StyleSheetParser parser;
ASSERT_TRUE( parser.loadFromString( std::string_view{
"@layer framework { .layered { color: red; } @supports (display: grid) { .nested { "
"display: grid; } } } .visible { color: blue; }" } ) );
EXPECT_TRUE( parser.getStyleSheet().findStyleFromSelectorName( ".layered" ).empty() );
EXPECT_TRUE( parser.getStyleSheet().findStyleFromSelectorName( ".nested" ).empty() );
EXPECT_EQ( 1u, parser.getStyleSheet().findStyleFromSelectorName( ".visible" ).size() );
}
UTEST( UIHTML, StyleSheetSiblingCombinators ) {
Engine::instance()->createWindow( WindowSettings( 1024, 768, "CSS Sibling Test",
WindowStyle::Default, WindowBackend::Default,