Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-08-18 06:55:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

Graphics: refine drawable cloning and icon source rendering:

Browse Source 
Rename Drawable::createInstance() to clone() and update drawable implementations,
typed helpers, consumers, tests, tools, and external modules.

Avoid retaining private icon clones for immediate single-threaded rendering in the
code editor and ecode plugins. Borrow cached per-size icon sources instead, restoring
temporary color changes after drawing, while preserving owned clones for widgets,
menus, models, and other stateful consumers.

Reduce common drawable allocation overhead by lazily creating DrawableResource
callback state, using inline callback storage and notification snapshots, and safely
supporting callback disconnection during notification.

Lazily allocate UIImage and UINodeDrawable asynchronous lifetime tokens only when
an uncached asynchronous load is actually scheduled.

Document the distinction between borrowed immediate rendering and independently
owned drawable state.
This commit is contained in:
Martín Lucas Golini
2026-07-21 21:16:32 -03:00
parent 953e0ea006
commit b5efd6d709
60 changed files with 207 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/tools/ecode/plugins/debugger/debuggerplugin.cpp
View File

@@ -183,23 +183,6 @@ DebuggerPlugin::~DebuggerPlugin() {
}
}
void DebuggerPlugin::update( UICodeEditor* editor ) {
if ( mBreakpointIcon == nullptr )
mBreakpointIcon = getUISceneNode()->findIcon( "circle-perfect" );
if ( mBreakpointIcon ) {
const int iconSize = (int)eefloor( editor->getLineHeight() * 0.875f );
if ( mBreakpointDrawables.find( iconSize ) == mBreakpointDrawables.end() )
mBreakpointDrawables[iconSize] = mBreakpointIcon->createDrawable( iconSize );
}
if ( mStackFrameIcon == nullptr )
mStackFrameIcon = getUISceneNode()->findIcon( "debug-stackframe" );
if ( mStackFrameIcon ) {
const int iconSize = (int)eefloor( editor->getLineHeight() );
if ( mStackFrameDrawables.find( iconSize ) == mStackFrameDrawables.end() )
mStackFrameDrawables[iconSize] = mStackFrameIcon->createDrawable( iconSize );
}
}
void DebuggerPlugin::onSaveProject( const std::string& /*projectFolder*/,
const std::string& projectStatePath,
bool rewriteStateOnlyIfNeeded ) {
@@ -1619,11 +1602,12 @@ void DebuggerPlugin::drawLineNumbersBefore( UICodeEditor* editor,
.blendAlpha( editor->getAlpha() ) );
bool iconDrawn = false;
if ( mBreakpointIcon == nullptr )
mBreakpointIcon = getUISceneNode()->findIcon( "circle-perfect" );
if ( mBreakpointIcon ) {
Float finalHeight = eefloor( radius * 1.75f );
auto drawableIt = mBreakpointDrawables.find( (int)finalHeight );
if ( drawableIt != mBreakpointDrawables.end() && drawableIt->second ) {
DrawablePtr& drawable = drawableIt->second;
Drawable* drawable = mBreakpointIcon->getSource( (int)finalHeight ).get();
if ( drawable ) {
Color oldColor = drawable->getColor();
drawable->setColor( color );
drawable->draw(
@@ -1664,12 +1648,16 @@ void DebuggerPlugin::drawLineNumbersBefore( UICodeEditor* editor,
Float dim = radius * 2;
Float gutterSpace = editor->getGutterSpace( this );
if ( mStackFrameIcon == nullptr )
mStackFrameIcon = getUISceneNode()->findIcon( "debug-stackframe" );
if ( mStackFrameIcon ) {
const int iconSize = (int)eefloor( lineHeight );
auto drawableIt = mStackFrameDrawables.find( iconSize );
if ( drawableIt != mStackFrameDrawables.end() && drawableIt->second ) {
drawableIt->second->setColor( color );
drawableIt->second->draw( lnPos.floor() );
Drawable* drawable = mStackFrameIcon->getSource( iconSize ).get();
if ( drawable ) {
Color oldColor = drawable->getColor();
drawable->setColor( color );
drawable->draw( lnPos.floor() );
drawable->setColor( oldColor );
return;
}
}