Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-10-18 11:33:23 +03:00
Code Issues Packages Projects Releases Wiki Activity

Improve Git History navigation and commit details

Browse Source 
Add a detached Git Commit History tab with a traditional table layout, persistent column widths, commit focusing, and a splitter-based commit details pane.
Register the git-show-history command and expose “Show in Git History” from commit details and history context menus. Add History and Git Commit tab icons, localized titles, appropriate tooltips, and ref-aware
tab naming.
Share the commit-details layout and behavior between standalone commit tabs and detached History views. Move view creation, widget binding, state management, controls, and asynchronous changed-file loading into
CommitDetailsState.
Display complete commit metadata and messages, GitHub links, copyable commit SHAs, colored changed-file statistics, and multi-file diffs with global expand/collapse and unified/split controls.
Improve detached-history lifecycle behavior, selection and focus handling, stale-request protection, tooltip formatting, and column recalculation. Restore “Load older commits” by preserving pagination-node
semantics while asynchronous loading is in progress.
Fix expandable History rows so merge subjects and metadata render correctly without regressing generic UITreeView cells. Add recursive commit lookup for focusing nested history entries.
Add deferred tooltip-created notifications and configure History tooltips only after their widgets exist.
Preserve tokenizer-applied UITextView color ranges during layout recalculation when custom styling is enabled, preventing changed-file statistics from losing their colors after splitter resizing.
Add the required Codicons and translations, expose UIWidget pseudo-class queries, reuse cached tree-expander drawable sources, and use SmallVector for nested stylesheet property resolution.
This commit is contained in:
Martín Lucas Golini
2026-08-29 02:15:26 -03:00
parent ef962fc61f
commit 61d9d3c7bc
15 changed files with 551 additions and 204 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/tools/ecode/plugins/git/gitplugin.hpp
+83 -22
View File
@@ -25,6 +25,7 @@ class UIStackWidget;
class UIListBoxItem;
class UIMenu;
class UITextView;
class UISplitter;
} // namespace EE::UI
namespace ecode {
@@ -167,27 +168,74 @@ class GitPlugin : public PluginBase {
std::string mHistoryRevision{ "HEAD" };
bool mUpdatingHistoryRefs{ false };
bool mHistoryLoaded{ false };
UIWidget* mCommitDetailsView{ nullptr };
UITextView* mCommitDetailsSubject{ nullptr };
UITextView* mCommitDetailsMetadata{ nullptr };
UITextView* mCommitDetailsMessage{ nullptr };
UITextView* mCommitDetailsParents{ nullptr };
UITextView* mCommitDetailsStatus{ nullptr };
UIPushButton* mCommitDetailsMessageToggle{ nullptr };
UIPushButton* mCommitDetailsFilesToggle{ nullptr };
UIPushButton* mCommitDetailsModeToggle{ nullptr };
UIPushButton* mCommitDetailsGitHub{ nullptr };
UIWidget* mCommitDetailsDiffContainer{ nullptr };
UIScrollView* mCommitDetailsDiff{ nullptr };
std::string mCommitDetailsMessageBody;
std::string mCommitDetailsURL;
bool mCommitDetailsMessageExpanded{ false };
bool mCommitDetailsFilesCollapsed{ false };
Tools::UIDiffView::ViewMode mCommitDetailsViewMode{ Tools::UIDiffView::ViewMode::Unified };
Git::Commit mCommitDetailsCommit;
std::string mCommitDetailsRepo;
std::atomic<Uint64> mCommitDetailsGeneration{ 0 };
EventConnection mCommitDetailsCloseConnection;
struct CommitDetailsState {
UIWidget* view{ nullptr };
UITextView* subject{ nullptr };
UITextView* author{ nullptr };
UITextView* dateEmail{ nullptr };
UITextView* message{ nullptr };
UITextView* status{ nullptr };
UIPushButton* messageToggle{ nullptr };
UIPushButton* filesToggle{ nullptr };
UIPushButton* modeToggle{ nullptr };
UIPushButton* gitHub{ nullptr };
UIWidget* diffContainer{ nullptr };
UIScrollView* diff{ nullptr };
std::string messageBody;
std::string url;
Git::Commit commit;
std::string repo;
std::atomic<Uint64> generation{ 0 };
EventConnection closeConnection;
Tools::UIDiffView::ViewMode viewMode{ Tools::UIDiffView::ViewMode::Unified };
bool messageExpanded{ false };
bool filesCollapsed{ false };
void openCommitDetails( GitPlugin& plugin, const Git::Commit& commit, bool detached );
void loadCommitFiles( GitPlugin& plugin, bool detached );
void reset() {
++generation;
view = nullptr;
subject = nullptr;
author = nullptr;
dateEmail = nullptr;
message = nullptr;
status = nullptr;
messageToggle = nullptr;
filesToggle = nullptr;
modeToggle = nullptr;
gitHub = nullptr;
diffContainer = nullptr;
diff = nullptr;
messageBody.clear();
url.clear();
commit = {};
repo.clear();
viewMode = Tools::UIDiffView::ViewMode::Unified;
messageExpanded = false;
filesCollapsed = false;
}
};
struct DetachedHistoryState {
UISplitter* view{ nullptr };
UITreeView* tree{ nullptr };
UIWidget* detailsHost{ nullptr };
EventConnection closeConnection;
std::string focusHash;
CommitDetailsState details;
void reset() {
view = nullptr;
tree = nullptr;
detailsHost = nullptr;
focusHash.clear();
details.reset();
}
};
CommitDetailsState mCommitDetails;
DetachedHistoryState mDetachedHistory;
std::atomic<int> mRunningUpdateStatus{ 0 };
std::atomic<bool> mPendingForcedStatusUpdate{ false };
std::shared_ptr<std::atomic<int>> mRunningAsyncTasks{ std::make_shared<std::atomic<int>>( 0 ) };
@@ -217,6 +265,7 @@ class GitPlugin : public PluginBase {
SyntaxColorScheme scheme;
};
std::optional<CustomTokenizer> mStatusCustomTokenizer;
std::optional<CustomTokenizer> mCommitStatusCustomTokenizer;
std::optional<SyntaxDefinition> mTooltipCustomSyntaxDef;
Uint32 mModelChangedId{ 0 };
Uint32 mModelStylerId{ 0 };
@@ -302,6 +351,8 @@ class GitPlugin : public PluginBase {
void updateStatusBarSync();
void styleCommitFilesStatus( UITextView* status );
void updateUI();
void updateUINow( bool force = false );
@@ -324,7 +375,17 @@ class GitPlugin : public PluginBase {
void openCommitDetails( const Git::Commit& commit );
void loadCommitFiles();
void showGitHistory( const Git::Commit* commit = nullptr );
void focusDetachedHistory();
void openHistoryMenu( const ModelIndex& index );
void openDetachedCommitDetails( const Git::Commit& commit );
std::string detachedHistoryTitle();
void updateDetachedHistoryTitle();
void buildSidePanelTab();