Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-08-16 05:55:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

Prevent a crash when signature parameters are incorrect.

Browse Source 
"About ecode" close with escape (SpartanJ/ecode#873).
This commit is contained in:
Martín Lucas Golini
2026-04-08 15:51:35 -03:00
parent f72b1c2f13
commit 57929621df
5 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/tools/ecode/plugins/autocomplete/autocompleteplugin.cpp
View File

@@ -857,18 +857,24 @@ AutoCompletePlugin::processSignatureHelp( const LSPSignatureHelp& signatureHelp
doc.textInput( initialLabel );
std::vector<String> parameters;
parameters.reserve( sig.parameters.size() );
int skippedSelections = 0;
for ( size_t i = 0; i < sig.parameters.size(); i++ ) {
auto start = String::utf8ToCodepointPosition( sig.label, sig.parameters[i].start );
auto end = String::utf8ToCodepointPosition( sig.label, sig.parameters[i].end );
auto sel = TextRange::convertToLineColumn( initialLabel.view(), start, end );
size_t index = i - skippedSelections;
if ( i == 0 )
if ( i == 0 ) {
doc.setSelection( i, sel );
else
doc.addSelection( sel );
} else {
if ( !doc.addSelection( sel ).isValid() ) {
skippedSelections++;
continue;
}
}
parameters.emplace_back( doc.getSelectedText( i ) );
parameters.emplace_back( doc.getSelectedText( index ) );
}
auto selections( doc.getSelections() );