Mirrors/eepp
1
0
Fork 0
mirror of https://github.com/SpartanJ/eepp.git synced 2026-09-22 13:01:05 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix CSS auto margins for inline HTML images

Browse Source 
Resolve auto margins according to the element's formatting context instead of applying native block centering to every HTML child.
Inline-level replaced elements, inline-blocks, floats, and out-of-flow boxes now use zero-valued auto margins in rich-text measurement and positioning, while normal-flow blocks retain horizontal auto-margin resolution. This prevents asynchronously loaded images from feeding stale calculated margins back into their inline ancestors and producing unbounded document widths, as observed on the Asahi Linux site.
Add synchronous and threaded WebView regression coverage using the Asahi fixture, including its weighted host layout and asynchronous SVG loading.
Document the follow-up plan for explicit formatting-role margin resolution, shared image-content composition, and rebasing UIHTMLImage on UIHTMLWidget.
This commit is contained in:
Martín Lucas Golini
2026-08-02 01:47:38 -03:00
parent eb7398f9ec
commit 2df0861d76
6 changed files with 366 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/tests/unit_tests/uihtml_tests.cpp
View File

@@ -4903,12 +4903,61 @@ UTEST( UIHTML, BlockSizeInfDoesNotHang ) {
sceneNode->update( Seconds( 1 ) );
sceneNode->updateDirtyLayouts();
// If we got here without hanging, the test passes.
auto body = sceneNode->getRoot()->findByTag( "body" );
ASSERT_TRUE( body != nullptr );
auto bodyWidget = body->asType<UIWidget>();
EXPECT_GT( bodyWidget->getPixelsSize().getHeight(), 0.f );
auto* logoNode = sceneNode->getRoot()->findByClass( "logo" );
ASSERT_TRUE( logoNode != nullptr );
auto* logo = logoNode->asType<UIWidget>();
auto* logoLink = logo->getParent()->asType<UIWidget>();
ASSERT_TRUE( logoLink != nullptr );
EXPECT_GT( logoLink->getPixelsSize().getWidth(), 0.f );
EXPECT_NEAR( logoLink->getPixelsSize().getWidth(), logo->getPixelsSize().getWidth(), 1.f );
EXPECT_LT( logoLink->getPixelsSize().getWidth(), 1024.f );
Engine::destroySingleton();
}
UTEST( UIHTML, WebViewAsyncInlineImageAutoMarginsResolveToZero ) {
Engine::instance()->createWindow( WindowSettings( 2048, 1152, "Image Anchor Bounds Test",
WindowStyle::Default, WindowBackend::Default,
32, {}, 1, false, true ),
ContextSettings( false, 0, 0, GLv_default, true, false ) );
FileSystem::changeWorkingDirectory( Sys::getProcessPath() );
auto* win = Engine::instance()->getCurrentWindow();
UISceneNode* sceneNode = init_test_inline_block();
sceneNode->setThreadPool( ThreadPool::createShared( 4 ) );
auto* host = sceneNode->loadLayoutFromString( R"xml(
<vbox layout_width="match_parent" layout_height="match_parent">
<hbox layout_width="match_parent" layout_height="wrap_content">
<TextInput layout_width="0" layout_weight="1" />
</hbox>
<WebView id="webview" layout_width="match_parent" layout_height="0" layout_weight="1" />
</vbox>
)xml" );
auto* webView = host->find( "webview" )->asType<UIWebView>();
webView->loadURI( URI( "./assets/html/block_size_inf.html" ) );
UISceneNode* documentScene = webView->getDocumentSceneNode();
ASSERT_TRUE( documentScene != nullptr );
UIWidget* logo = nullptr;
for ( int i = 0; i < 200; ++i ) {
win->getInput()->update();
SceneManager::instance()->update( Milliseconds( 16 ) );
logo = documentScene->getRoot()->findByClass( "logo" );
Sys::sleep( Milliseconds( 1 ) );
}
ASSERT_TRUE( logo != nullptr );
auto* logoLink = logo->getParent()->asType<UIWidget>();
ASSERT_TRUE( logoLink != nullptr );
EXPECT_GT( logoLink->getPixelsSize().getWidth(), 0.f );
EXPECT_NEAR( logoLink->getPixelsSize().getWidth(), logo->getPixelsSize().getWidth(), 1.f );
EXPECT_LT( logoLink->getPixelsSize().getWidth(), webView->getPixelsSize().getWidth() );
Engine::destroySingleton();
}