From 1d2c258ae77f8f8b73ece3bb2c7436719942acea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mart=C3=ADn=20Lucas=20Golini?= Date: Mon, 7 Apr 2025 21:16:20 -0300 Subject: [PATCH] Make Git plugin less verbose. --- src/tools/ecode/plugins/git/git.cpp | 8 +++----- src/tools/ecode/plugins/git/git.hpp | 5 ----- src/tools/ecode/plugins/git/gitplugin.cpp | 1 - 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/tools/ecode/plugins/git/git.cpp b/src/tools/ecode/plugins/git/git.cpp index 7dc23b082..6aa951a88 100644 --- a/src/tools/ecode/plugins/git/git.cpp +++ b/src/tools/ecode/plugins/git/git.cpp @@ -47,13 +47,11 @@ int Git::git( const std::string& args, const std::string& projectDir, std::strin p.readAllStdOut( buf ); int retCode = 0; p.join( &retCode ); - if ( mLogLevel == LogLevel::Info || - ( mLogLevel >= LogLevel::Warning && retCode != EXIT_SUCCESS ) ) { - Log::instance()->writef( mLogLevel, "GitPlugin cmd in %s (%d): %s %s", + if ( !mSilent || retCode != EXIT_SUCCESS ) { + Log::instance()->writef( retCode != EXIT_SUCCESS ? LogLevel::Info : LogLevel::Debug, + "GitPlugin cmd in %s (%d): %s %s", clock.getElapsedTime().toString(), retCode, mGitPath, args ); } - if ( !mSilent ) - Log::debug( "%s", buf ); return retCode; } diff --git a/src/tools/ecode/plugins/git/git.hpp b/src/tools/ecode/plugins/git/git.hpp index 91b7dbb65..96684474c 100644 --- a/src/tools/ecode/plugins/git/git.hpp +++ b/src/tools/ecode/plugins/git/git.hpp @@ -349,10 +349,6 @@ class Git { GitStatusReport statusFromShortStatusStr( const std::string_view& statusStr ); - void setLogLevel( LogLevel logLevel ) { mLogLevel = logLevel; } - - LogLevel getLogLevel() const { return mLogLevel; } - void setSilent( bool set ) { mSilent = set; } bool isSilent() const { return mSilent; } @@ -370,7 +366,6 @@ class Git { std::string mProjectPath; std::string mGitFolder; std::vector mSubModules; - LogLevel mLogLevel{ LogLevel::Error }; Mutex mSubModulesMutex; bool mSubModulesUpdated{ false }; bool mSilent{ false }; diff --git a/src/tools/ecode/plugins/git/gitplugin.cpp b/src/tools/ecode/plugins/git/gitplugin.cpp index 0c65548a7..bdc66c699 100644 --- a/src/tools/ecode/plugins/git/gitplugin.cpp +++ b/src/tools/ecode/plugins/git/gitplugin.cpp @@ -230,7 +230,6 @@ void GitPlugin::load( PluginManager* pluginManager ) { } mGit = std::make_unique( pluginManager->getWorkspaceFolder() ); - mGit->setLogLevel( Log::instance()->getLogLevelThreshold() ); mGit->setSilent( mSilent ); mGitFound = !mGit->getGitPath().empty(); mProjectPath = mRepoSelected = mGit->getProjectPath();