mirror of
https://github.com/chatmail/core.git
synced 2026-04-19 14:36:29 +03:00
Follow-up for https://github.com/chatmail/core/pull/7042, part of https://github.com/chatmail/core/issues/6884. This will make it possible to create invite-QR codes for broadcast channels, and make them symmetrically end-to-end encrypted. - [x] Go through all the changes in #7042, and check which ones I still need, and revert all other changes - [x] Use the classical Securejoin protocol, rather than the new 2-step protocol - [x] Make the Rust tests pass - [x] Make the Python tests pass - [x] Fix TODOs in the code - [x] Test it, and fix any bugs I find - [x] I found a bug when exporting all profiles at once fails sometimes, though this bug is unrelated to channels: https://github.com/chatmail/core/issues/7281 - [x] Do a self-review (i.e. read all changes, and check if I see some things that should be changed) - [x] Have this PR reviewed and merged - [ ] Open an issue for "TODO: There is a known bug in the securejoin protocol" - [ ] Create an issue that outlines how we can improve the Securejoin protocol in the future (I don't have the time to do this right now, but want to do it sometime in winter) - [ ] Write a guide for UIs how to adapt to the changes (see https://github.com/deltachat/deltachat-android/pull/3886) ## Backwards compatibility This is not very backwards compatible: - Trying to join a symmetrically-encrypted broadcast channel with an old device will fail - If you joined a symmetrically-encrypted broadcast channel with one device, and use an old core on the other device, then the other device will show a mostly empty chat (except for two device messages) - If you created a broadcast channel in the past, then you will get an error message when trying to send into the channel: > The up to now "experimental channels feature" is about to become an officially supported one. By that, privacy will be improved, it will become faster, and less traffic will be consumed. > > As we do not guarantee feature-stability for such experiments, this means, that you will need to create the channel again. > > Here is what to do: > • Create a new channel > • Tap on the channel name > • Tap on "QR Invite Code" > • Have all recipients scan the QR code, or send them the link > > If you have any questions, please send an email to delta@merlinux.eu or ask at https://support.delta.chat/. ## The symmetric encryption Symmetric encryption uses a shared secret. Currently, we use AES128 for encryption everywhere in Delta Chat, so, this is what I'm using for broadcast channels (though it wouldn't be hard to switch to AES256). The secret shared between all members of a broadcast channel has 258 bits of entropy (see `fn create_broadcast_shared_secret` in the code). Since the shared secrets have more entropy than the AES session keys, it's not necessary to have a hard-to-compute string2key algorithm, so, I'm using the string2key algorithm `salted`. This is fast enough that Delta Chat can just try out all known shared secrets. [^1] In order to prevent DOS attacks, Delta Chat will not attempt to decrypt with a string2key algorithm other than `salted` [^2]. ## The "Securejoin" protocol that adds members to the channel after they scanned a QR code This PR uses the classical securejoin protocol, the same that is also used for group and 1:1 invitations. The messages sent back and forth are called `vg-request`, `vg-auth-required`, `vg-request-with-auth`, and `vg-member-added`. I considered using the `vc-` prefix, because from a protocol-POV, the distinction between `vc-` and `vg-` isn't important (as @link2xt pointed out in an in-person discussion), but 1. it would be weird if groups used `vg-` while broadcasts and 1:1 chats used `vc-`, 2. we don't have a `vc-member-added` message yet, so, this would mean one more different kind of message 3. we anyways want to switch to a new securejoin protocol soon, which will be a backwards incompatible change with a transition phase. When we do this change, we can make everything `vc-`. [^1]: In a symmetrically encrypted message, it's not visible which secret was used to encrypt without trying out all secrets. If this does turn out to be too slow in the future, then we can remember which secret was used more recently, and and try the most recent secret first. If this is still too slow, then we can assign a short, non-unique (~2 characters) id to every shared secret, and send it in cleartext. The receiving Delta Chat will then only try out shared secrets with this id. Of course, this would leak a little bit of metadata in cleartext, so, I would like to avoid it. [^2]: A DOS attacker could send a message with a lot of encrypted session keys, all of which use a very hard-to-compute string2key algorithm. Delta Chat would then try to decrypt all of the encrypted session keys with all of the known shared secrets. In order to prevent this, as I said, Delta Chat will not attempt to decrypt with a string2key algorithm other than `salted` BREAKING CHANGE: A new QR type AskJoinBroadcast; cloning a broadcast channel is no longer possible; manually adding a member to a broadcast channel is no longer possible (only by having them scan a QR code)
198 lines
5.8 KiB
Rust
198 lines
5.8 KiB
Rust
//! # List of email headers.
|
|
|
|
use mailparse::{MailHeader, MailHeaderMap};
|
|
|
|
#[derive(Debug, Display, Clone, PartialEq, Eq, IntoStaticStr)]
|
|
#[strum(serialize_all = "kebab_case")]
|
|
#[allow(missing_docs)]
|
|
pub enum HeaderDef {
|
|
MessageId,
|
|
Subject,
|
|
Date,
|
|
From_,
|
|
To,
|
|
AutoSubmitted,
|
|
|
|
/// Carbon copy.
|
|
Cc,
|
|
Disposition,
|
|
|
|
/// Used in the "Body Part Header" of MDNs as of RFC 8098.
|
|
/// Indicates the Message-ID of the message for which the MDN is being issued.
|
|
OriginalMessageId,
|
|
|
|
/// Delta Chat extension for message IDs in combined MDNs
|
|
AdditionalMessageIds,
|
|
|
|
/// Outlook-SMTP-server replace the `Message-ID:`-header
|
|
/// and write the original ID to `X-Microsoft-Original-Message-ID`.
|
|
/// To sort things correctly and to not show outgoing messages twice,
|
|
/// we need to check that header as well.
|
|
XMicrosoftOriginalMessageId,
|
|
|
|
/// Thunderbird header used to store Draft information.
|
|
///
|
|
/// Thunderbird 78.11.0 does not set \Draft flag on messages saved as "Template", but sets this
|
|
/// header, so it can be used to ignore such messages.
|
|
XMozillaDraftInfo,
|
|
|
|
/// Mailing list ID defined in [RFC 2919](https://tools.ietf.org/html/rfc2919).
|
|
ListId,
|
|
ListPost,
|
|
/// Mailing list id, belonging to a broadcast channel created by Delta Chat
|
|
ChatListId,
|
|
|
|
/// List-Help header defined in [RFC 2369](https://datatracker.ietf.org/doc/html/rfc2369).
|
|
ListHelp,
|
|
References,
|
|
|
|
/// In-Reply-To header containing Message-ID of the parent message.
|
|
InReplyTo,
|
|
|
|
/// Used to detect mailing lists if contains "list" value
|
|
/// as described in [RFC 3834](https://tools.ietf.org/html/rfc3834)
|
|
Precedence,
|
|
|
|
ContentType,
|
|
ContentId,
|
|
ChatVersion,
|
|
ChatGroupId,
|
|
ChatGroupName,
|
|
ChatGroupNameChanged,
|
|
ChatGroupNameTimestamp,
|
|
ChatVerified,
|
|
ChatGroupAvatar,
|
|
ChatUserAvatar,
|
|
ChatVoiceMessage,
|
|
ChatGroupMemberRemoved,
|
|
ChatGroupMemberRemovedFpr,
|
|
ChatGroupMemberAdded,
|
|
ChatGroupMemberAddedFpr,
|
|
ChatContent,
|
|
|
|
/// Past members of the group.
|
|
ChatGroupPastMembers,
|
|
|
|
/// Space-separated timestamps of member addition
|
|
/// for members listed in the `To` field
|
|
/// followed by timestamps of member removal
|
|
/// for members listed in the `Chat-Group-Past-Members` field.
|
|
ChatGroupMemberTimestamps,
|
|
|
|
/// Space-separated PGP key fingerprints
|
|
/// of group members listed in the `To` field
|
|
/// followed by fingerprints
|
|
/// of past members listed in the `Chat-Group-Past-Members` field.
|
|
ChatGroupMemberFpr,
|
|
|
|
/// Duration of the attached media file.
|
|
ChatDuration,
|
|
|
|
ChatDispositionNotificationTo,
|
|
ChatWebrtcRoom,
|
|
ChatWebrtcAccepted,
|
|
|
|
/// This message deletes the messages listed in the value by rfc724_mid.
|
|
ChatDelete,
|
|
|
|
/// This message obsoletes the text of the message defined here by rfc724_mid.
|
|
ChatEdit,
|
|
|
|
/// The secret shared amongst all recipients of this broadcast channel,
|
|
/// used to encrypt and decrypt messages.
|
|
/// This secret is sent to a new member in the member-addition message.
|
|
ChatBroadcastSecret,
|
|
|
|
/// [Autocrypt](https://autocrypt.org/) header.
|
|
Autocrypt,
|
|
AutocryptGossip,
|
|
AutocryptSetupMessage,
|
|
SecureJoin,
|
|
|
|
/// Deprecated header containing Group-ID in `vg-request-with-auth` message.
|
|
///
|
|
/// It is not used by Alice as Alice knows the group corresponding to the AUTH token.
|
|
/// Bob still sends it for backwards compatibility.
|
|
SecureJoinGroup,
|
|
SecureJoinFingerprint,
|
|
SecureJoinInvitenumber,
|
|
SecureJoinAuth,
|
|
Sender,
|
|
|
|
/// Ephemeral message timer.
|
|
EphemeralTimer,
|
|
Received,
|
|
|
|
/// A header that includes the results of the DKIM, SPF and DMARC checks.
|
|
/// See <https://datatracker.ietf.org/doc/html/rfc8601>
|
|
AuthenticationResults,
|
|
|
|
/// Node address from iroh where direct addresses have been removed.
|
|
///
|
|
/// The node address sent in this header must have
|
|
/// a non-null relay URL as contacting home relay
|
|
/// is the only way to reach the node without
|
|
/// direct addresses and global discovery.
|
|
IrohNodeAddr,
|
|
|
|
/// Advertised gossip topic for one webxdc.
|
|
IrohGossipTopic,
|
|
|
|
#[cfg(test)]
|
|
TestHeader,
|
|
}
|
|
|
|
impl HeaderDef {
|
|
/// Returns the corresponding header string.
|
|
pub fn get_headername(&self) -> &'static str {
|
|
self.into()
|
|
}
|
|
}
|
|
|
|
#[allow(missing_docs)]
|
|
pub trait HeaderDefMap {
|
|
/// Returns requested header value if it exists.
|
|
fn get_header_value(&self, headerdef: HeaderDef) -> Option<String>;
|
|
|
|
/// Returns requested header if it exists.
|
|
fn get_header(&self, headerdef: HeaderDef) -> Option<&MailHeader<'_>>;
|
|
}
|
|
|
|
impl HeaderDefMap for [MailHeader<'_>] {
|
|
fn get_header_value(&self, headerdef: HeaderDef) -> Option<String> {
|
|
self.get_first_value(headerdef.get_headername())
|
|
}
|
|
fn get_header(&self, headerdef: HeaderDef) -> Option<&MailHeader<'_>> {
|
|
self.get_first_header(headerdef.get_headername())
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
/// Test that kebab_case serialization works as expected
|
|
fn kebab_test() {
|
|
assert_eq!(HeaderDef::From_.get_headername(), "from");
|
|
|
|
assert_eq!(HeaderDef::TestHeader.get_headername(), "test-header");
|
|
}
|
|
|
|
#[test]
|
|
/// Test that headers are parsed case-insensitively
|
|
fn test_get_header_value_case() {
|
|
let (headers, _) =
|
|
mailparse::parse_headers(b"fRoM: Bob\naUtoCryPt-SeTup-MessAge: v99").unwrap();
|
|
assert_eq!(
|
|
headers.get_header_value(HeaderDef::AutocryptSetupMessage),
|
|
Some("v99".to_string())
|
|
);
|
|
assert_eq!(
|
|
headers.get_header_value(HeaderDef::From_),
|
|
Some("Bob".to_string())
|
|
);
|
|
assert_eq!(headers.get_header_value(HeaderDef::Autocrypt), None);
|
|
}
|
|
}
|