mirror of
https://github.com/chatmail/core.git
synced 2026-04-17 21:46:35 +03:00
About the first TODO: I tried this out, but it didn't actually improve things, for two reasons: 1. The trick with `#![cfg_attr(not(test), warn(clippy::indexing_slicing))]` that enables the lint everywhere except for tests doesn't work with workspace-wide lints. (Context: We want to lint against indexing because it might panic, but in a test panicking is fine, so we don't want to enable the lint in tests). 2. Most of our crates have different sets of lints right now, so it would only be very few crates that use the workspace-wide list of lints. About the second TODO: It's not feasible right now to fully parse vCards, and for our good-enough parser the current behavior is fine, I think. If we fail to parse some realworld vCards because of this, we can still improve it.