mirror of
https://github.com/chatmail/core.git
synced 2026-04-17 21:46:35 +03:00
db9bc15d3e
The C API allows passing a NULL pointer is for the callback function. However when calling the callback nothing checks for this null pointer and thus things fail badly. Even worse since the C API is defined using an "fn pointer" rather than a "*-ptr" or raw pointer to the function rust does not realise this can be invalid and therefore the typechecker does not catch this even though there are no unsafe casts. Fix this by making the callback an Option in rust, this can be easily checked when calling. Also add a Context.call_cb() function which simplifies calling the callback, hides the weird syntax due to the function pointer and makes the call a little easier. Finally it also means the option checking is only needed in one place. For the C API this needs to check if this is a NULL pointer or not, this is implicitly done by rust using the "nullable pointer optimisation": https://doc.rust-lang.org/nomicon/ffi.html#the-nullable-pointer-optimization
34 lines
678 B
Bash
Executable File
34 lines
678 B
Bash
Executable File
#!/bin/bash
|
|
|
|
# Small helper to easily run integration tests locally for development
|
|
# purposes. Any arguments are passed straight to tox. E.g. to run
|
|
# only one environment run with:
|
|
#
|
|
# ./run-integration-tests.sh -e py35
|
|
#
|
|
# To also run with `pytest -x` use:
|
|
#
|
|
# ./run-integration-tests.sh -e py35 -- -x
|
|
|
|
export DCC_RS_DEV=$(pwd)
|
|
export DCC_RS_TARGET=${DCC_RS_TARGET:-release}
|
|
|
|
if [ $DCC_RS_TARGET = 'release' ]; then
|
|
cargo build -p deltachat_ffi --release
|
|
else
|
|
cargo build -p deltachat_ffi
|
|
fi
|
|
if [ $? != 0 ]; then
|
|
exit $?
|
|
fi
|
|
|
|
pushd python
|
|
toxargs="$@"
|
|
if [ -e liveconfig ]; then
|
|
toxargs="--liveconfig liveconfig $@"
|
|
fi
|
|
tox $toxargs
|
|
ret=$?
|
|
popd
|
|
exit $ret
|