mirror of
https://github.com/chatmail/core.git
synced 2026-04-18 22:16:30 +03:00
> _greetings from the ice of the deutsche bahn 🚂🚃🚃🚃 always a pleasure to see how well delta chat meanwhile performs in bad networks :)_ this PR adds an API to request other chat members to replace the message text of an already sent message. scope is mainly to fix typos. this feature is known from whatsapp, telegram, signal, and is [requested](https://support.delta.chat/t/retract-edit-sent-messages/1918) [since](https://support.delta.chat/t/edit-messages-in-delta-chat/899) [years](https://github.com/deltachat/deltachat-android/issues/198). technically, a message with an [`Obsoletes:`](https://datatracker.ietf.org/doc/html/rfc2076#section-3.6) header is sent out. ``` From: alice@nine To: bob@nine Message-ID: 2000@nine In-Reply-To: 1000@nine Obsoletes: 1000@nine Edited: this is the new text ``` the body is the new text, prefixed by the static text `Edited:` (which is not a header). the latter is to make the message appear more nicely in Non-Delta-MUA. save for the `In-Reply-To` header. the `Edited:` prefix is removed by Delta Chat on receiving. headers should be protected and moved to e2ee part as usual. corrected message text is flagged, and UI should show this state, in practise as "Edited" beside the date. in case, the original message is not found, nothing happens and the correction message is trashes (assuming the original was deleted). question: is the `Obsoletes:` header a good choice? i _thought_ there is some more specifica RFC, but i cannot find sth. in any case, it should be an header that is not used otherwise by MUA, to make sure no wanted messages disappear. what is NOT done and out of scope: - optimise if messages are not yet sent out. this is doable, but introduces quite some cornercaes and may not be worth the effort - replaces images or other attachments. this is also a bit cornercasy and beyond "typo fixing", and better be handled by "delete for me and others" (which may come soon, having the idea now, it seems easy :) - get edit history in any way. not sure if this is worth the effort, remember, as being a private messenger, we assume trust among chat members. it is also questionable wrt privacy, seized devices etc. - add text where nothing was before; again, scope is "typo fixing", better avoid cornercases - saved messages are not edited (this is anyway questionable) - quoted texts, that are used for the case the original message is deleted, are not updated - edits are ignored when the original message is not there yet (out of order, not yet downloaded) - message status indicator does not show if edits are sent out or not - similar to reactions, webxdc updates, sync messages. signal has the same issue :) still, connectivity should show if there are messages pending <img width="366" alt="Screenshot 2025-02-17 at 17 25 02" src="https://github.com/user-attachments/assets/a4a53996-438b-47ef-9004-2c9062eea5d7" /> corresponding iOS branch (no PR yet): https://github.com/deltachat/deltachat-ios/compare/main...r10s/edit-messages --------- Co-authored-by: l <link2xt@testrun.org>
307 lines
10 KiB
Rust
307 lines
10 KiB
Rust
//! # Constants.
|
|
|
|
#![allow(missing_docs)]
|
|
|
|
use deltachat_derive::{FromSql, ToSql};
|
|
use once_cell::sync::Lazy;
|
|
use percent_encoding::{AsciiSet, NON_ALPHANUMERIC};
|
|
use serde::{Deserialize, Serialize};
|
|
|
|
use crate::chat::ChatId;
|
|
|
|
pub static DC_VERSION_STR: Lazy<String> = Lazy::new(|| env!("CARGO_PKG_VERSION").to_string());
|
|
|
|
/// Set of characters to percent-encode in email addresses and names.
|
|
pub(crate) const NON_ALPHANUMERIC_WITHOUT_DOT: &AsciiSet = &NON_ALPHANUMERIC.remove(b'.');
|
|
|
|
#[derive(
|
|
Debug,
|
|
Default,
|
|
Display,
|
|
Clone,
|
|
Copy,
|
|
PartialEq,
|
|
Eq,
|
|
FromPrimitive,
|
|
ToPrimitive,
|
|
FromSql,
|
|
ToSql,
|
|
Serialize,
|
|
Deserialize,
|
|
)]
|
|
#[repr(i8)]
|
|
pub enum Blocked {
|
|
#[default]
|
|
Not = 0,
|
|
Yes = 1,
|
|
Request = 2,
|
|
}
|
|
|
|
#[derive(
|
|
Debug, Default, Display, Clone, Copy, PartialEq, Eq, FromPrimitive, ToPrimitive, FromSql, ToSql,
|
|
)]
|
|
#[repr(u8)]
|
|
pub enum ShowEmails {
|
|
Off = 0,
|
|
AcceptedContacts = 1,
|
|
#[default] // also change Config.ShowEmails props(default) on changes
|
|
All = 2,
|
|
}
|
|
|
|
#[derive(
|
|
Debug, Default, Display, Clone, Copy, PartialEq, Eq, FromPrimitive, ToPrimitive, FromSql, ToSql,
|
|
)]
|
|
#[repr(u8)]
|
|
pub enum MediaQuality {
|
|
#[default] // also change Config.MediaQuality props(default) on changes
|
|
Balanced = 0,
|
|
Worse = 1,
|
|
}
|
|
|
|
/// Type of the key to generate.
|
|
#[derive(
|
|
Debug, Default, Display, Clone, Copy, PartialEq, Eq, FromPrimitive, ToPrimitive, FromSql, ToSql,
|
|
)]
|
|
#[repr(u8)]
|
|
pub enum KeyGenType {
|
|
#[default]
|
|
Default = 0,
|
|
|
|
/// 2048-bit RSA.
|
|
Rsa2048 = 1,
|
|
|
|
/// [Ed25519](https://ed25519.cr.yp.to/) signature and X25519 encryption.
|
|
Ed25519 = 2,
|
|
|
|
/// 4096-bit RSA.
|
|
Rsa4096 = 3,
|
|
}
|
|
|
|
/// Video chat URL type.
|
|
#[derive(
|
|
Debug, Default, Display, Clone, Copy, PartialEq, Eq, FromPrimitive, ToPrimitive, FromSql, ToSql,
|
|
)]
|
|
#[repr(i8)]
|
|
pub enum VideochatType {
|
|
/// Unknown type.
|
|
#[default]
|
|
Unknown = 0,
|
|
|
|
/// [basicWebRTC](https://github.com/cracker0dks/basicwebrtc) instance.
|
|
BasicWebrtc = 1,
|
|
|
|
/// [Jitsi Meet](https://jitsi.org/jitsi-meet/) instance.
|
|
Jitsi = 2,
|
|
}
|
|
|
|
pub const DC_HANDSHAKE_CONTINUE_NORMAL_PROCESSING: i32 = 0x01;
|
|
pub const DC_HANDSHAKE_STOP_NORMAL_PROCESSING: i32 = 0x02;
|
|
pub const DC_HANDSHAKE_ADD_DELETE_JOB: i32 = 0x04;
|
|
|
|
pub(crate) const DC_FROM_HANDSHAKE: i32 = 0x01;
|
|
|
|
pub const DC_GCL_ARCHIVED_ONLY: usize = 0x01;
|
|
pub const DC_GCL_NO_SPECIALS: usize = 0x02;
|
|
pub const DC_GCL_ADD_ALLDONE_HINT: usize = 0x04;
|
|
pub const DC_GCL_FOR_FORWARDING: usize = 0x08;
|
|
|
|
pub const DC_GCL_VERIFIED_ONLY: u32 = 0x01;
|
|
pub const DC_GCL_ADD_SELF: u32 = 0x02;
|
|
|
|
// unchanged user avatars are resent to the recipients every some days
|
|
pub(crate) const DC_RESEND_USER_AVATAR_DAYS: i64 = 14;
|
|
|
|
// warn about an outdated app after a given number of days.
|
|
// as we use the "provider-db generation date" as reference (that might not be updated very often)
|
|
// and as not all system get speedy updates,
|
|
// do not use too small value that will annoy users checking for nonexistent updates.
|
|
pub(crate) const DC_OUTDATED_WARNING_DAYS: i64 = 365;
|
|
|
|
/// messages that should be deleted get this chat_id; the messages are deleted from the working thread later then. This is also needed as rfc724_mid should be preset as long as the message is not deleted on the server (otherwise it is downloaded again)
|
|
pub const DC_CHAT_ID_TRASH: ChatId = ChatId::new(3);
|
|
/// only an indicator in a chatlist
|
|
pub const DC_CHAT_ID_ARCHIVED_LINK: ChatId = ChatId::new(6);
|
|
/// only an indicator in a chatlist
|
|
pub const DC_CHAT_ID_ALLDONE_HINT: ChatId = ChatId::new(7);
|
|
/// larger chat IDs are "real" chats, their messages are "real" messages.
|
|
pub const DC_CHAT_ID_LAST_SPECIAL: ChatId = ChatId::new(9);
|
|
|
|
/// Chat type.
|
|
#[derive(
|
|
Debug,
|
|
Display,
|
|
Clone,
|
|
Copy,
|
|
PartialEq,
|
|
Eq,
|
|
FromPrimitive,
|
|
ToPrimitive,
|
|
FromSql,
|
|
ToSql,
|
|
IntoStaticStr,
|
|
Serialize,
|
|
Deserialize,
|
|
)]
|
|
#[repr(u32)]
|
|
pub enum Chattype {
|
|
/// 1:1 chat.
|
|
Single = 100,
|
|
|
|
/// Group chat.
|
|
Group = 120,
|
|
|
|
/// Mailing list.
|
|
Mailinglist = 140,
|
|
|
|
/// Broadcast list.
|
|
Broadcast = 160,
|
|
}
|
|
|
|
pub const DC_MSG_ID_DAYMARKER: u32 = 9;
|
|
pub const DC_MSG_ID_LAST_SPECIAL: u32 = 9;
|
|
|
|
/// String that indicates that something is left out or truncated.
|
|
pub(crate) const DC_ELLIPSIS: &str = "[...]";
|
|
// how many lines desktop can display when fullscreen (fullscreen at zoomlevel 1x)
|
|
// (taken from "subjective" testing what looks ok)
|
|
pub const DC_DESIRED_TEXT_LINES: usize = 38;
|
|
// how many chars desktop can display per line (from "subjective" testing)
|
|
pub const DC_DESIRED_TEXT_LINE_LEN: usize = 100;
|
|
|
|
/// Message length limit.
|
|
///
|
|
/// To keep bubbles and chat flow usable and to avoid problems with controls using very long texts,
|
|
/// we limit the text length to `DC_DESIRED_TEXT_LEN`. If the text is longer, the full text can be
|
|
/// retrieved using has_html()/get_html().
|
|
///
|
|
/// Note that for simplicity maximum length is defined as the number of Unicode Scalar Values (Rust
|
|
/// `char`s), not Unicode Grapheme Clusters.
|
|
pub const DC_DESIRED_TEXT_LEN: usize = DC_DESIRED_TEXT_LINE_LEN * DC_DESIRED_TEXT_LINES;
|
|
|
|
// Flags for configuring IMAP and SMTP servers.
|
|
// These flags are optional
|
|
// and may be set together with the username, password etc.
|
|
// via dc_set_config() using the key "server_flags".
|
|
|
|
/// Force OAuth2 authorization.
|
|
///
|
|
/// This flag does not skip automatic configuration.
|
|
/// Before calling configure() with DC_LP_AUTH_OAUTH2 set,
|
|
/// the user has to confirm access at the URL returned by dc_get_oauth2_url().
|
|
pub const DC_LP_AUTH_OAUTH2: i32 = 0x2;
|
|
|
|
/// Force NORMAL authorization, this is the default.
|
|
/// If this flag is set, automatic configuration is skipped.
|
|
pub const DC_LP_AUTH_NORMAL: i32 = 0x4;
|
|
|
|
/// if none of these flags are set, the default is chosen
|
|
pub const DC_LP_AUTH_FLAGS: i32 = DC_LP_AUTH_OAUTH2 | DC_LP_AUTH_NORMAL;
|
|
|
|
/// How many existing messages shall be fetched after configuration.
|
|
pub(crate) const DC_FETCH_EXISTING_MSGS_COUNT: i64 = 100;
|
|
|
|
// max. weight of images to send w/o recoding
|
|
pub const BALANCED_IMAGE_BYTES: usize = 500_000;
|
|
pub const WORSE_IMAGE_BYTES: usize = 130_000;
|
|
|
|
// max. width/height of an avatar
|
|
pub(crate) const BALANCED_AVATAR_SIZE: u32 = 256;
|
|
pub(crate) const WORSE_AVATAR_SIZE: u32 = 128;
|
|
|
|
// max. width/height of images scaled down because of being too huge
|
|
pub const BALANCED_IMAGE_SIZE: u32 = 1280;
|
|
pub const WORSE_IMAGE_SIZE: u32 = 640;
|
|
|
|
// Key for the folder configuration version (see below).
|
|
pub(crate) const DC_FOLDERS_CONFIGURED_KEY: &str = "folders_configured";
|
|
// this value can be increased if the folder configuration is changed and must be redone on next program start
|
|
pub(crate) const DC_FOLDERS_CONFIGURED_VERSION: i32 = 5;
|
|
|
|
// If more recipients are needed in SMTP's `RCPT TO:` header, the recipient list is split into
|
|
// chunks. This does not affect MIME's `To:` header. Can be overwritten by setting
|
|
// `max_smtp_rcpt_to` in the provider db.
|
|
pub(crate) const DEFAULT_MAX_SMTP_RCPT_TO: usize = 50;
|
|
|
|
/// How far the last quota check needs to be in the past to be checked by the background function (in seconds).
|
|
pub(crate) const DC_BACKGROUND_FETCH_QUOTA_CHECK_RATELIMIT: u64 = 12 * 60 * 60; // 12 hours
|
|
|
|
/// How far in the future the sender timestamp of a message is allowed to be, in seconds. Also used
|
|
/// in the group membership consistency algo to reject outdated membership changes.
|
|
pub(crate) const TIMESTAMP_SENT_TOLERANCE: i64 = 60;
|
|
|
|
/// How long a 1:1 chat can't be used for sending while the SecureJoin is in progress. This should
|
|
/// be 10-20 seconds so that we are reasonably sure that the app remains active and receiving also
|
|
/// on mobile devices. See also [`crate::chat::CantSendReason::SecurejoinWait`].
|
|
pub(crate) const SECUREJOIN_WAIT_TIMEOUT: u64 = 15;
|
|
|
|
// To make text edits clearer for Non-Delta-MUA or old Delta Chats, edited text will be prefixed by EDITED_PREFIX.
|
|
// Newer Delta Chats will remove the prefix as needed.
|
|
pub(crate) const EDITED_PREFIX: &str = "✏️";
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use num_traits::FromPrimitive;
|
|
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_chattype_values() {
|
|
// values may be written to disk and must not change
|
|
assert_eq!(Chattype::Single, Chattype::from_i32(100).unwrap());
|
|
assert_eq!(Chattype::Group, Chattype::from_i32(120).unwrap());
|
|
assert_eq!(Chattype::Mailinglist, Chattype::from_i32(140).unwrap());
|
|
assert_eq!(Chattype::Broadcast, Chattype::from_i32(160).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn test_keygentype_values() {
|
|
// values may be written to disk and must not change
|
|
assert_eq!(KeyGenType::Default, KeyGenType::default());
|
|
assert_eq!(KeyGenType::Default, KeyGenType::from_i32(0).unwrap());
|
|
assert_eq!(KeyGenType::Rsa2048, KeyGenType::from_i32(1).unwrap());
|
|
assert_eq!(KeyGenType::Ed25519, KeyGenType::from_i32(2).unwrap());
|
|
assert_eq!(KeyGenType::Rsa4096, KeyGenType::from_i32(3).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn test_showemails_values() {
|
|
// values may be written to disk and must not change
|
|
assert_eq!(ShowEmails::All, ShowEmails::default());
|
|
assert_eq!(ShowEmails::Off, ShowEmails::from_i32(0).unwrap());
|
|
assert_eq!(
|
|
ShowEmails::AcceptedContacts,
|
|
ShowEmails::from_i32(1).unwrap()
|
|
);
|
|
assert_eq!(ShowEmails::All, ShowEmails::from_i32(2).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn test_blocked_values() {
|
|
// values may be written to disk and must not change
|
|
assert_eq!(Blocked::Not, Blocked::default());
|
|
assert_eq!(Blocked::Not, Blocked::from_i32(0).unwrap());
|
|
assert_eq!(Blocked::Yes, Blocked::from_i32(1).unwrap());
|
|
assert_eq!(Blocked::Request, Blocked::from_i32(2).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn test_mediaquality_values() {
|
|
// values may be written to disk and must not change
|
|
assert_eq!(MediaQuality::Balanced, MediaQuality::default());
|
|
assert_eq!(MediaQuality::Balanced, MediaQuality::from_i32(0).unwrap());
|
|
assert_eq!(MediaQuality::Worse, MediaQuality::from_i32(1).unwrap());
|
|
}
|
|
|
|
#[test]
|
|
fn test_videochattype_values() {
|
|
// values may be written to disk and must not change
|
|
assert_eq!(VideochatType::Unknown, VideochatType::default());
|
|
assert_eq!(VideochatType::Unknown, VideochatType::from_i32(0).unwrap());
|
|
assert_eq!(
|
|
VideochatType::BasicWebrtc,
|
|
VideochatType::from_i32(1).unwrap()
|
|
);
|
|
assert_eq!(VideochatType::Jitsi, VideochatType::from_i32(2).unwrap());
|
|
}
|
|
}
|