holger krekel
02b73207f9
fixup this PR with tests, and returning None from get_filemime
2019-09-26 17:12:06 +02:00
jikstra
53b5cbc12a
get_filemime() should return an empty string if no mimetype is present
...
and not default to `applicatopm/octet-stream`
2019-09-26 17:12:06 +02:00
Friedel Ziegelmayer
f4c6decd2d
refactor(mmime): split up into modules ( #609 )
...
refactor(mmime): split up into modules
2019-09-26 15:28:36 +02:00
Floris Bruynooghe
69f1497986
Make dc_get_info() work on a closed context
...
There is very little API guarantees about this, but clients seem to
expect *something* to work on a closed context. So split this up into
static info an more dynamic context-related info, but let's not
provide any guarantees about what keys are available when.
Fixes #599
2019-09-26 14:22:03 +02:00
dignifiedquire
452bce07e1
refactor(mmime): split up into modules
2019-09-26 12:36:23 +02:00
holger krekel
e1dc4b69f5
address all @dignifiedquire review comments
2019-09-25 23:46:44 +02:00
holger krekel
6cd3580263
rustifying dc_continue_key_transfer and fix master-conflict
2019-09-25 23:46:44 +02:00
holger krekel
d5383aecc9
finish dc_imex refactoring, fix linting, rustify some things
2019-09-25 23:46:44 +02:00
holger krekel
71cbbab2c9
fix #596 and some cleanups
2019-09-25 23:46:44 +02:00
holger krekel
8518d8f456
rustify imex and friends
2019-09-25 23:46:44 +02:00
B. Petersen
ea30bb351e
fix boolean error that makes get_setupcodebegin() failing
2019-09-25 20:37:36 +02:00
Alexander Krotov
b93550f6c8
Use DC_MSG_ID_LAST_SPECIAL in dc_continue_key_transfer
2019-09-25 03:29:37 +02:00
Alexander Krotov
60bd053095
Pass setup_code to dc_continue_key_transfer as &str
2019-09-25 03:29:37 +02:00
Alexander Krotov
8165b76001
Make dc_normalize_setup_code safe
2019-09-25 03:29:37 +02:00
jikstra
efc563f5ff
fix test
2019-09-25 01:06:42 +02:00
jikstra
e52acc994c
Make get_draft() return Ok(None) when called for a special chat id
2019-09-25 01:06:42 +02:00
holger krekel
646833d3ec
remove phf crate macro usage: it introduced 7 deps and is really an optimization if you very large (100K+) tables -- we have 10 entries or so and it's called once per message. Let's not introduce crates just because we can -- it increases compile time and in the phf case also introduced a github dependency (for whatever reason -- don't want to know ;)
2019-09-25 00:19:47 +02:00
holger krekel
21c9ff6c85
cargo fmt
2019-09-23 23:13:41 +02:00
holger krekel
4d6b367654
remove ok_to_continue from job
2019-09-23 23:13:41 +02:00
holger krekel
e2fd22a78e
cargo fmt
2019-09-23 21:23:55 +02:00
holger krekel
0759bdde01
cleanup chat.rs: remove ok_to_continue and return result from add_contact methods
2019-09-23 21:23:55 +02:00
holger krekel
faa03e0e14
no functional code change: rename dc_mimefactory to mimefactory and move some functions to become MimeFactory methods
2019-09-23 20:20:34 +02:00
holger krekel
f70897a6d3
rustify new_data_part() and related sanitizations
2019-09-23 18:43:04 +02:00
holger krekel
ba231d2c5f
address @dignifiedquire comments
2019-09-23 17:10:21 +02:00
holger krekel
095cb759ed
avoid cdata_to_free trick and some more cleanups
2019-09-23 17:10:21 +02:00
holger krekel
5cbcb76039
introduce safety and a particular EncryptHelper
2019-09-23 17:10:21 +02:00
holger krekel
3388b42f20
another rustification of encrypt()
2019-09-23 17:10:21 +02:00
holger krekel
e1d541b02e
create wrapmime module and simplify some mailmime code
2019-09-23 17:10:21 +02:00
B. Petersen
321c5e049b
re-add some comments from core-c
2019-09-22 23:39:16 +02:00
holger krekel
ed7cf218f8
address three comments from @dignifiedquire
2019-09-22 23:39:16 +02:00
holger krekel
74d8368525
rustify references, in_reply_to, mimefactory's recipients_{addr,names}
2019-09-22 23:39:16 +02:00
holger krekel
dcbfa272f9
rustify parts of MimeFactory struct
2019-09-22 23:39:16 +02:00
holger krekel
42dd600e0c
more rustifications
2019-09-22 23:39:16 +02:00
holger krekel
9689df601f
streamline mimetype guessing and build_body_file
2019-09-22 23:39:16 +02:00
holger krekel
f6019583b7
better looping on some clists
2019-09-22 23:39:16 +02:00
holger krekel
2d50a3335d
- add mailimf_field_add helper to reduce number of strdup()s
...
- make build_body_text avoid char*
2019-09-22 23:39:16 +02:00
holger krekel
202bfa987d
dc_mimefactory+friends: simplify used strings, convert message_text and message_text2 to String, convert ints to bools
2019-09-22 23:39:16 +02:00
holger krekel
93f9c7cfbd
e2ee_guaranteed -> bool, rustify set_error
2019-09-22 23:39:16 +02:00
Dmitry Bogatov
8f6a0bbf09
Remove unused argument of DC_JOB_CONFIGURE_IMAP
2019-09-22 22:22:00 +02:00
björn petersen
1a47c148e5
Merge pull request #574 from KAction/test-dc_remove_cr
...
Add test for `dc_remove_cr_chars`
2019-09-22 19:47:22 +02:00
Dmitry Bogatov
9ba57a923b
Remove useless argument to quote_word
...
Function "quote_word" accepts display charset argument, but on only call
site it is string constant. Change function to always use "utf-8"
display charset, and remove useless argument.
2019-09-21 22:20:56 +00:00
Dmitry Bogatov
90e2b6f26b
Add test for dc_remove_cr_chars
2019-09-21 21:26:47 +00:00
dignifiedquire
05f9f454c3
refactor: remove x module and delete deadcode
2019-09-21 17:56:49 +02:00
dignifiedquire
e80345a05b
refactor(chat): remove c types and unsafe
2019-09-21 16:59:59 +02:00
dignifiedquire
0bdcc3d616
refactor(message): remove remaining unsafe and c types
2019-09-21 16:37:19 +02:00
dignifiedquire
987f12740e
refactor(message): remove unsafe and c types from the Message api
2019-09-21 16:37:19 +02:00
dignifiedquire
1265016a55
refactor(message): rustiy api
2019-09-21 16:37:19 +02:00
Dmitry Bogatov
43f6db3252
cargo-fmt
2019-09-21 06:19:55 +00:00
Dmitry Bogatov
5b917e7d10
Remove last mutable variable from do_set_draft
2019-09-21 06:19:21 +00:00
Dmitry Bogatov
0523868a88
Avoid ok-to-continue pattern in "do_set_draft" function
...
Note: I strongly suggest reviewing this commit in side-by-side mode.
Note: This commit fails CI due incorrect formatting. It is done
deliberately to simplify review process.
2019-09-21 06:16:15 +00:00
