B. Petersen
da28e1dd44
address comment of @flub and add some tests
2019-10-27 13:32:06 +01:00
B. Petersen
d223a286c0
in summary, show hyphen only if there is a type and a text; this avoids summaries as 'Voice message -'
2019-10-27 13:31:52 +01:00
Alexander Krotov
7916a7fa07
Fix spelling of Param::GuaranteeE2ee
2019-10-27 11:51:59 +01:00
Alexander Krotov
ee81895e1e
Use DC_CONTACT_ID_SELF in do_initiate_key_transfer
2019-10-27 11:51:47 +01:00
Alexander Krotov
6ac4384769
location.rs cleanup
...
Use constants where possible, move "let" closer to assignments.
2019-10-27 11:51:35 +01:00
Alexander Krotov
99fababf0b
to_base64: operate on characters instead of bytes to avoid unsafe code
2019-10-27 11:51:25 +01:00
Alexander Krotov
cfa69cf35a
Add Params::set_cmd and use SystemMessage constants
2019-10-26 14:04:08 +02:00
B. Petersen
dced1932b3
if show_emails=ALL, show belonging contact-requests directly in the chatlist
2019-10-24 11:12:35 +02:00
B. Petersen
79a08f96c5
make ShowEmails an enum, use constant for trash
2019-10-24 11:12:35 +02:00
B. Petersen
df4273e986
fix logic error: adding a member to a group is okay if a real contact exists or for SELF
2019-10-23 14:03:42 +02:00
Floris Bruynooghe
5d79690260
Add Params::get_file(), ::get_path() and ::get_blob()
...
Turns out that anyone that uses these either justs wants a file or
wants a blob. Consolidate those patterns into one place and simplify
all the callers.
2019-10-22 18:54:09 +02:00
Floris Bruynooghe
6c9e16d31a
Introduce a BlobObject type for blobs
...
This creates a specific type for blobs, with well defined conversions
at the borders. It also introduces a strong type for the Param::File
value since that param is often used used by the public API to set
filenames using absolute paths, but then core changes the param to a
blob before it gets to the database.
This eliminates a few more functions with very mallable C-like
arguments behaviour which combine a number of operations in one.
Because blob filenames are stored so often in arbitrary strings this
does add more code when receiving those, until the storage is fixed.
File name sanitisation is now deletated to the sanitize-filename crate
which should do a slightly better job at this.
2019-10-22 18:54:09 +02:00
Alexander Krotov
bed14d5c02
Initialize continue_streaming with false
...
Otherwise this variable is constant.
2019-10-22 13:24:23 +03:00
Alexander Krotov
d3c831a0a2
Replace continue_streaming int with bool
2019-10-22 13:24:23 +03:00
Alexander Krotov
0007c12dea
Replace FORCE_SCHEDULE #define from C core with bool
2019-10-22 13:24:23 +03:00
B. Petersen
049077f13b
reconnect on io errors and broken pipes
2019-10-22 09:58:05 +02:00
holger krekel
e17c69f89c
actually try connecting, instead of just preparing the connect
2019-10-21 23:17:18 +02:00
dignifiedquire
4a2e1897a6
fix(smtp): use correct auth mechanisms
2019-10-20 13:10:17 +02:00
dignifiedquire
076616bfb9
fix(imap): read server greeting
2019-10-20 13:10:17 +02:00
Dmitry Bogatov
a9dd78f622
Narrow return type of location::set: cint -> bool
2019-10-19 22:38:43 +02:00
B. Petersen
d16bdafaf0
simplify calling Simplifier, get is_forwarded flag correctly
2019-10-19 22:34:14 +02:00
B. Petersen
0108b4724e
add function to convert NULL-able c-string to Option<String>
2019-10-19 22:30:25 +02:00
B. Petersen
1908ac428b
mark own forwarded messages as such
2019-10-17 19:41:17 +02:00
Alexander Krotov
9fa6289093
Remove unused strndup
2019-10-17 03:18:08 +03:00
B. Petersen
cde2c9137f
make oauth2.get_addr work
...
oauth2.get_addr is used for gmail-oauth2
to retrieve the address really authorized in the oauth2 process.
2019-10-16 00:57:58 +02:00
björn petersen
120524ae00
Merge pull request #720 from deltachat/make-oauth2-better
...
make oauth2 POST successfully
2019-10-15 18:29:27 +02:00
Dmitry Bogatov
2d0f563dfe
Replace magic constant with symbolic name
2019-10-15 13:45:08 +02:00
B. Petersen
c266d2ca0d
use POST instead GET to init or refresh oauth2 tokens
2019-10-15 00:22:37 +02:00
B. Petersen
85fc696975
more specific and distinguishable oauth2 error message
2019-10-15 00:20:08 +02:00
Alexander Krotov
c4d55f6ba4
auto_outlook: convert <Protocol> type to lowercase before comparison
2019-10-14 19:21:29 +03:00
B. Petersen
766d7cbd3a
add some missing comments
2019-10-14 15:11:33 +02:00
Alexander Krotov
8e0e1bd58d
Add test for Outlook autodiscovery without redirect
2019-10-14 13:42:35 +03:00
Alexander Krotov
a471ccc95a
Test Outlook autoconfigure redirect parsing
2019-10-14 01:24:20 +03:00
Alexander Krotov
daac8c4824
rustfmt
2019-10-14 01:24:20 +03:00
Alexander Krotov
59c22a5626
Move Outlook autodiscovery into separate function
2019-10-14 01:24:19 +03:00
Alexander Krotov
5f7279eb85
auto_mozilla: server is only configured if the type matches
...
This fixes the testcase introduced in previous commit
2019-10-12 17:07:20 +03:00
Alexander Krotov
ce67f593f6
Add XML parsing test for Mozilla autoconfig
2019-10-12 17:07:20 +03:00
Alexander Krotov
556ea57f37
auto_mozilla: split XML parsing into separate function
2019-10-12 17:07:20 +03:00
Dmitry Bogatov
a4257b619a
Replace flags argument to Sql.open with single bool
...
Previously, "flags" argument of Sql.open was of type libc::c_int, but
only one bit was used: whether to open database read-only. This commit
makes it explicit by changing type to bool and renaming argument.
2019-10-12 09:56:18 +02:00
Alexander Krotov
8479c8afbf
Do not convert 1 to libc::c_int
...
It is compared to u32 in this case
2019-10-11 21:52:47 +02:00
Alexander Krotov
eba012b965
Do not use libc::c_int in Simplify
2019-10-11 21:52:47 +02:00
Alexander Krotov
66e53e6804
Return bool from Imap::fetch()
...
It is unused anyway
2019-10-11 21:52:47 +02:00
Alexander Krotov
c8aa8b55f6
Use i32 instead of libc::c_int for try_again
...
It is already declared as i32 in the structure
2019-10-11 21:52:47 +02:00
Alexander Krotov
900e3905c0
Count number of libc references in top_evil_rs.py
2019-10-11 21:52:47 +02:00
holger krekel
4e36b35039
cargo-fmt only
2019-10-10 12:01:01 +02:00
holger krekel
d412ee6042
make dc_str_from_clist safe and return a string instead of c-string -- this allows to remove some unsafe and now unneccessary cleanup code
2019-10-10 12:01:01 +02:00
dignifiedquire
46e8a436cb
updates and fixes
2019-10-10 00:23:36 +02:00
dignifiedquire
dc2cf8ecfc
unify naming in pgp
2019-10-10 00:23:36 +02:00
dignifiedquire
fd69ebfd1f
fix and cleanup tests
2019-10-10 00:23:36 +02:00
dignifiedquire
03979fdc51
wip
2019-10-10 00:23:36 +02:00
