Alexander Krotov
51a804a80f
location: use "bool" for "independent" argument
2019-11-06 14:17:59 +03:00
B. Petersen
67e2e4d415
target comment of @hpk42
2019-11-04 13:20:35 +01:00
B. Petersen
8c2efa707a
name special contact-ids where easily possible
...
the point of this pr is to get an overview
how and where DC_CONTACT_ID_DEVICE is used,
to prepare introducing a device-"chat".
i did not change the sql statements for now
as this would require some more refactoring
and has the potential to introduce bugs.
2019-11-04 13:20:35 +01:00
B. Petersen
70cef68eeb
display failed messages
2019-11-03 01:19:29 +01:00
holger krekel
c5f64d2988
address @link2xt comments
2019-11-03 00:21:27 +01:00
holger krekel
d24a982757
fix various location-streaming issue, test passes now
2019-11-03 00:21:27 +01:00
B. Petersen
e4b3e23769
prefer to_string_lossy() over as_str() as the latter pancis on non-wellformatted utf-8
2019-11-01 00:46:48 +01:00
Floris Bruynooghe
c8d296ea0e
A MsgId newtype
...
This more strongly types the ubiquitous message id type by no longer
making it an integer. It keeps the actual ID opaque. Only for the
generic job API the number keeps being used. Some locations also need
to create it from an integer and call MsgId::new().
2019-10-29 15:30:53 +01:00
B. Petersen
dced1932b3
if show_emails=ALL, show belonging contact-requests directly in the chatlist
2019-10-24 11:12:35 +02:00
B. Petersen
79a08f96c5
make ShowEmails an enum, use constant for trash
2019-10-24 11:12:35 +02:00
Floris Bruynooghe
5d79690260
Add Params::get_file(), ::get_path() and ::get_blob()
...
Turns out that anyone that uses these either justs wants a file or
wants a blob. Consolidate those patterns into one place and simplify
all the callers.
2019-10-22 18:54:09 +02:00
Floris Bruynooghe
6c9e16d31a
Introduce a BlobObject type for blobs
...
This creates a specific type for blobs, with well defined conversions
at the borders. It also introduces a strong type for the Param::File
value since that param is often used used by the public API to set
filenames using absolute paths, but then core changes the param to a
blob before it gets to the database.
This eliminates a few more functions with very mallable C-like
arguments behaviour which combine a number of operations in one.
Because blob filenames are stored so often in arbitrary strings this
does add more code when receiving those, until the storage is fixed.
File name sanitisation is now deletated to the sanitize-filename crate
which should do a slightly better job at this.
2019-10-22 18:54:09 +02:00
holger krekel
4e36b35039
cargo-fmt only
2019-10-10 12:01:01 +02:00
holger krekel
d412ee6042
make dc_str_from_clist safe and return a string instead of c-string -- this allows to remove some unsafe and now unneccessary cleanup code
2019-10-10 12:01:01 +02:00
B. Petersen
dd8744b74e
remove unused import
2019-10-07 01:15:42 +02:00
B. Petersen
710db2ba0a
remove scanning for old Chat-Predecessor header
...
the Chat-Predecessor header was dropped about 10 month ago.
as a replacement, the standard headers are used.
2019-10-07 00:43:43 +02:00
B. Petersen
275f5d713f
cargo fmt
2019-10-05 22:47:39 +02:00
B. Petersen
275b4b8d36
bubble up sql-errors in reveive_imf()
2019-10-05 22:47:39 +02:00
B. Petersen
77cef632c7
bubble up update_param() error
...
bubble up the error instead of ignoring it -
but also do not panic as before #673
2019-10-05 22:47:39 +02:00
björn petersen
2fe98775f9
Merge pull request #673 from deltachat/dont-panic
...
Don't Panic!
2019-10-05 15:08:15 +02:00
B. Petersen
735bdd1c20
always use to_string_lossy() for converting c-strings to String
...
the function to_string() is removed;
c-strings may always be badly formatted and this should never lead to a panic.
2019-10-05 00:12:32 +02:00
B. Petersen
9cae075b6f
target detailed checks of @flub
2019-10-04 23:07:34 +02:00
B. Petersen
477af413c6
if in doubt, prefer unwrap_or_default()
...
if the past we had lots of crashes because of unexpected unwrap failures,
mostly related to string.
this commit avoids them eg. for string-conversions that may panic
eg. when encountering a null-byte or by logical programming errors
where an object is assumed to be set but is not under unexpected circumstances.
2019-10-04 23:07:33 +02:00
B. Petersen
79b92727cc
prefer get_config_bool() where appropriate
...
for db input/output, we still use get_config_int() to convert to/from 0/1.
also for info() we prefer get_config_int() to show the real value.
2019-10-04 11:15:11 +02:00
B. Petersen
c6b2d640ae
prefer context.get_config() over context.sql.get_config() as the latter does not handle default values.
2019-10-03 17:15:40 +02:00
Alexander Krotov
130d485cac
Fix some clippy warnings
2019-10-03 14:30:40 +02:00
holger krekel
d83aa1e898
perform heuristic moves only if a job is not delete
2019-10-02 23:51:14 +02:00
holger krekel
f0a7bdb6d6
properly parse message ids in imap prefetch
2019-10-02 23:51:14 +02:00
holger krekel
5c1b9c83f7
fixes #661 and also contains a cleanup of config access (only for e2ee and mdns)
2019-10-02 22:51:09 +02:00
holger krekel
ee6d16f1b1
on some call sites: peerstate.save_to_db() should bubble up errors instead of crashing.
...
also write a test that double-creation of an addr-row is fine.
2019-10-01 10:34:36 +02:00
holger krekel
ab2ef1e1e4
shift most mmime functions to wrapmime
2019-09-30 00:52:14 +02:00
Dmitry Bogatov
0beadde758
Remove _safe suffix from dc_decode_header function
...
There is no longer unsafe version of this function, so suffix is
useless now.
2019-09-28 23:18:41 +02:00
Dmitry Bogatov
618abd63cf
Drop unsafe version of dc_decode_header_words
...
Replace all call sites with safe version and adjust tests as apporiate.
2019-09-28 23:18:41 +02:00
Friedel Ziegelmayer
34b3ddf63b
refactor(e2ee): reduce unsafe spread
2019-09-28 13:20:33 -06:00
holger krekel
f28a971b96
several fixes and streamlinings, probably verified-group encryption is fixed, or at least we should see better errors
2019-09-27 23:24:57 +02:00
holger krekel
18808d0a61
majorly rustify and simplify the incoming decryption pipeline
2019-09-27 23:24:57 +02:00
Alexander Krotov
3933353b5f
Pass slice to dc_receive_imf
...
instead of pointer and length
2019-09-27 17:53:41 +03:00
dignifiedquire
452bce07e1
refactor(mmime): split up into modules
2019-09-26 12:36:23 +02:00
holger krekel
5cbcb76039
introduce safety and a particular EncryptHelper
2019-09-23 17:10:21 +02:00
dignifiedquire
05f9f454c3
refactor: remove x module and delete deadcode
2019-09-21 17:56:49 +02:00
dignifiedquire
e80345a05b
refactor(chat): remove c types and unsafe
2019-09-21 16:59:59 +02:00
dignifiedquire
0bdcc3d616
refactor(message): remove remaining unsafe and c types
2019-09-21 16:37:19 +02:00
dignifiedquire
1265016a55
refactor(message): rustiy api
2019-09-21 16:37:19 +02:00
dignifiedquire
266b205c75
refactor: rustify interface of maimlime_transfer_decode
2019-09-21 00:51:36 +02:00
dignifiedquire
0bdcc4269f
refactor(mimeparser): split and cleanup parse_mime_recursive
2019-09-20 21:42:23 +02:00
holger krekel
7263c9490d
refactor rfc724_mid parsing and creation to avoid char*, add tests
2019-09-19 20:03:16 +02:00
holger krekel
0c88bc6ac7
more rfc724_mid cleanup
2019-09-19 20:03:16 +02:00
holger krekel
dc8a2f54e5
use utf8 lossy strings for saved mime headers (as discussed on PR and IRC with @r10s)
2019-09-18 16:47:04 +02:00
dignifiedquire
b3bc5b2520
fix(receive_imf): do not attempt to convert raw body to utf8
2019-09-18 16:47:04 +02:00
holger krekel
2b038a34c9
Merge branch 'master' into refactor/remove-mprintf
2019-09-17 15:46:05 +02:00
