B. Petersen
e1df41c209
fix tests
2019-11-03 01:19:29 +01:00
B. Petersen
70cef68eeb
display failed messages
2019-11-03 01:19:29 +01:00
holger krekel
4eb068613d
extend and fix python/test side of location streaming
2019-11-03 00:21:27 +01:00
holger krekel
d774430ec2
simplify location parsing
2019-11-03 00:21:27 +01:00
holger krekel
d24a982757
fix various location-streaming issue, test passes now
2019-11-03 00:21:27 +01:00
B. Petersen
832df41130
target comments of @hpk42 and @flub
2019-11-01 00:46:48 +01:00
B. Petersen
858baf0c2c
prefer to_opt_string_lossy() over as_opt_str() as the latter pancis on non-wellformatted utf-8, delete as_opt_str()
2019-11-01 00:46:48 +01:00
B. Petersen
e4b3e23769
prefer to_string_lossy() over as_str() as the latter pancis on non-wellformatted utf-8
2019-11-01 00:46:48 +01:00
Alexander Krotov
7916a7fa07
Fix spelling of Param::GuaranteeE2ee
2019-10-27 11:51:59 +01:00
Floris Bruynooghe
6c9e16d31a
Introduce a BlobObject type for blobs
...
This creates a specific type for blobs, with well defined conversions
at the borders. It also introduces a strong type for the Param::File
value since that param is often used used by the public API to set
filenames using absolute paths, but then core changes the param to a
blob before it gets to the database.
This eliminates a few more functions with very mallable C-like
arguments behaviour which combine a number of operations in one.
Because blob filenames are stored so often in arbitrary strings this
does add more code when receiving those, until the storage is fixed.
File name sanitisation is now deletated to the sanitize-filename crate
which should do a slightly better job at this.
2019-10-22 18:54:09 +02:00
B. Petersen
d16bdafaf0
simplify calling Simplifier, get is_forwarded flag correctly
2019-10-19 22:34:14 +02:00
holger krekel
3f053f899e
cargo fmt
2019-10-07 00:15:39 +02:00
holger krekel
22b4d1734c
remove last ok_to_continue in mimeparser
2019-10-07 00:15:39 +02:00
B. Petersen
db2064de14
use .to_string_lossy() member of Path, CStr etc.
...
instead of calling to_str().unwrap_or_default().
2019-10-05 22:46:29 +02:00
björn petersen
2fe98775f9
Merge pull request #673 from deltachat/dont-panic
...
Don't Panic!
2019-10-05 15:08:15 +02:00
B. Petersen
735bdd1c20
always use to_string_lossy() for converting c-strings to String
...
the function to_string() is removed;
c-strings may always be badly formatted and this should never lead to a panic.
2019-10-05 00:12:32 +02:00
B. Petersen
2317518e5e
cargo fmt
2019-10-04 23:07:34 +02:00
B. Petersen
477af413c6
if in doubt, prefer unwrap_or_default()
...
if the past we had lots of crashes because of unexpected unwrap failures,
mostly related to string.
this commit avoids them eg. for string-conversions that may panic
eg. when encountering a null-byte or by logical programming errors
where an object is assumed to be set but is not under unexpected circumstances.
2019-10-04 23:07:33 +02:00
Alexander Krotov
130d485cac
Fix some clippy warnings
2019-10-03 14:30:40 +02:00
björn petersen
c376de9b5e
add sticker type ( #653 )
...
* add sticker type
this pr adds the message type 'sticker'.
stickers are handled as normal images
but tagged with the header `Chat-Content: sticker`
it's up to the ui to render these stickers appropriate.
* cargo fmt
2019-09-30 20:55:27 +02:00
holger krekel
ab2ef1e1e4
shift most mmime functions to wrapmime
2019-09-30 00:52:14 +02:00
holger krekel
18030fa61e
remove duplicate code and possibly a leak
2019-09-30 00:52:14 +02:00
holger krekel
064337b5d3
refactor one occassion of determinig transfer encoding
2019-09-30 00:52:14 +02:00
holger krekel
7a9fdb4acd
add a new tested context.new_blob_dir method to simplify writing out blob files
2019-09-29 22:49:01 +02:00
Dmitry Bogatov
0beadde758
Remove _safe suffix from dc_decode_header function
...
There is no longer unsafe version of this function, so suffix is
useless now.
2019-09-28 23:18:41 +02:00
Friedel Ziegelmayer
34b3ddf63b
refactor(e2ee): reduce unsafe spread
2019-09-28 13:20:33 -06:00
holger krekel
f28a971b96
several fixes and streamlinings, probably verified-group encryption is fixed, or at least we should see better errors
2019-09-27 23:24:57 +02:00
holger krekel
18808d0a61
majorly rustify and simplify the incoming decryption pipeline
2019-09-27 23:24:57 +02:00
dignifiedquire
452bce07e1
refactor(mmime): split up into modules
2019-09-26 12:36:23 +02:00
dignifiedquire
05f9f454c3
refactor: remove x module and delete deadcode
2019-09-21 17:56:49 +02:00
dignifiedquire
1969ee02a5
refactor(mimeparser): rustify mailmime_get_type
2019-09-21 00:51:36 +02:00
dignifiedquire
266b205c75
refactor: rustify interface of maimlime_transfer_decode
2019-09-21 00:51:36 +02:00
holger krekel
4b45be7cda
cargo fmt only
2019-09-20 22:43:20 +02:00
holger krekel
497ffd86fa
make logic and comments more like C (early returns instead of nestedness)
...
next commit: cargo fmt
2019-09-20 22:43:20 +02:00
dignifiedquire
0bdcc4269f
refactor(mimeparser): split and cleanup parse_mime_recursive
2019-09-20 21:42:23 +02:00
holger krekel
fd8d16a7db
replace weird pointer-loops with nice for-loops (thanks @dignifiedquire for guiding)
2019-09-20 17:52:07 +02:00
holger krekel
f3ac9306f3
use bool instead of int
2019-09-20 17:52:07 +02:00
holger krekel
59740d0b56
remove unused var, numbers to const-names
2019-09-20 17:52:07 +02:00
holger krekel
7943b708d2
dc_mimeparser: do a round of renames on numbers to constants and add comments from the C code
2019-09-20 15:23:34 +02:00
holger krekel
711bc69750
address @dignifiedquire comment
2019-09-19 20:03:16 +02:00
holger krekel
7263c9490d
refactor rfc724_mid parsing and creation to avoid char*, add tests
2019-09-19 20:03:16 +02:00
holger krekel
3bd36feede
fix broken rust mimeparser fuzzy tests
2019-09-18 14:15:16 +02:00
Dmitry Bogatov
a773b7929c
Add fuzzy-test for dc_mimeparser_parser
2019-09-18 07:33:22 +02:00
Dmitry Bogatov
7b73103133
Add test for mime parsing reportedly crash-inducing message
2019-09-18 07:33:22 +02:00
holger krekel
2b038a34c9
Merge branch 'master' into refactor/remove-mprintf
2019-09-17 15:46:05 +02:00
dignifiedquire
e710836276
cleanup and fix earlier introduced scoping error
2019-09-16 22:58:10 +02:00
dignifiedquire
6be3c9a48a
refactor: improve mime field lookup
2019-09-16 22:58:10 +02:00
dignifiedquire
c0747bf68d
refactor: use enum for system messages
2019-09-16 22:58:10 +02:00
dignifiedquire
0346dd15d9
refactor(mimeparser): some more sanity
2019-09-16 22:58:10 +02:00
dignifiedquire
9534a9ad30
refactor(mimeparser): remove dc_mprintf
2019-09-16 07:59:41 +02:00
