B. Petersen
37ecfa6b67
fix gm2local offset calculations
2019-11-09 20:26:00 +01:00
B. Petersen
99ba2fb358
let dc_timestamp_to_str() print the local time, not UTC times. the function is used for outputs directly shown to the user, eg. dc_get_msg_info()
2019-11-09 20:26:00 +01:00
holger krekel
6b18cbda1f
refine dc_copy along the lines @flub did for blobstore
2019-11-06 13:26:32 +01:00
holger krekel
cb00f5da79
fix #786 by always succeeding to create a canonical deterministic message-id -- thanks @csb0730 for the analysis of the issue
2019-11-03 01:28:45 +01:00
B. Petersen
5709681076
streamline as_path_unicode(), delete unused as_str() and as_str_safe()
2019-11-01 00:46:48 +01:00
B. Petersen
858baf0c2c
prefer to_opt_string_lossy() over as_opt_str() as the latter pancis on non-wellformatted utf-8, delete as_opt_str()
2019-11-01 00:46:48 +01:00
B. Petersen
e4b3e23769
prefer to_string_lossy() over as_str() as the latter pancis on non-wellformatted utf-8
2019-11-01 00:46:48 +01:00
holger krekel
75ba040531
more error logging with file operations in general
2019-10-31 23:31:09 +01:00
Floris Bruynooghe
faa78e1c04
At least log the error
2019-10-31 22:38:32 +01:00
Floris Bruynooghe
6c9e16d31a
Introduce a BlobObject type for blobs
...
This creates a specific type for blobs, with well defined conversions
at the borders. It also introduces a strong type for the Param::File
value since that param is often used used by the public API to set
filenames using absolute paths, but then core changes the param to a
blob before it gets to the database.
This eliminates a few more functions with very mallable C-like
arguments behaviour which combine a number of operations in one.
Because blob filenames are stored so often in arbitrary strings this
does add more code when receiving those, until the storage is fixed.
File name sanitisation is now deletated to the sanitize-filename crate
which should do a slightly better job at this.
2019-10-22 18:54:09 +02:00
B. Petersen
0108b4724e
add function to convert NULL-able c-string to Option<String>
2019-10-19 22:30:25 +02:00
Alexander Krotov
9fa6289093
Remove unused strndup
2019-10-17 03:18:08 +03:00
holger krekel
d412ee6042
make dc_str_from_clist safe and return a string instead of c-string -- this allows to remove some unsafe and now unneccessary cleanup code
2019-10-10 12:01:01 +02:00
dignifiedquire
fd69ebfd1f
fix and cleanup tests
2019-10-10 00:23:36 +02:00
dignifiedquire
03979fdc51
wip
2019-10-10 00:23:36 +02:00
Alexander Krotov
e4cca92910
Simplify to_string_lossy()
...
Call .to_string_lossy() without trying .to_str() first.
2019-10-09 08:56:02 +02:00
Alexander Krotov
b4851187ba
Safe outlk_autodiscover
2019-10-06 05:46:45 +03:00
B. Petersen
1802d7658d
add some tests for dc_create_outgoing_rfc724_mid()
...
as noticed in the last attempts to change the prefix,
this test is missing (as probably many more :)
2019-10-05 22:48:00 +02:00
björn petersen
2fe98775f9
Merge pull request #673 from deltachat/dont-panic
...
Don't Panic!
2019-10-05 15:08:15 +02:00
B. Petersen
735bdd1c20
always use to_string_lossy() for converting c-strings to String
...
the function to_string() is removed;
c-strings may always be badly formatted and this should never lead to a panic.
2019-10-05 00:12:32 +02:00
B. Petersen
9cae075b6f
target detailed checks of @flub
2019-10-04 23:07:34 +02:00
B. Petersen
2317518e5e
cargo fmt
2019-10-04 23:07:34 +02:00
B. Petersen
477af413c6
if in doubt, prefer unwrap_or_default()
...
if the past we had lots of crashes because of unexpected unwrap failures,
mostly related to string.
this commit avoids them eg. for string-conversions that may panic
eg. when encountering a null-byte or by logical programming errors
where an object is assumed to be set but is not under unexpected circumstances.
2019-10-04 23:07:33 +02:00
holger krekel
603761e4b7
add DC_EVENT_DELETED_BLOB_FILE
2019-10-03 18:01:56 +02:00
Alexander Krotov
130d485cac
Fix some clippy warnings
2019-10-03 14:30:40 +02:00
holger krekel
d72e9bb05b
remove dc_get_fine_* method and validate_filename
2019-09-29 22:49:01 +02:00
holger krekel
7a9fdb4acd
add a new tested context.new_blob_dir method to simplify writing out blob files
2019-09-29 22:49:01 +02:00
Friedel Ziegelmayer
34b3ddf63b
refactor(e2ee): reduce unsafe spread
2019-09-28 13:20:33 -06:00
B. Petersen
b73d6377fc
do not truncate messages in contact requests
...
core-c has truncated messages in the contact requests.
this is questionable in general, as
- all messages, including contact requests,
are already truncated, unquoted, simplified etc.
- the ui should be capable of showing the full text anyway
(when the contact request is accepted, the whole messase is shown)
- also, all current ui show the contact requests by name only in the
chatlist; the user often does not even come to the contact request view.
- if the ui wants to show the contact request is a special way,
it is probably better to leave this truncation up to the ui
2019-09-27 02:55:23 +02:00
dignifiedquire
452bce07e1
refactor(mmime): split up into modules
2019-09-26 12:36:23 +02:00
holger krekel
e1dc4b69f5
address all @dignifiedquire review comments
2019-09-25 23:46:44 +02:00
holger krekel
8518d8f456
rustify imex and friends
2019-09-25 23:46:44 +02:00
holger krekel
74d8368525
rustify references, in_reply_to, mimefactory's recipients_{addr,names}
2019-09-22 23:39:16 +02:00
holger krekel
dcbfa272f9
rustify parts of MimeFactory struct
2019-09-22 23:39:16 +02:00
holger krekel
9689df601f
streamline mimetype guessing and build_body_file
2019-09-22 23:39:16 +02:00
Dmitry Bogatov
90e2b6f26b
Add test for dc_remove_cr_chars
2019-09-21 21:26:47 +00:00
dignifiedquire
05f9f454c3
refactor: remove x module and delete deadcode
2019-09-21 17:56:49 +02:00
dignifiedquire
e80345a05b
refactor(chat): remove c types and unsafe
2019-09-21 16:59:59 +02:00
holger krekel
4b45be7cda
cargo fmt only
2019-09-20 22:43:20 +02:00
holger krekel
497ffd86fa
make logic and comments more like C (early returns instead of nestedness)
...
next commit: cargo fmt
2019-09-20 22:43:20 +02:00
Floris Bruynooghe
5001a0e37d
Fix dc_make_rel_path
...
This was not substituting $BLOBDIR correctly.
2019-09-20 18:38:39 +02:00
holger krekel
7263c9490d
refactor rfc724_mid parsing and creation to avoid char*, add tests
2019-09-19 20:03:16 +02:00
holger krekel
14bdf7fae8
make dc_create_outgoing_rfc724_mid safe and simplify call sites
2019-09-19 20:03:16 +02:00
dignifiedquire
84bf1ec6e7
refactor(tools): no more dc_mprintf
2019-09-16 07:58:08 +02:00
dignifiedquire
f31f341a50
feat: enforce Debug implementations and remove mod types
2019-09-15 16:36:31 +02:00
dignifiedquire
de1e3e1d4f
refactor(context): remove last unsafe bits from the context struct
2019-09-15 16:36:31 +02:00
Dmitry Bogatov
f198ce29b1
Drop unsafe version of dc_get_abs_path
2019-09-12 04:11:43 +00:00
B. Petersen
177ab0229a
do not call fs::remove_dir_all() implicitly on non-files; deleting folders is not needed and calling remove_dir_all() is considered harmful
2019-09-11 17:02:27 +02:00
Dmitry Bogatov
57daa0f7f0
Remove useless argument of logging macros
...
Previously, logging macros (info! warn! error!) accepted integer
argument (data1), that was passed to callback function verbatim. In all
call sites this argument was 0.
With this change, that data1 argument is no longer part of macro
interface, 0 is always passed to callback in internals of these macros.
2019-09-10 22:26:47 +00:00
dignifiedquire
8e3cc192a5
fix(tools): make sure dc_truncate can handle arbitrary utf8 values
...
also adds proptests to make sure this is upheld
Should close #433
2019-09-08 14:00:04 +02:00
