Hocuri
1c436777e0
Fix #2429 (message was downloaded multiple times a second), add test ( #2430 )
...
The problem was:
If a message has the \Deleted flag set, we ignore it. But we forgot to
update last_uid, so that uid_next was not updated at 47e639b777/src/imap.rs (L730)Fix #2429
2021-05-09 18:43:55 +02:00
link2xt
adac903818
Debloat the binary by using less AsRef arguments
...
Using `impl AsRef<str>` as the argument instead of `&str` makes it
possible to call the function with `&str`, `String` and other types
that implement `AsRef` trait.
The cost of it is that compiled binary contains mulitple versions of
the same function, one for each variant of types. If function contains
multiple generic `impl AsRef` arguments, the number of versions possibly
compiled into binary grows exponentially with the number of arguments.
Simple way to avoid it is to call `.as_ref()` on the caller side to
convert the argument to `&str`. In most cases even adding a `&` and
relying on `Deref` coercion is sufficient.
This patch changes many functions that accepted `impl AsRef<str>` and
`impl AsRef<Path>` to accept `&str` and `&Path` instead.
In some places `.clone()` calls are removed. Calling `.clone()` on
`String` and passing `String` to a function accepting `impl
AsRef<str>` is completely unnecessary as `&str` reference could be
passed instead. There is no clippy warning against it yet, but
changing argument type to `&str` allowed to find these cases.
The result of debloating is not impressive, several hundred kilobytes
are saved, which is about 3% of the `.so` binary, but the code is
cleaner too.
2021-05-09 16:25:11 +03:00
link2xt
8610b0c945
sql: switch from sqlx to rusqlite
2021-04-25 22:33:14 +03:00
link2xt
d179dced4e
Get rid of mod.rs files.
...
Since Rust 2018 [1] it is no longer required to move module code to
`mod.rs` when submodules are added. This eliminates common problem of
having multiple buffers named `mod.rs` in editor.
[1] https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html#no-more-modrs
2021-04-23 22:45:45 +03:00
Alexander Krotov
49b9b28c99
Move select_folder to a separate submodule
2019-12-04 06:13:24 +01:00
Alexander Krotov
ad87b7c4a5
Fix clippy warnings
2019-12-03 20:20:52 +03:00
dignifiedquire
dbd6303829
remove mmime
2019-12-03 12:22:55 +01:00
dignifiedquire
eb02100d68
fix(imap): merge error conversions properly
2019-12-01 21:40:56 +01:00
holger krekel
ea8adf39c2
address @link2xt comment
2019-12-01 20:50:31 +01:00
holger krekel
f7f61e0f85
move imap errors into imap module
2019-12-01 20:50:31 +01:00
holger krekel
2423d197cd
better logging, changed timeout
2019-12-01 18:12:10 +01:00
holger krekel
2582791501
address #925 heuristically
2019-12-01 18:12:10 +01:00
holger krekel
603d55114b
address @link2xt error comment
2019-11-30 23:53:35 +01:00
holger krekel
9d18db9cae
introduce a select_with_uidvalidity function that helps us during configuration to know about last_seen_uid
2019-11-30 23:53:35 +01:00
holger krekel
d14c6ea202
refine uid_next handling and rename and resultify configure_folder to ensure_configurer_folders
2019-11-30 23:53:35 +01:00
holger krekel
7be5fe925a
revert logic to get last_seen_uid
2019-11-30 23:53:35 +01:00
holger krekel
8f43d7fa34
remove commented errors and fix fmt
2019-11-30 23:53:35 +01:00
holger krekel
b6e9bcee3c
when first looking at a folder, look at "uid_next" as returned from server
...
and otherwise properly fetch the last messages to determine the last seen uid.
also add some tracing.
2019-11-30 23:53:35 +01:00
holger krekel
2dbef704e9
rework select_folder error handling (thanks @flub and @link2xt for helping along)
2019-11-30 23:53:35 +01:00
Alexander Krotov
430d4e5f6e
Replace DC_CREATE_MVBOX with boolean
2019-11-28 18:24:29 +01:00
holger krekel
6f6791c1b5
(flub/r10s/hpk42) remove MoveState and related functions because we don't actually need it anymore
2019-11-28 15:57:26 +01:00
B. Petersen
de228bdb4b
also move messages sent to ourselves via bcc_self to the DeltaChat folder (other messages are moved in receive_imf())
2019-11-28 15:57:26 +01:00
holger krekel
618d74cd67
safer interruptability of fake-idle -- reusing the same skip_next_idle pattern as with idle
2019-11-27 05:52:14 +01:00
Floris Bruynooghe
fc1a136448
Remove unused (async)Arc
...
This identical naming of sync and async arcs is not confusing at all
btw.
2019-11-27 05:39:36 +01:00
Alexander Krotov
8d81c8c1e0
Do not crash on messages without message-id
2019-11-23 22:52:16 +01:00
holger krekel
7e3c61eb41
address @dignifiedquire err.to_string() comment and avoid extra virtualenv building
2019-11-22 12:28:19 +01:00
holger krekel
bb396685ab
some comments fix imap->inbox naming in example
2019-11-22 12:28:19 +01:00
holger krekel
8ef0ea8aea
simplify double-fetching
2019-11-22 12:28:19 +01:00
holger krekel
34c766dc2b
merge JobThread::connect_to_imap with Imap::connect_configured for simplicity
2019-11-22 12:28:19 +01:00
holger krekel
a30fa710ad
resultify fetch and simplify fake_idle
2019-11-22 12:28:19 +01:00
holger krekel
fa01884350
proper handling of IdleResponse codes
2019-11-22 12:28:19 +01:00
holger krekel
eae9ad6f8b
remove context.inbox in favour of a context.inbox_thread following the mvbox_thread and sentbox_thread patterns. Also some streamlining of shutdown logic.
2019-11-22 12:28:19 +01:00
holger krekel
be533fa66a
resultify some imap operations
2019-11-22 12:28:19 +01:00
holger krekel
8e7dc5e86f
reconfigure running of rust and python tests
2019-11-22 12:28:19 +01:00
holger krekel
e13ce3140b
introduce a trigger_reconnect helper
2019-11-22 12:28:19 +01:00
holger krekel
0405c945e2
shortcut fetch/idle on mvbox/sentbox if we don't know the folder and prevent busy-looping
2019-11-22 12:28:19 +01:00
holger krekel
5293ea70ae
steramline some teardown decision code, and add webpki_roots for cert-checking
2019-11-22 12:28:19 +01:00
holger krekel
c6f4d6d8bd
* fix interrupt_idle by signalling "skip_next_idle_wait" to the potentially concurrently "fn idle" function
...
* fixes double-export issue
2019-11-22 12:28:19 +01:00
holger krekel
8723aa097e
make select_folder return ImapActionResult's and early-return from idle if there is no selected folder
2019-11-22 12:28:19 +01:00
dignifiedquire
86f66f4d78
cleanup imap impl
2019-11-22 12:28:19 +01:00
dignifiedquire
1a1a59a14e
implement idle again
2019-11-22 12:28:19 +01:00
dignifiedquire
1687e8d26f
it compiles with async-imap, remove local dependency
2019-11-22 12:28:19 +01:00
holger krekel
911c0e45dc
expose empty server functionality and test it (also introducing a new DC_EVENT_IMAP_FOLDER_EMPTIED event)
2019-10-29 22:19:13 +01:00
holger krekel
7628ee1e05
rust-part of empty_server
2019-10-29 22:19:13 +01:00
holger krekel
de3e5e1c39
fix deadlock issue with config access
2019-10-29 16:08:24 +01:00
B. Petersen
27627b4f74
show better error message for a simple 'bad credentials' error and give some more hints for other errors
2019-10-29 16:08:24 +01:00
Floris Bruynooghe
c8d296ea0e
A MsgId newtype
...
This more strongly types the ubiquitous message id type by no longer
making it an integer. It keeps the actual ID opaque. Only for the
generic job API the number keeps being used. Some locations also need
to create it from an integer and call MsgId::new().
2019-10-29 15:30:53 +01:00
holger krekel
b4464ab0a3
address @dignifiedquire comments
2019-10-28 20:51:17 +01:00
holger krekel
1cc4f56025
make imap-idle survive disconnects (during and at the beginning of an app)
2019-10-28 20:51:17 +01:00
holger krekel
1d03e0822e
seems to work
2019-10-28 20:51:17 +01:00
