holger krekel
63ad7b8d34
make to_ids const in some places, and simplify returns from create_or_lookup_adhoc_group
2019-12-05 00:56:09 +01:00
Alexander Krotov
d950a58613
Improve documentation
2019-12-04 10:15:40 +01:00
holger krekel
d09989a4ed
fix implementation of Autocrypt to encrypt if answering to an encrypted message.
...
Previously, if any of a chat's peers set prefer_encrypt to false
(i.e. "e2ee_enabled=0" in the config, a misnomer btw) then a
previously encrypted chat would drop to cleartext easily.
2019-12-04 08:57:42 +01:00
B. Petersen
b766a55b0a
in set_chat_name(), bind value to sql using ?-operator, add a test to check the name is really changed
2019-12-04 06:11:01 +01:00
B. Petersen
7b83979e10
test that the device-chat is a one-to-one-chat
2019-12-04 06:01:37 +01:00
B. Petersen
79cdcca2d2
check that sending/preparing/forwarding on a chat that cannot send really fails
2019-12-04 06:01:37 +01:00
Alexander Krotov
ad87b7c4a5
Fix clippy warnings
2019-12-03 20:20:52 +03:00
dignifiedquire
dbd6303829
remove mmime
2019-12-03 12:22:55 +01:00
B. Petersen
8923c9e5af
calculate image-size in device-messages
...
eg. android relies on that and fallsback to wrong aspect ratios otherwise.
also, this makes job.rs a little more readable
as some things are moved to message.rs :)
2019-12-03 00:58:04 +01:00
Alexander Krotov
ee18d60644
cargo fmt
2019-12-01 21:01:03 +01:00
Alexander Krotov
612600278a
Move SQL errors into their own module
2019-12-01 21:01:03 +01:00
B. Petersen
72c29aca6a
do not create device-chat on skipped messages
2019-12-01 01:38:50 +01:00
B. Petersen
32216a334d
add a test that checks the device-chat is not recreated for messages that won't be added
2019-12-01 01:38:50 +01:00
Floris Bruynooghe
74a4691f29
Convert BlobError into an enum
...
This deletes a lot of code and complexity. Though comes at some cost:
- The type no longer fits in a register and will always be on the
stack.
- Constructing the errors is more verbose, no more auto Into casting.
2019-11-30 23:51:30 +01:00
B. Petersen
4e6d0c9c69
fix places where string-cmp was used instead of addr_cmp() for email-address-comparison
2019-11-30 01:49:45 +01:00
B. Petersen
b6bb5b79af
target comments of @flub
2019-11-28 23:56:12 +01:00
B. Petersen
1d996d9ed9
track created_timetamp for chats
2019-11-28 22:38:48 +01:00
björn petersen
a88153954e
Merge pull request #854 from deltachat/tweak-device-msg
...
tweak device messages
2019-11-19 22:19:42 +01:00
Alexander Krotov
4732085421
Fix some clippy warnings
2019-11-19 19:52:13 +01:00
B. Petersen
e4e6a00fe4
rename has_device_msg() to was_device_msg_ever_added() what describes better what the function is doing
2019-11-19 13:21:02 +01:00
B. Petersen
700e10bc0e
use dc_add_device_msg() also to add labels-only, this is clearer as having a function with 'skip' in the name
2019-11-19 13:05:01 +01:00
B. Petersen
2a4c193601
simplify check for existing device-message
2019-11-19 11:56:35 +01:00
B. Petersen
d3fa289f27
streamline dc_add_device_msg_once|unlabelled() to one function
2019-11-19 11:49:02 +01:00
B. Petersen
1534a07ded
add dc_has_device_msg()
2019-11-18 17:31:03 +01:00
B. Petersen
a4e92694ba
name unlabelled device-messages as such
2019-11-18 16:47:18 +01:00
B. Petersen
035da9e5d7
add dc_skip_device_msg() and belonging tests
2019-11-18 16:47:18 +01:00
B. Petersen
fed6f4ab8a
do not re-add device-messages deleted by the user
2019-11-18 16:47:18 +01:00
B. Petersen
e9b2d6a594
adapt tests to saved-messages chat
2019-11-17 20:56:07 +01:00
B. Petersen
f9d2fe710d
rename me-chat to saved-messages, use an appropriate icon
2019-11-17 20:56:07 +01:00
Alexander Krotov
69e14dcb2d
Replace some magic numbers with constants
2019-11-16 16:08:08 +00:00
Alexander Krotov
f778957caf
Improve documentation and comments
2019-11-16 13:53:47 +01:00
Alexander Krotov
0b3f2a55df
Do not use wildcard match in msgtype_has_file
...
This way there will be a compiler error notifying that the function needs to be updated when a new message type is added.
2019-11-16 12:31:13 +01:00
B. Petersen
d808bfe400
add some tests for me-chat and deaddrop
2019-11-13 22:31:18 +01:00
B. Petersen
1b30078c09
test archive functions
2019-11-13 10:16:57 +01:00
B. Petersen
0278875e03
add device-chat tests
2019-11-13 00:13:32 +01:00
B. Petersen
d0ccf28678
do not add random label for unlabelled device-messages
2019-11-13 00:13:32 +01:00
B. Petersen
a9fe77b62e
use separate column for device-msg-labels
2019-11-12 16:10:48 +01:00
B. Petersen
a42e197634
add device-message only once
2019-11-12 16:10:48 +01:00
B. Petersen
84c6113271
use enum for show_emails
2019-11-12 16:10:48 +01:00
B. Petersen
5a11551b4d
block sending to chats that do not support sending (normally, this should already be avoided in the ui)
2019-11-06 13:33:30 +01:00
B. Petersen
231110fb61
add profile-icon for device-chat
2019-11-06 13:33:30 +01:00
B. Petersen
4c30bf80ce
target comments of @flub
2019-11-06 13:33:30 +01:00
B. Petersen
f8afefa2c1
get contact- and chat-info for device-messages
2019-11-06 13:33:30 +01:00
B. Petersen
b5d5d98645
implement add_device_msg()
2019-11-06 13:33:30 +01:00
B. Petersen
89f394ab86
create separate function for preparing a blob
2019-11-06 13:33:30 +01:00
B. Petersen
cbaa4e03b3
basic devicetalk implementation
2019-11-06 13:33:30 +01:00
B. Petersen
be08bcb22b
rename DC_CONTACT_ID_DEVICE to DC_CONTACT_ID_INFO to be in-line with dc_msg_is_info()
2019-11-06 13:33:30 +01:00
B. Petersen
8c2efa707a
name special contact-ids where easily possible
...
the point of this pr is to get an overview
how and where DC_CONTACT_ID_DEVICE is used,
to prepare introducing a device-"chat".
i did not change the sql statements for now
as this would require some more refactoring
and has the potential to introduce bugs.
2019-11-04 13:20:35 +01:00
Floris Bruynooghe
78030e4a31
Add test for #767
...
Without a test for this fix, a regression will happen again.
Original PR #767 aka commit 4fed875107
2019-10-30 21:08:25 +01:00
B. Petersen
8b5f7d98f6
do not escalate attemt to add self to a group to the user, just return false from add_contact_to_chat()
2019-10-30 14:03:54 +01:00
