Alexander Krotov
8702f290af
mimeparser: remove unused parsed_protected_headers field
2020-01-05 22:03:10 +01:00
Alexander Krotov
d0b5b7ba03
Turn handle_reports comment into documentation comment
2020-01-04 22:24:16 +01:00
Alexander Krotov
91100d3fac
Lowercase the addresses before gossip peerstate update
...
Normally it happens in addr_cmp function, but update_gossip_peerstates
forms a HashSet of addresses, so they should be lowercased beforehand.
Also adjust the mail_with_cc.txt to test for non-lowercase addresses.
2020-01-02 18:14:27 +00:00
Alexander Krotov
1468f67b9b
Warn about multiple From addresses only when necessary
...
The message says "only using first" so it should be printed right before the first address is taken with .get_index(0) operation.
2020-01-01 21:03:28 +00:00
Alexander Krotov
cb6376094c
Get rid of DC_FP_* constants
2020-01-01 20:53:31 +00:00
B. Petersen
fe741f168a
fix early exit on empty addresses in decode_openpgp()
2020-01-01 18:53:35 +01:00
B. Petersen
eaaf500d5e
add failing test for plain OPENPGP4FRP-qr-code
2020-01-01 18:52:00 +01:00
Alexander Krotov
c4e0647bda
Remove NULs from mimeparser tests
2019-12-30 17:32:39 +01:00
Alexander Krotov
6dcc1e09b9
mimeparser: add message.kml parsing test
2019-12-30 17:29:28 +01:00
Alexander Krotov
ea03e4d34a
Send location.kml instead of message.kml for streaming
...
message.kml is sent when user manually selects a point on the map to
point to a location.
2019-12-30 17:20:46 +01:00
B. Petersen
b7a2d17e93
remove weird comment
2019-12-29 18:58:49 +00:00
B. Petersen
e1bd740249
init authname when received by From: header (it is also updated from there)
2019-12-29 18:58:49 +00:00
B. Petersen
de52c2da80
add failing test for receiving authnames
2019-12-29 18:58:49 +00:00
Alexander Krotov
a31c6d82c9
Remove get_origin_by_id
2019-12-28 22:33:57 +00:00
Alexander Krotov
25842894d2
Rename job::Try into job::Status
2019-12-28 14:35:14 +00:00
Alexander Krotov
83c98c2d55
Replace unstable try_trait with a job_try! macro
2019-12-28 14:35:14 +00:00
Alexander Krotov
fe2011742d
Job error handling refactoring
2019-12-28 14:35:14 +00:00
B. Petersen
d87b676d60
do not abort search completely when updating a special name fails
2019-12-27 22:53:03 +00:00
B. Petersen
f73ba895af
remove some meanwhile unneeded allow-statements
2019-12-26 16:26:06 +00:00
B. Petersen
cb2a1147f0
fix searching for localized device chats
2019-12-26 16:23:42 +00:00
B. Petersen
6702ef4a71
add a failing test that does not fine localized device chats
2019-12-26 16:23:42 +00:00
Alexander Krotov
1d46791364
Add more Yandex domains
2019-12-26 01:48:28 +00:00
Alexander Krotov
e203901224
Better logging message for job deletion
...
The logging message printed for successful job completion said that the
job "cannot be retried" even when it does not need to be retried.
2019-12-24 10:47:29 +00:00
Alexander Krotov
76d03f7fd2
Log SMTP connection failure errors
2019-12-23 07:14:11 +01:00
B. Petersen
5bfbae4b00
add test for delete_and_reset_all_device_msgs()
2019-12-22 05:44:09 +01:00
B. Petersen
521a854635
delete and reset device-messages on import; this avoids wrong information in the device chat and allows adding correct information again
2019-12-22 05:44:09 +01:00
Alexander Krotov
67c36f3d98
Use usize to get pointer size
...
According to Rust documentation, usize is "The pointer-sized unsigned
integer type".
This change removes unnecessary libc dependency and makes top_evil_rs
script happier.
2019-12-21 23:07:35 +00:00
Alexander Krotov
8e0a29e9b5
Stop using Event callback return values
...
Since stock string callback has been deprecated, all event callbacks
return 0.
For compatibility, C declarations are not changed and FFI users are
expected to return 0 from their callbacks.
2019-12-21 22:51:44 +00:00
Alexander Krotov
47be879445
fix(job): log all job events in job_perform()
2019-12-21 15:24:30 +00:00
Alexander Krotov
860f8a7906
refactor(job): refer to std:: only once
...
This change unifies how we refer to std::time::Duration across the module.
2019-12-21 15:24:30 +00:00
Alexander Krotov
5d9baa053a
refactor(job): implement Display for Job
2019-12-21 15:24:30 +00:00
Alexander Krotov
da174eae71
refactor(job): use Display to print Thread in job_perform()
2019-12-21 15:24:30 +00:00
Alexander Krotov
cd198223ea
Remove unwrap() from time() function
...
This change is a part of the effort to enable clippy::option_unwrap_used and clippy::result_unwrap_used
2019-12-21 08:58:41 +01:00
Alexander Krotov
300fff40e3
refactor(smtp): remove unused SendTimeout Error variant
...
It was used when timeout was set on the whole smtp.send() operation.
Now only the operations inside smtp.send() can timeout, and such timeout
errors result in SendError, so SendTimeout is unused.
2019-12-21 08:57:29 +01:00
Alexander Krotov
c9f6e31ca9
Move dc_simplify.rs to simplify.rs
2019-12-20 12:55:57 +01:00
Alexander Krotov
fe4080d59f
refactor(simplify): move dehtml dependency to mimeparser
...
This change also removes unnecessary String clone for HTML messages.
2019-12-20 12:55:57 +01:00
B. Petersen
7f6a1ad1a7
add some empty lines to enums & co to make things more readable and to avoid errors this way :)
2019-12-20 12:55:42 +01:00
Alexander Krotov
980bb35441
refactor(mimefactory): use iter::repeat_with instead of (0..)
2019-12-20 12:55:25 +01:00
holger krekel
01df2e2dc7
fix #1077 for unknown senders in a group chat (such as mailer daemons): don't recreate member list and show a special stockstring-ed message advising to hit "more info".
2019-12-20 11:59:10 +01:00
Floris Bruynooghe
ec40dd1b6f
Change the JSON API function to be from a serialised struct
...
This is the first experiment towards using structs to define the API.
It adds it as a new method on the existing Chat struct.
The types in this struct could improve as well as many other things.
But this is a straight forward translation of the existing json! macro
into a struct.
2019-12-20 10:39:39 +01:00
Alexander Krotov
f2f8898004
fix(mimefactory): wrap base64-encoded attachments to 78 columns
...
RFC5322 requires emails to be wrapped to 78 columns excluding CRLF.
2019-12-20 09:11:35 +01:00
holger krekel
cc6aa3209c
fix the fix
2019-12-19 16:53:55 +01:00
holger krekel
76a86763dd
address @r10s comment
2019-12-19 16:53:55 +01:00
holger krekel
09fb039528
another reverse mut bites the dust
2019-12-19 16:53:55 +01:00
holger krekel
174d3300c4
not sure it's much better but using a static-sized array is probably better than a dynamically sized vec, thanks @dignifiedquire
2019-12-19 16:53:55 +01:00
holger krekel
8b57ce1792
remove unused include_in_contactlist
2019-12-19 16:53:55 +01:00
holger krekel
6c14e429eb
Origin::is_verified() -> Origin::is_known() because this has nothing to do with verified groups or contacts
2019-12-19 16:53:55 +01:00
holger krekel
5f200c6bc3
don't pass incoming_origin as &mut as the caller doesn't need it
2019-12-19 16:53:55 +01:00
holger krekel
d52347ee1d
also don't pass "to_id" and don't make it mut inside add_parts
2019-12-19 16:53:55 +01:00
holger krekel
d0d9aa4400
- move CC-parsing next to To-parsing where it blongs
...
- pass to_ids and from_id as immutable to add_parts
2019-12-19 16:53:55 +01:00