B. Petersen
e4b3e23769
prefer to_string_lossy() over as_str() as the latter pancis on non-wellformatted utf-8
2019-11-01 00:46:48 +01:00
dignifiedquire
dc2cf8ecfc
unify naming in pgp
2019-10-10 00:23:36 +02:00
holger krekel
1df6229e99
remove/push down some unsafe-fn
2019-10-08 17:37:37 +02:00
B. Petersen
2317518e5e
cargo fmt
2019-10-04 23:07:34 +02:00
B. Petersen
477af413c6
if in doubt, prefer unwrap_or_default()
...
if the past we had lots of crashes because of unexpected unwrap failures,
mostly related to string.
this commit avoids them eg. for string-conversions that may panic
eg. when encountering a null-byte or by logical programming errors
where an object is assumed to be set but is not under unexpected circumstances.
2019-10-04 23:07:33 +02:00
Alexander Krotov
130d485cac
Fix some clippy warnings
2019-10-03 14:30:40 +02:00
holger krekel
5c1b9c83f7
fixes #661 and also contains a cleanup of config access (only for e2ee and mdns)
2019-10-02 22:51:09 +02:00
holger krekel
ee6d16f1b1
on some call sites: peerstate.save_to_db() should bubble up errors instead of crashing.
...
also write a test that double-creation of an addr-row is fine.
2019-10-01 10:34:36 +02:00
holger krekel
ab2ef1e1e4
shift most mmime functions to wrapmime
2019-09-30 00:52:14 +02:00
holger krekel
18030fa61e
remove duplicate code and possibly a leak
2019-09-30 00:52:14 +02:00
Friedel Ziegelmayer
34b3ddf63b
refactor(e2ee): reduce unsafe spread
2019-09-28 13:20:33 -06:00
holger krekel
ca76cac314
address @flub's review comment from https://github.com/deltachat/deltachat-core-rust/pull/622
2019-09-28 03:01:52 +02:00
dignifiedquire
fb9369f333
refactor(imex): almost all unsafe gone here
2019-09-28 02:55:42 +02:00
holger krekel
f28a971b96
several fixes and streamlinings, probably verified-group encryption is fixed, or at least we should see better errors
2019-09-27 23:24:57 +02:00
holger krekel
18808d0a61
majorly rustify and simplify the incoming decryption pipeline
2019-09-27 23:24:57 +02:00
holger krekel
f45ee2ab4d
fix #615 -- like with c-core Chat-Version is left in unprotected headers because
...
it's eg used in server-filters for detecting DC messages
2019-09-27 18:28:47 +02:00
holger krekel
31f5fffc45
cargo fmt
2019-09-26 20:45:03 +02:00
holger krekel
64c518c2f2
remove ok_to_continue
2019-09-26 20:45:03 +02:00
dignifiedquire
452bce07e1
refactor(mmime): split up into modules
2019-09-26 12:36:23 +02:00
holger krekel
faa03e0e14
no functional code change: rename dc_mimefactory to mimefactory and move some functions to become MimeFactory methods
2019-09-23 20:20:34 +02:00
holger krekel
f70897a6d3
rustify new_data_part() and related sanitizations
2019-09-23 18:43:04 +02:00
holger krekel
ba231d2c5f
address @dignifiedquire comments
2019-09-23 17:10:21 +02:00
holger krekel
095cb759ed
avoid cdata_to_free trick and some more cleanups
2019-09-23 17:10:21 +02:00
holger krekel
5cbcb76039
introduce safety and a particular EncryptHelper
2019-09-23 17:10:21 +02:00
holger krekel
3388b42f20
another rustification of encrypt()
2019-09-23 17:10:21 +02:00
holger krekel
e1d541b02e
create wrapmime module and simplify some mailmime code
2019-09-23 17:10:21 +02:00
holger krekel
74d8368525
rustify references, in_reply_to, mimefactory's recipients_{addr,names}
2019-09-22 23:39:16 +02:00
holger krekel
42dd600e0c
more rustifications
2019-09-22 23:39:16 +02:00
holger krekel
f6019583b7
better looping on some clists
2019-09-22 23:39:16 +02:00
holger krekel
93f9c7cfbd
e2ee_guaranteed -> bool, rustify set_error
2019-09-22 23:39:16 +02:00
dignifiedquire
05f9f454c3
refactor: remove x module and delete deadcode
2019-09-21 17:56:49 +02:00
dignifiedquire
266b205c75
refactor: rustify interface of maimlime_transfer_decode
2019-09-21 00:51:36 +02:00
holger krekel
fb05a6c26f
transfer docs to and cleanup some parts of e2ee::decrypt()
2019-09-20 17:52:07 +02:00
dignifiedquire
8667de994e
use proper Result instead of Option for encryption and decryption
2019-09-18 19:21:41 +02:00
dignifiedquire
0346dd15d9
refactor(mimeparser): some more sanity
2019-09-16 22:58:10 +02:00
dignifiedquire
f31f341a50
feat: enforce Debug implementations and remove mod types
2019-09-15 16:36:31 +02:00
Alexander Krotov
50a812ea5e
Return bool from mailmime_transfer_decode
2019-09-14 12:03:10 +03:00
Dmitry Bogatov
7c4d7fb3dd
Make Aheader::from_imffields accept &str, not const char *
2019-09-12 06:32:13 +00:00
Dmitry Bogatov
500e80784a
Replace some of context.sql.get_config() with context.get_config()
...
Pattern `context.sql.get_config(context, {foo})` is unnecessary
redundant in Rust: unlike C, Rust has associated functions (methods).
2019-09-12 04:41:06 +00:00
Dmitry Bogatov
57daa0f7f0
Remove useless argument of logging macros
...
Previously, logging macros (info! warn! error!) accepted integer
argument (data1), that was passed to callback function verbatim. In all
call sites this argument was 0.
With this change, that data1 argument is no longer part of macro
interface, 0 is always passed to callback in internals of these macros.
2019-09-10 22:26:47 +00:00
Alexander Krotov
28cae607a4
Pass buffers to pgp.rs as slices
2019-09-09 18:50:47 +02:00
holger krekel
0a6e540394
rename dc_securejoin to securejoin.rs
2019-09-05 22:55:25 +02:00
dignifiedquire
1a1f0c0a7c
refactor(e2ee): rename dc_e2ee -> e2ee
2019-09-03 19:05:21 +02:00
