Mirrors/chatmail-core
1
0
Fork 0
mirror of https://github.com/chatmail/core.git synced 2026-05-02 12:56:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

feat: Disable partial search by contact address

Browse Source 
Implement suggestion from #7477 so that there's no incremental search by contact address in UIs,
only direct matches are returned.
This commit is contained in:
iequidoo
2025-12-07 20:47:49 -03:00
committed by iequidoo
parent d446a16fc6
commit fce91f3ee0
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/contact.rs
View File

@@ -1133,7 +1133,8 @@ VALUES (?, ?, ?, ?, ?, ?)
Origin::IncomingReplyTo Origin::IncomingReplyTo
}; };
if query.is_some() { if query.is_some() {
let s3str_like_cmd = format!("%{}%", query.unwrap_or("").to_lowercase()); let query_lowercased = query.unwrap_or("").to_lowercase();
let s3str_like_cmd = format!("%{}%", query_lowercased);
context context
.sql .sql
.query_map( .query_map(
@@ -1151,7 +1152,7 @@ ORDER BY c.origin>=? DESC, c.last_seen DESC, c.id DESC
flag_address, flag_address,
minimal_origin, minimal_origin,
&s3str_like_cmd, &s3str_like_cmd,
&s3str_like_cmd, &query_lowercased,
Origin::CreateChat, Origin::CreateChat,
), ),
|row| { |row| {

7
src/contact/contact_tests.rs
View File

@@ -85,10 +85,15 @@ async fn test_get_contacts() -> Result<()> {
assert_eq!(contacts.len(), 1); assert_eq!(contacts.len(), 1);
assert_eq!(contacts.first(), Some(&id)); assert_eq!(contacts.first(), Some(&id));
// Search by address. // Search by address is case-insensitive, but only returns direct matches.
let contacts = Contact::get_all(&context, 0, Some("alice@example.org")).await?; let contacts = Contact::get_all(&context, 0, Some("alice@example.org")).await?;
assert_eq!(contacts.len(), 1); assert_eq!(contacts.len(), 1);
assert_eq!(contacts.first(), Some(&id)); assert_eq!(contacts.first(), Some(&id));
let contacts = Contact::get_all(&context, 0, Some("Alice@example.org")).await?;
assert_eq!(contacts.len(), 1);
assert_eq!(contacts.first(), Some(&id));
let contacts = Contact::get_all(&context, 0, Some("alice@")).await?;
assert_eq!(contacts.len(), 0);
let contacts = Contact::get_all(&context, 0, Some("Foobar")).await?; let contacts = Contact::get_all(&context, 0, Some("Foobar")).await?;
assert_eq!(contacts.len(), 0); assert_eq!(contacts.len(), 0);