From f84e6033189815757ba4cab5e452ba80ea412cb9 Mon Sep 17 00:00:00 2001 From: link2xt Date: Wed, 10 Jul 2024 19:42:53 +0000 Subject: [PATCH] refactor: return error from export_backup() without logging The error is logged by `imex` caller. --- src/imex.rs | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/src/imex.rs b/src/imex.rs index 024a96373..848963803 100644 --- a/src/imex.rs +++ b/src/imex.rs @@ -375,19 +375,10 @@ async fn export_backup(context: &Context, dir: &Path, passphrase: String) -> Res dest_path.display(), ); - let res = export_backup_inner(context, &temp_db_path, &temp_path).await; - - match &res { - Ok(_) => { - fs::rename(temp_path, &dest_path).await?; - context.emit_event(EventType::ImexFileWritten(dest_path)); - } - Err(e) => { - error!(context, "backup failed: {}", e); - } - } - - res + export_backup_inner(context, &temp_db_path, &temp_path).await?; + fs::rename(temp_path, &dest_path).await?; + context.emit_event(EventType::ImexFileWritten(dest_path)); + Ok(()) } async fn export_backup_inner(